From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 7868) id 5193E3858D1E; Thu, 22 Dec 2022 11:51:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5193E3858D1E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1671709902; bh=VOOFFuiF0Wgq7JbkfWzVJKIIUWYUORES9IQ6QX+Dk9Y=; h=From:To:Subject:Date:From; b=I+3/ZAaKc/CmaObC0OPU2+wa56uWzH6083g+/vSJmarL+WlPKK4NtWsWejKxF10VF rn6O3Rl/bSWawGIUKl4arYVDDr4cawk6b9iKYBUlIDuCrRV6PAqIDfzB2HpqsAXBtC lQMELXbxQ7qSwoAQTelCEItT+5v+KRyb5fdzE33Q= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Takashi Yano To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin] Cygwin: console: Fix hangup of less on quit after the window is resized. X-Act-Checkin: newlib-cygwin X-Git-Author: Takashi Yano X-Git-Refname: refs/heads/master X-Git-Oldrev: 0a7bf8fc4c061d550bae6668a6e2cd03c67dce46 X-Git-Newrev: f6e4e98d3071c8e41f50773ec3c7683fb104b3ab Message-Id: <20221222115142.5193E3858D1E@sourceware.org> Date: Thu, 22 Dec 2022 11:51:42 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dnewlib-cygwin.git;h=3Df6e4e98d307= 1c8e41f50773ec3c7683fb104b3ab commit f6e4e98d3071c8e41f50773ec3c7683fb104b3ab Author: Takashi Yano Date: Thu Dec 22 20:25:22 2022 +0900 Cygwin: console: Fix hangup of less on quit after the window is resized. =20 https://cygwin.com/pipermail/cygwin/2022-December/252737.html =20 If the less is started from non-cygwin shell and window size is changed, it will hang-up when quitting. The cause of the proglem is that less uses longjump() in signal handler. If the signal handler is called while cygwin is acquiring the mutex, cygwin loses the chance to release mutex. With this patch, the mutex is released just before calling kill_pgrp() and re-acquired when kill_pgrp() returns. =20 Reported-by: Gregory Mason Signed-off-by: Takashi Yano Diff: --- winsup/cygwin/fhandler/console.cc | 4 ++++ winsup/cygwin/release/3.4.4 | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/winsup/cygwin/fhandler/console.cc b/winsup/cygwin/fhandler/con= sole.cc index bbf4b0103..ee07c84f8 100644 --- a/winsup/cygwin/fhandler/console.cc +++ b/winsup/cygwin/fhandler/console.cc @@ -928,7 +928,11 @@ fhandler_console::send_winch_maybe () if (wincap.has_con_24bit_colors () && !con_is_legacy && wincap.has_con_broken_tabs ()) fix_tab_position (get_output_handle ()); + /* longjmp() may be called in the signal handler like less, + so release input_mutex temporarily before kill_pgrp(). */ + release_input_mutex (); get_ttyp ()->kill_pgrp (SIGWINCH); + acquire_input_mutex (mutex_timeout); return true; } return false; diff --git a/winsup/cygwin/release/3.4.4 b/winsup/cygwin/release/3.4.4 index 6ac702375..3331b3166 100644 --- a/winsup/cygwin/release/3.4.4 +++ b/winsup/cygwin/release/3.4.4 @@ -3,3 +3,7 @@ Bug Fixes =20 - Fix an uninitialized variable having weird side-effects in path handling. Addresses: https://cygwin.com/pipermail/cygwin/2022-December/252734.html + +- Fix hang-up of less on quit which occurs when it is started from non-cyg= win + shell and window is resized. + Addresses: https://cygwin.com/pipermail/cygwin/2022-December/252737.html