public inbox for cygwin-cvs@sourceware.org help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org> To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin/main] Cygwin: disable high-entropy VA for cygcheck and strace Date: Tue, 17 Jan 2023 19:15:21 +0000 (GMT) [thread overview] Message-ID: <20230117191521.7534A3858D35@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=8d318bf142f7d740172099bfa23b6983eb8379ae commit 8d318bf142f7d740172099bfa23b6983eb8379ae Author: Corinna Vinschen <corinna@vinschen.de> AuthorDate: Tue Jan 17 17:43:21 2023 +0100 Commit: Corinna Vinschen <corinna@vinschen.de> CommitDate: Tue Jan 17 18:41:10 2023 +0100 Cygwin: disable high-entropy VA for cygcheck and strace It's not a good idea to enable high-entropy VA for tools loading the Cygwin DLL dynamically. The addresses used by HEVA tend to collide with fixed address areas managed by Cygwin. Fixes: 60675f1a7eb2 ("Cygwin: decouple shared mem regions from Cygwin DLL") Signed-off-by: Corinna Vinschen <corinna@vinschen.de> Diff: --- winsup/utils/mingw/Makefile.am | 2 ++ 1 file changed, 2 insertions(+) diff --git a/winsup/utils/mingw/Makefile.am b/winsup/utils/mingw/Makefile.am index 255fc4651021..edb314d068be 100644 --- a/winsup/utils/mingw/Makefile.am +++ b/winsup/utils/mingw/Makefile.am @@ -32,6 +32,7 @@ cygcheck_SOURCES = \ dump_setup.cc \ path.cc cygcheck_CPPFLAGS=-I$(srcdir)/.. -idirafter ${top_srcdir}/cygwin/include +cygcheck_LDFLAGS = -Wl,--disable-high-entropy-va cygcheck_LDADD = -lz -lwininet -lpsapi -lntdll cygwin_console_helper_SOURCES = cygwin-console-helper.cc @@ -42,6 +43,7 @@ strace_SOURCES = \ path.cc \ strace.cc strace_CPPFLAGS=-I$(srcdir)/.. -idirafter ${top_srcdir}/cygwin/local_includes -idirafter ${top_srcdir}/cygwin/include +strace_LDFLAGS = -Wl,--disable-high-entropy-va strace_LDADD = -lntdll noinst_PROGRAMS = path-testsuite
reply other threads:[~2023-01-17 19:15 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230117191521.7534A3858D35@sourceware.org \ --to=corinna@sourceware.org \ --cc=cygwin-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).