public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
* [newlib-cygwin/cygwin-3_4-branch] Cygwin: disable high-entropy VA for cygcheck and strace
@ 2023-01-17 19:15 Corinna Vinschen
  0 siblings, 0 replies; only message in thread
From: Corinna Vinschen @ 2023-01-17 19:15 UTC (permalink / raw)
  To: cygwin-cvs

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=cbc513cf3d32b59aa63bfdd08ae4f121309b78be

commit cbc513cf3d32b59aa63bfdd08ae4f121309b78be
Author:     Corinna Vinschen <corinna@vinschen.de>
AuthorDate: Tue Jan 17 17:43:21 2023 +0100
Commit:     Corinna Vinschen <corinna@vinschen.de>
CommitDate: Tue Jan 17 19:49:39 2023 +0100

    Cygwin: disable high-entropy VA for cygcheck and strace
    
    It's not a good idea to enable high-entropy VA for tools loading the
    Cygwin DLL dynamically.  The addresses used by HEVA tend to collide with
    fixed address areas managed by Cygwin.
    
    Fixes: 60675f1a7eb2 ("Cygwin: decouple shared mem regions from Cygwin DLL")
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Diff:
---
 winsup/utils/mingw/Makefile.am | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/winsup/utils/mingw/Makefile.am b/winsup/utils/mingw/Makefile.am
index 255fc4651021..edb314d068be 100644
--- a/winsup/utils/mingw/Makefile.am
+++ b/winsup/utils/mingw/Makefile.am
@@ -32,6 +32,7 @@ cygcheck_SOURCES = \
 	dump_setup.cc \
 	path.cc
 cygcheck_CPPFLAGS=-I$(srcdir)/.. -idirafter ${top_srcdir}/cygwin/include
+cygcheck_LDFLAGS = -Wl,--disable-high-entropy-va
 cygcheck_LDADD = -lz -lwininet -lpsapi -lntdll
 
 cygwin_console_helper_SOURCES = cygwin-console-helper.cc
@@ -42,6 +43,7 @@ strace_SOURCES = \
 	path.cc \
 	strace.cc
 strace_CPPFLAGS=-I$(srcdir)/.. -idirafter ${top_srcdir}/cygwin/local_includes -idirafter ${top_srcdir}/cygwin/include
+strace_LDFLAGS = -Wl,--disable-high-entropy-va
 strace_LDADD = -lntdll
 
 noinst_PROGRAMS = path-testsuite

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-01-17 19:15 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-17 19:15 [newlib-cygwin/cygwin-3_4-branch] Cygwin: disable high-entropy VA for cygcheck and strace Corinna Vinschen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).