public inbox for cygwin-cvs@sourceware.org help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org> To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin/main] Cygwin: memory_init: initialize user heap here Date: Wed, 18 Jan 2023 19:35:20 +0000 (GMT) [thread overview] Message-ID: <20230118193520.88CBC3858410@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=e1fcd10b48775a92b3fe7b13d2c702fab48dfff8 commit e1fcd10b48775a92b3fe7b13d2c702fab48dfff8 Author: Corinna Vinschen <corinna@vinschen.de> AuthorDate: Wed Jan 18 20:07:10 2023 +0100 Commit: Corinna Vinschen <corinna@vinschen.de> CommitDate: Wed Jan 18 20:13:38 2023 +0100 Cygwin: memory_init: initialize user heap here Eventually move user heap initialization to memory_init. The call order is not changed. Drop a now useless comment. Signed-off-by: Corinna Vinschen <corinna@vinschen.de> Diff: --- winsup/cygwin/mm/shared.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/winsup/cygwin/mm/shared.cc b/winsup/cygwin/mm/shared.cc index e68b506a9fff..40cdd472286e 100644 --- a/winsup/cygwin/mm/shared.cc +++ b/winsup/cygwin/mm/shared.cc @@ -319,14 +319,13 @@ shared_info::initialize () else if (cb != sizeof (*this)) system_printf ("size of shared memory region changed from %lu to %u", sizeof (*this), cb); - /* FIXME? Shouldn't this be in memory_init? */ - cygheap->user_heap.init (); } void memory_init () { shared_info::create (); /* Initialize global shared memory */ + cygheap->user_heap.init (); /* Initialize user heap */ user_info::create (false); /* Initialize per-user shared memory */ /* Initialize tty list session stuff. Doesn't really belong here but this needs to be initialized before any tty or console manipulation
reply other threads:[~2023-01-18 19:35 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230118193520.88CBC3858410@sourceware.org \ --to=corinna@sourceware.org \ --cc=cygwin-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).