public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org>
To: cygwin-cvs@sourceware.org
Subject: [newlib-cygwin/main] Cygwin: regex: NONCHAR: re-add cast to int
Date: Thu, 16 Mar 2023 12:55:06 +0000 (GMT)	[thread overview]
Message-ID: <20230316125506.64DEA385783F@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=2285cf0d1ccd783cedc46463fe5c7cc55c6e29a4

commit 2285cf0d1ccd783cedc46463fe5c7cc55c6e29a4
Author:     Corinna Vinschen <corinna@vinschen.de>
AuthorDate: Thu Mar 16 13:47:07 2023 +0100
Commit:     Corinna Vinschen <corinna@vinschen.de>
CommitDate: Thu Mar 16 13:47:10 2023 +0100

    Cygwin: regex: NONCHAR: re-add cast to int
    
    wint_t is unsigned int and the test checks for a negative value.  Thus,
    it's optimized out by gcc.  Add the cast from commit 44caccfca2433 to
    avoid this.
    
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Diff:
---
 winsup/cygwin/regex/engine.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/winsup/cygwin/regex/engine.c b/winsup/cygwin/regex/engine.c
index 77e7007bb1fa..5e12ab7f3735 100644
--- a/winsup/cygwin/regex/engine.c
+++ b/winsup/cygwin/regex/engine.c
@@ -119,7 +119,7 @@ static states step(struct re_guts *g, sopno start, sopno stop, states bef, wint_
 #define	EOW	(BOL-5)
 #define	BADCHAR	(BOL-6)
 #define	NWBND	(BOL-7)
-#define	NONCHAR(c)	((c) <= OUT)
+#define	NONCHAR(c)	((int)(c) <= OUT)
 /* sflags */
 #define	SBOS	0x0001
 #define	SEOS	0x0002

                 reply	other threads:[~2023-03-16 12:55 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230316125506.64DEA385783F@sourceware.org \
    --to=corinna@sourceware.org \
    --cc=cygwin-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).