From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2155) id 31F9E3858D3C; Tue, 21 Mar 2023 17:30:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 31F9E3858D3C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1679419829; bh=hqLntxnWgE8Xu6FwvumP5ZC/gwZcHzdM+bCtlvv5LJY=; h=From:To:Subject:Date:From; b=LeLyS2ZzTe7RO2/HPHb1T355gYTYeAA0SnmHiJ8rjxp3YtXk3xEirHfe8KFFOPaCn T2leE4PICWq5vMepNxFIM//ZRA/aKJdXnzrgsk7fszGPBYWyFXLhZIBQG8y2IOv8X6 byYxrlboXFFnLJf9lWiYqMrmgDc21Kv5dXsrDC98= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Corinna Vinschen To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin/main] Cygwin: fs_info::update: fix NTFS filesystem flags X-Act-Checkin: newlib-cygwin X-Git-Author: Corinna Vinschen X-Git-Refname: refs/heads/main X-Git-Oldrev: 59241913330c15d25ea569f1309af1c746dc07fa X-Git-Newrev: 0a962aa2c293aa69afbb3a52790ff14009921fe0 Message-Id: <20230321173029.31F9E3858D3C@sourceware.org> Date: Tue, 21 Mar 2023 17:30:29 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dnewlib-cygwin.git;h=3D0a962aa2c29= 3aa69afbb3a52790ff14009921fe0 commit 0a962aa2c293aa69afbb3a52790ff14009921fe0 Author: Corinna Vinschen AuthorDate: Tue Mar 21 18:01:00 2023 +0100 Commit: Corinna Vinschen CommitDate: Tue Mar 21 18:02:49 2023 +0100 Cygwin: fs_info::update: fix NTFS filesystem flags =20 These flags are used to check a remote filesystem. Not all flags supported by a local NTFS are available when checking a remote NTFS. Fix the flag set accordingly, otherwise the remote NTFS will ba handled as CIFS. =20 Fixes: fcccdc4021ff ("Cygwin: fs_info: update filesystem flags and chec= k Windows 7 flags") Signed-off-by: Corinna Vinschen Diff: --- winsup/cygwin/mount.cc | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/winsup/cygwin/mount.cc b/winsup/cygwin/mount.cc index 627d120059a3..36ab042a723a 100644 --- a/winsup/cygwin/mount.cc +++ b/winsup/cygwin/mount.cc @@ -385,9 +385,10 @@ fs_info::update (PUNICODE_STRING upath, HANDLE in_vol) | FILE_CASE_PRESERVED_NAMES \ | FILE_UNICODE_ON_DISK \ | FILE_NAMED_STREAMS) -/* These are the minimal flags supported by NTFS since Windows 7. Every - filesystem not supporting these flags is not a native NTFS. We subsume - them under the filesystem type "cifs". */ +/* These are the minimal flags supported by NTFS since Windows 7, when + checking a remote NTFS filesystem. Every filesystem not supporting the= se + flags is not a native NTFS. + We subsume them under the filesystem type "cifs". */ #define MINIMAL_WIN_NTFS_FLAGS (FILE_CASE_SENSITIVE_SEARCH \ | FILE_CASE_PRESERVED_NAMES \ | FILE_UNICODE_ON_DISK \ @@ -399,11 +400,8 @@ fs_info::update (PUNICODE_STRING upath, HANDLE in_vol) | FILE_SUPPORTS_OBJECT_IDS \ | FILE_SUPPORTS_ENCRYPTION \ | FILE_NAMED_STREAMS \ - | FILE_SUPPORTS_TRANSACTIONS \ | FILE_SUPPORTS_HARD_LINKS \ - | FILE_SUPPORTS_EXTENDED_ATTRIBUTES \ - | FILE_SUPPORTS_OPEN_BY_FILE_ID \ - | FILE_SUPPORTS_USN_JOURNAL) + | FILE_SUPPORTS_EXTENDED_ATTRIBUTES) #define FS_IS_WINDOWS_NTFS TEST_GVI(flags () & MINIMAL_WIN_NTFS_FLAGS, \ MINIMAL_WIN_NTFS_FLAGS) /* These are the exact flags of a real Windows FAT/FAT32 filesystem.