public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org>
To: cygwin-cvs@sourceware.org
Subject: [newlib-cygwin/main] Cygwin: fix unlink in container
Date: Fri, 24 Mar 2023 11:51:41 +0000 (GMT)	[thread overview]
Message-ID: <20230324115141.C943E3858D28@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=527dd1b407e7d74037a19aed6e25aa36578da2f7

commit 527dd1b407e7d74037a19aed6e25aa36578da2f7
Author:     Yoshinao Muramatsu <ysno@ac.auone-net.jp>
AuthorDate: Mon Mar 20 20:51:00 2023 +0900
Commit:     Corinna Vinschen <corinna@vinschen.de>
CommitDate: Tue Mar 21 18:56:27 2023 +0100

    Cygwin: fix unlink in container
    
    Deleting files returns STATUS_INVALID_PARAMETE on a bind mounted file system
    in hyper-v container with FILE_DISPOSITION_POSIX_SEMANTICS.
    Therefore fall back to default method.
    
    This code is suggested by Johannes Schindelin on github
    and I change it more simple.
    
    Signed-off-by: Yoshinao Muramatsu <ysno@ac.auone-net.jp>

Diff:
---
 winsup/cygwin/syscalls.cc | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/winsup/cygwin/syscalls.cc b/winsup/cygwin/syscalls.cc
index 3e2d42f3aa8b..4e278808a02b 100644
--- a/winsup/cygwin/syscalls.cc
+++ b/winsup/cygwin/syscalls.cc
@@ -733,7 +733,10 @@ unlink_nt (path_conv &pc, bool shareable)
       /* Trying to delete in-use executables and DLLs using
          FILE_DISPOSITION_POSIX_SEMANTICS returns STATUS_CANNOT_DELETE.
 	 Fall back to the default method. */
-      if (status != STATUS_CANNOT_DELETE)
+      /* Additionaly that returns STATUS_INVALID_PARAMETER
+         on a bind mounted fs in hyper-v container. Falling back too. */
+      if (status != STATUS_CANNOT_DELETE
+          && status != STATUS_INVALID_PARAMETER)
 	goto out;
     }

                 reply	other threads:[~2023-03-24 11:51 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230324115141.C943E3858D28@sourceware.org \
    --to=corinna@sourceware.org \
    --cc=cygwin-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).