From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2155) id B36CD38582AC; Wed, 29 Mar 2023 08:25:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B36CD38582AC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1680078355; bh=IdE5flBCGEDLJoN5dR0zXSv4IosMj4WuSavct2/SUps=; h=From:To:Subject:Date:From; b=YE0q/lJYkOkI0pEqmcPk3DfPtrRffJQzgF6wp46+YDlAocKmZuZolG86kNqRLO0hf 6S5sFKqVJZhlwJUuRxvq3UodHPqs7QX/2y8MDf82LX7QZvh9t3t9x/b3uXaIGKyBDs Z/uQTTaWcl4X0RZbrNPzYGjZFE3F/7LfikRm0Mak= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Corinna Vinschen To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin/main] Cygwin: dirname: fix handling of leading slashes X-Act-Checkin: newlib-cygwin X-Git-Author: Corinna Vinschen X-Git-Refname: refs/heads/main X-Git-Oldrev: 27376c60a9b870e7ba456551165897a7408b5886 X-Git-Newrev: 2898a359b80c18fb0c3d4122b8f40daed49ba11e Message-Id: <20230329082555.B36CD38582AC@sourceware.org> Date: Wed, 29 Mar 2023 08:25:55 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dnewlib-cygwin.git;h=3D2898a359b80= c18fb0c3d4122b8f40daed49ba11e commit 2898a359b80c18fb0c3d4122b8f40daed49ba11e Author: Corinna Vinschen AuthorDate: Wed Mar 29 10:18:23 2023 +0200 Commit: Corinna Vinschen CommitDate: Wed Mar 29 10:23:05 2023 +0200 Cygwin: dirname: fix handling of leading slashes =20 Per https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/xbd_chap0= 4.html: =20 "A pathname that begins with two successive slashes may be interpreted in an implementation-defined manner, although more than two leading slashes shall be treated as a single slash." =20 So more than 2 leading slashes are supposed to be folded into one, which our dirname neglected. Fix that. =20 Fixes: 24e8fc6872a3b ("* cygwin.din (basename): Export.") Signed-off-by: Corinna Vinschen Diff: --- winsup/cygwin/path.cc | 2 +- winsup/cygwin/release/3.4.7 | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/winsup/cygwin/path.cc b/winsup/cygwin/path.cc index eaf695b8182a..582238d1503f 100644 --- a/winsup/cygwin/path.cc +++ b/winsup/cygwin/path.cc @@ -5120,7 +5120,7 @@ dirname (char *path) return strcpy (buf, "."); if (isalpha (path[0]) && path[1] =3D=3D ':') bs +=3D 2; - else if (strspn (path, "/\\") > 1) + else if (strspn (path, "/\\") =3D=3D 2) ++bs; c =3D strrchr (bs, '/'); if ((d =3D strrchr (c ?: bs, '\\')) > c) diff --git a/winsup/cygwin/release/3.4.7 b/winsup/cygwin/release/3.4.7 index a121d81b62fa..2c305ec5f320 100644 --- a/winsup/cygwin/release/3.4.7 +++ b/winsup/cygwin/release/3.4.7 @@ -6,3 +6,6 @@ Bug Fixes =20 - kill(1): don't print spurious error message. Addresses: https://cygwin.com/pipermail/cygwin/2023-March/253291.html + +- Align behaviour of dirname in terms of leading slashes to POSIX: + https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap04.html