From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 7868) id 032673858D33; Fri, 14 Apr 2023 03:37:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 032673858D33 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1681443463; bh=r51AGaplbbVyNGHEqBXpYK5pbne6PnwMclQdWu3oDlQ=; h=From:To:Subject:Date:From; b=BVJTH3oQgMYhtk/WcqvhXSBuXhyaWhyc6qtvD38Eork1tFEFlURK1MtmFxexwQeLP SNmd/ikJ2p0YRM+HAxYpStGarL/EMWzrKxojPUNVv66YPf+1k2RSlm9MtaFf73f9vI WM/TWJcvTBolo+5dEI1RywVcobVPi3EhEbDWHw0Y= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Takashi Yano To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin] Cygwin: pty: Fix reading CONIN$ when stdin is not a pty. X-Act-Checkin: newlib-cygwin X-Git-Author: Takashi Yano X-Git-Refname: refs/heads/master X-Git-Oldrev: ef75abddc76a914aabbb976dd116e39ab196bd28 X-Git-Newrev: e5fcc5837c9594ccb7d0d6f40af69f266f606c5b Message-Id: <20230414033743.032673858D33@sourceware.org> Date: Fri, 14 Apr 2023 03:37:43 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dnewlib-cygwin.git;h=3De5fcc5837c9= 594ccb7d0d6f40af69f266f606c5b commit e5fcc5837c9594ccb7d0d6f40af69f266f606c5b Author: Takashi Yano Date: Fri Apr 14 10:52:08 2023 +0900 Cygwin: pty: Fix reading CONIN$ when stdin is not a pty. =20 Previously, the pty master sends inputs to the pipe for cygwin app even when pseudo console is activated if stdin is not the pty. This causes the problem that key input is not sent to non cygwin app even if the app opens CONIN$. This patch sets switch_to_nat_pipe to true regardless whether stdin is the pty or not to allow that case. =20 https://cygwin.com/pipermail/cygwin/2023-April/253424.html =20 Reported-by: Wladislav Artsimovich Signed-off-by: Takashi Yano Diff: --- winsup/cygwin/fhandler/pty.cc | 6 ++++++ winsup/cygwin/release/3.4.7 | 3 +++ 2 files changed, 9 insertions(+) diff --git a/winsup/cygwin/fhandler/pty.cc b/winsup/cygwin/fhandler/pty.cc index 664d7dbc6..03c859172 100644 --- a/winsup/cygwin/fhandler/pty.cc +++ b/winsup/cygwin/fhandler/pty.cc @@ -3222,6 +3222,11 @@ fhandler_pty_slave::setup_pseudoconsole () return false; } =20 + /* Set switch_to_nat_pipe regardless whether stdin is the pty or not + so that the non-cygwin app can work when it opens CONIN$. */ + bool switch_to_nat_pipe_orig =3D get_ttyp ()->switch_to_nat_pipe; + get_ttyp ()->switch_to_nat_pipe =3D true; + HANDLE hpConIn, hpConOut; if (get_ttyp ()->pcon_activated) { /* The pseudo console is already activated. */ @@ -3499,6 +3504,7 @@ cleanup_pseudo_console: CloseHandle (tmp); } fallback: + get_ttyp ()->switch_to_nat_pipe =3D switch_to_nat_pipe_orig; return false; } =20 diff --git a/winsup/cygwin/release/3.4.7 b/winsup/cygwin/release/3.4.7 index 2c305ec5f..941519ebc 100644 --- a/winsup/cygwin/release/3.4.7 +++ b/winsup/cygwin/release/3.4.7 @@ -9,3 +9,6 @@ Bug Fixes =20 - Align behaviour of dirname in terms of leading slashes to POSIX: https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap04.html + +- Fix reading CONIN$ in non cygwin apps when stdin is not a pty. + Addresses https://cygwin.com/pipermail/cygwin/2023-April/253424.html