From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2155) id BFF9A3858D35; Wed, 26 Jul 2023 13:18:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BFF9A3858D35 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1690377521; bh=Sh+8aMhci8WTVkPlgrPrQGK9jRBC6UAQqOln6jgBzJo=; h=From:To:Subject:Date:From; b=hK398ViDvifbugLSbdqbbE1I4CzvCq/GuYo1fuisY4lyqtS24H+sQG7PC8o1IGAcE 19T2x3UY8iCQGtSKZexniS+qerM/mLaNoMPGJcgrTcng+DC+h+vOClqffp9BhSKYOz +x6pvHhh7U2aogJ/OZHf6EM/3WdM0zFvGUctQNQA= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Corinna Vinschen To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin/main] Cygwin: gen_full_path_at: drop never reached code X-Act-Checkin: newlib-cygwin X-Git-Author: Corinna Vinschen X-Git-Refname: refs/heads/main X-Git-Oldrev: 25d65d6ec0532742d2d4121e4ddfda6295a4da78 X-Git-Newrev: ae03aa7303bff5d6814bc6c9e681128aee42eb6a Message-Id: <20230726131841.BFF9A3858D35@sourceware.org> Date: Wed, 26 Jul 2023 13:18:41 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dnewlib-cygwin.git;h=3Dae03aa7303b= ff5d6814bc6c9e681128aee42eb6a commit ae03aa7303bff5d6814bc6c9e681128aee42eb6a Author: Corinna Vinschen AuthorDate: Wed Jul 12 13:31:31 2023 +0200 Commit: Corinna Vinschen CommitDate: Wed Jul 26 15:13:47 2023 +0200 Cygwin: gen_full_path_at: drop never reached code =20 The check if the local variable p is NULL is useless. The preceeding code always sets p to a valid pointer, or it crashes if path_ret is invalid (which would be a bug in Cygwin). =20 Fixes: c57b57e5c43a ("* cygwin.din: Sort.") Reviewed-by: Johannes Schindelin Signed-off-by: Corinna Vinschen Diff: --- winsup/cygwin/syscalls.cc | 5 ----- 1 file changed, 5 deletions(-) diff --git a/winsup/cygwin/syscalls.cc b/winsup/cygwin/syscalls.cc index f1cd5693edf5..8d3ec46f3a3c 100644 --- a/winsup/cygwin/syscalls.cc +++ b/winsup/cygwin/syscalls.cc @@ -4449,11 +4449,6 @@ gen_full_path_at (char *path_ret, int dirfd, const c= har *pathname, } p =3D stpcpy (path_ret, cfd->get_name ()); } - if (!p) - { - set_errno (ENOTDIR); - return -1; - } if (pathname) { if (!*pathname)