From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 7868) id C0AB43857C71; Fri, 1 Sep 2023 10:06:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C0AB43857C71 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1693562797; bh=N4lu81vJKzcfIxdeOZPMv/6tjpc/NHEVCafxsE0KDzA=; h=From:To:Subject:Date:From; b=NNELjJC6w9IlI3sx7K8strzHlaS6I+k4y5CAip/kvk5SBMHs4lxshOnkm6jG9Ec6+ dJkpaWE7vtOGKYRjo6+NLMrcTaZjy7BsXSNdHwSQWzL+3na4ZpSpgEfTAxD9uF8bEP 4vADSZXsFUTs9bwO2dwBlA5BrNHR7vGCyZvH+8bU= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Takashi Yano To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin/cygwin-3_4-branch] Cygwin: dsp: Fix a few trivial bugs. X-Act-Checkin: newlib-cygwin X-Git-Author: Takashi Yano X-Git-Refname: refs/heads/cygwin-3_4-branch X-Git-Oldrev: d9476b95ea433568be7551ae1c44513b9170881e X-Git-Newrev: 930f210b21c59298944f237002c36db0b990a4d9 Message-Id: <20230901100637.C0AB43857C71@sourceware.org> Date: Fri, 1 Sep 2023 10:06:37 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dnewlib-cygwin.git;h=3D930f210b21c= 59298944f237002c36db0b990a4d9 commit 930f210b21c59298944f237002c36db0b990a4d9 Author: Takashi Yano Date: Fri Sep 1 11:32:51 2023 +0900 Cygwin: dsp: Fix a few trivial bugs. =20 Signed-off-by: Takashi Yano Diff: --- winsup/cygwin/fhandler/dsp.cc | 4 ++-- winsup/cygwin/local_includes/fhandler.h | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/winsup/cygwin/fhandler/dsp.cc b/winsup/cygwin/fhandler/dsp.cc index db7b2550e..d930328ce 100644 --- a/winsup/cygwin/fhandler/dsp.cc +++ b/winsup/cygwin/fhandler/dsp.cc @@ -1062,7 +1062,7 @@ fhandler_dev_dsp::fixup_after_exec () int fhandler_dev_dsp::open (int flags, mode_t) { - int ret =3D 0, err =3D 0; + int ret =3D -1, err =3D 0; UINT num_in =3D 0, num_out =3D 0; set_flags ((flags & ~O_TEXT) | O_BINARY); // Work out initial sample format & frequency, /dev/dsp defaults @@ -1095,7 +1095,7 @@ fhandler_dev_dsp::open (int flags, mode_t) =20 debug_printf ("ACCMODE=3D%y audio_in=3D%d audio_out=3D%d, err=3D%d, ret= =3D%d", flags & O_ACCMODE, num_in, num_out, err, ret); - if (ret) + if (ret >=3D 0) being_closed =3D false; return ret; } diff --git a/winsup/cygwin/local_includes/fhandler.h b/winsup/cygwin/local_= includes/fhandler.h index abff2e08f..649a43184 100644 --- a/winsup/cygwin/local_includes/fhandler.h +++ b/winsup/cygwin/local_includes/fhandler.h @@ -2791,6 +2791,8 @@ class fhandler_dev_dsp: public fhandler_base =20 void close_audio_in (); void close_audio_out (bool =3D false); + + public: bool use_archetype () const {return true;} =20 fhandler_dev_dsp (void *) {}