From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2155) id A3CB63858C01; Sat, 9 Sep 2023 21:29:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A3CB63858C01 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1694294971; bh=40KNuW0vQhGppizXckhSUY45FRFWHjxt9brtAsLOw6M=; h=From:To:Subject:Date:From; b=XXyixHR0UVTtNnBlD93+ozpUReo53p6C1P6x6CYkuh1D7QxNInYXqFnx3N8ZRLXVS mB3C7lW48nhUfRmejzxED1BwNuCfoiNnWlRr2bveo1GW7Nug302ceyPQYSeHQyZ4sw OKaotujLE0FIlnF6NQZDKtYGOHKUYMa0zsTJF7Qo= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Corinna Vinschen To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin/main] Cygwin: NFS: remove recognizing native symlinks as FIFOs X-Act-Checkin: newlib-cygwin X-Git-Author: Corinna Vinschen X-Git-Refname: refs/heads/main X-Git-Oldrev: c0aa6ac30ec483ad6da6af701625e7aea7536663 X-Git-Newrev: 5bbe0e56c617fbdf608d416592b6609af0e73211 Message-Id: <20230909212931.A3CB63858C01@sourceware.org> Date: Sat, 9 Sep 2023 21:29:31 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dnewlib-cygwin.git;h=3D5bbe0e56c61= 7fbdf608d416592b6609af0e73211 commit 5bbe0e56c617fbdf608d416592b6609af0e73211 Author: Corinna Vinschen AuthorDate: Sat Sep 9 23:26:21 2023 +0200 Commit: Corinna Vinschen CommitDate: Sat Sep 9 23:28:55 2023 +0200 Cygwin: NFS: remove recognizing native symlinks as FIFOs =20 Given the downsides of NFS symlinks as FIFOs, drop the code added to recognize them as such. =20 Fixes: 622fb0776ea3 ("Cygwin: enable usage of FIFOs on NFS") Signed-off-by: Corinna Vinschen Diff: --- winsup/cygwin/path.cc | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/winsup/cygwin/path.cc b/winsup/cygwin/path.cc index 0c9d3921a0ea..1c3583d763a9 100644 --- a/winsup/cygwin/path.cc +++ b/winsup/cygwin/path.cc @@ -3532,21 +3532,6 @@ restart: { case NF3LNK: res =3D check_nfs_symlink (h); - /* Enable Cygwin-created FIFOs to be recognized as FIFOs. - We have to overwrite the NFS fattr3 data, otherwise the - info returned by Cygwin's stat will still claim the file - is a symlink. */ - if (res && contents[0] =3D=3D ':' && contents[1] =3D=3D '\\' - && parse_device (contents) && major =3D=3D _major (FH_FIFO)) - { - conv_hdl.nfsattr ()->type =3D NF3FIFO; - conv_hdl.nfsattr ()->mode =3D mode; - conv_hdl.nfsattr ()->size =3D 0; - /* Marker for fhandler_base::fstat_by_nfs_ea not to override - the cached fattr3 data with fresh data from the filesystem, - even if the handle is used for other purposes than stat. */ - conv_hdl.nfsattr ()->filler1 =3D NF3FIFO; - } break; case NF3FIFO: /* Enable real FIFOs recognized as such. */