From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2155) id C73FE385841C; Tue, 31 Oct 2023 12:31:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C73FE385841C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1698755519; bh=JzE7VbfO7EDgTK6RYQZH0IFJYfy9uCClP80qBeupZ4Y=; h=From:To:Subject:Date:From; b=lCLyy+ACDGIElcUk2U1SXivO9DPwRFnLU8S0seJkCVFZ2xfWnOQL4KweEbImm+nCu b2zzGCS8QhZFZV1jDjqIcnoCKcg9Wn4D42llTTA96gBK8BLdTBTt1VmFz3j/saJ0aj /u4P7HmwshxKlekcoDTyOPlSVFz59tENFnR20ZfU= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Corinna Vinschen To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin/main] Cygwin: let feraiseexcept actually raise an exception X-Act-Checkin: newlib-cygwin X-Git-Author: Corinna Vinschen X-Git-Refname: refs/heads/main X-Git-Oldrev: 60d1eeac6c6185ac77b181929c773015a2772fe8 X-Git-Newrev: 2ef627c46eb2b7cbc359088e5619be74637e9b90 Message-Id: <20231031123159.C73FE385841C@sourceware.org> Date: Tue, 31 Oct 2023 12:31:59 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dnewlib-cygwin.git;h=3D2ef627c46eb= 2b7cbc359088e5619be74637e9b90 commit 2ef627c46eb2b7cbc359088e5619be74637e9b90 Author: Corinna Vinschen AuthorDate: Tue Oct 31 13:07:36 2023 +0100 Commit: Corinna Vinschen CommitDate: Tue Oct 31 13:27:51 2023 +0100 Cygwin: let feraiseexcept actually raise an exception =20 The exception handling inside of Cygwin functions marked as SIGFE covers exceptions and lets the library code handle them gracefully. If these functions want to raise an exception, they have to send a signal explicitely via raise(3). =20 That's not what we want in feraiseexcept(). It triggers a floating point exception explicitely by calling the i387 op "fwait". Being marked as SIGFE, this exception will be suppressed and the normal exception handling won't kick in. =20 Fix this by moving feraiseexcept into the NOSIGFE realm. =20 Fixes: 0f81b5d4bcaa ("* Makefile.in (DLL_OFILES): Add new fenv.o module= .") Signed-off-by: Corinna Vinschen Diff: --- winsup/cygwin/cygwin.din | 2 +- winsup/cygwin/release/3.4.10 | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/winsup/cygwin/cygwin.din b/winsup/cygwin/cygwin.din index 3afadb7f3a77..d5e8f8c05ef8 100644 --- a/winsup/cygwin/cygwin.din +++ b/winsup/cygwin/cygwin.din @@ -534,7 +534,7 @@ fegetround NOSIGFE feholdexcept SIGFE feof SIGFE feof_unlocked SIGFE -feraiseexcept SIGFE +feraiseexcept NOSIGFE ferror SIGFE ferror_unlocked SIGFE fesetenv SIGFE diff --git a/winsup/cygwin/release/3.4.10 b/winsup/cygwin/release/3.4.10 index c75283991461..ec28cdf7e791 100644 --- a/winsup/cygwin/release/3.4.10 +++ b/winsup/cygwin/release/3.4.10 @@ -6,3 +6,6 @@ Bug Fixes =20 - Fix hang in process initialization if cwd is unreadable. Addresses: https://cygwin.com/pipermail/cygwin/2023-October/254604.html + +- Let feraiseexcept actually raise an exception. + Addresses: https://cygwin.com/pipermail/cygwin/2023-October/254667.html