public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org>
To: cygwin-cvs@sourceware.org
Subject: [newlib-cygwin/main] Cygwin: posix_fallocate(3): fix offset and length sanity check
Date: Tue,  5 Dec 2023 21:21:26 +0000 (GMT)	[thread overview]
Message-ID: <20231205212126.992AA3858C60@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=295bef07d6bd18cd58746e46b400faadfb54b712

commit 295bef07d6bd18cd58746e46b400faadfb54b712
Author:     Corinna Vinschen <corinna@vinschen.de>
AuthorDate: Tue Dec 5 22:08:01 2023 +0100
Commit:     Corinna Vinschen <corinna@vinschen.de>
CommitDate: Tue Dec 5 22:19:05 2023 +0100

    Cygwin: posix_fallocate(3): fix offset and length sanity check
    
    - len must not be <= 0
    - offset + len must not exceed off_t (max. file size)
    
    Fixes: 7636b5859062 ("* autoload.cc (NtSetInformationFile): Define.")
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Diff:
---
 winsup/cygwin/syscalls.cc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/winsup/cygwin/syscalls.cc b/winsup/cygwin/syscalls.cc
index b73391d8f84e..3edb55bc608f 100644
--- a/winsup/cygwin/syscalls.cc
+++ b/winsup/cygwin/syscalls.cc
@@ -3030,8 +3030,10 @@ extern "C" int
 posix_fallocate (int fd, off_t offset, off_t len)
 {
   int res = 0;
-  if (offset < 0 || len == 0)
+  if (offset < 0 || len <= 0)
     res = EINVAL;
+  else if (INT64_MAX - len < offset)
+    res = EFBIG;
   else
     {
       cygheap_fdget cfd (fd);

                 reply	other threads:[~2023-12-05 21:21 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231205212126.992AA3858C60@sourceware.org \
    --to=corinna@sourceware.org \
    --cc=cygwin-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).