From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2155) id 311E63858427; Tue, 23 Jan 2024 08:51:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 311E63858427 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1705999862; bh=gwHfAeBSpofukppv/lxKLTN6xCBcOK9ku8qRjmn2+vc=; h=From:To:Subject:Date:From; b=XOff7FkBs4yIiE8lOEpvAYLfwoXPg5/sL9GAhl8DY5GiZqpbABBloPiVIE2S2uzxf n7nPi5zH3oD1BpTfRSruxQm/fdi3XYkMI0v9gjuUNFaD23bK1zX2Gcy513I/DHzXUM CuFNf5cK9PdX5yZvU7WvFONaSRTdlBNmyurjBgms= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Corinna Vinschen To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin/main] Cygwin: seekdir: don't set errno X-Act-Checkin: newlib-cygwin X-Git-Author: Corinna Vinschen X-Git-Refname: refs/heads/main X-Git-Oldrev: 72b6105518afd82e01abe946ba5867f98d6be37a X-Git-Newrev: 02572ff089dcefed1e2e25f420be975f1ee7340c Message-Id: <20240123085102.311E63858427@sourceware.org> Date: Tue, 23 Jan 2024 08:51:01 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dnewlib-cygwin.git;h=3D02572ff089d= cefed1e2e25f420be975f1ee7340c commit 02572ff089dcefed1e2e25f420be975f1ee7340c Author: Corinna Vinschen AuthorDate: Mon Jan 22 19:59:09 2024 +0100 Commit: Corinna Vinschen CommitDate: Tue Jan 23 09:49:02 2024 +0100 Cygwin: seekdir: don't set errno =20 Commit 3f3bd1010455 ("* Throughout, use __try/__except/__endtry blocks = [...]") introduced setting EINVAL, marked as "Diagnosis". The reason for this is lost in time and space, but looks very much like a debug helper which was supposed to be removed before release. It's rather pointless, so remove it. =20 Fixes: 3f3bd1010455 ("* Throughout, use __try/__except/__endtry blocks = [...]") Signed-off-by: Corinna Vinschen Diff: --- winsup/cygwin/dir.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/winsup/cygwin/dir.cc b/winsup/cygwin/dir.cc index a181ce58c7ec..d67ac02d9159 100644 --- a/winsup/cygwin/dir.cc +++ b/winsup/cygwin/dir.cc @@ -235,7 +235,6 @@ seekdir (DIR *dir, long loc) dir->__flags &=3D dirent_info_mask; ((fhandler_base *) dir->__fh)->seekdir (dir, loc); } - set_errno (EINVAL); /* Diagnosis */ } __except (EFAULT) {} __endtry