public inbox for cygwin-cvs@sourceware.org help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org> To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin/main] Cygwin: pinfo: use stpcpy where appropriate Date: Thu, 1 Feb 2024 11:39:39 +0000 (GMT) [thread overview] Message-ID: <20240201113940.1ED4338582A7@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=b1d64ac265f01f2efcff495b963982ca741269d9 commit b1d64ac265f01f2efcff495b963982ca741269d9 Author: Corinna Vinschen <corinna@vinschen.de> AuthorDate: Tue Jan 30 20:42:37 2024 +0100 Commit: Corinna Vinschen <corinna@vinschen.de> CommitDate: Wed Jan 31 20:11:58 2024 +0100 Cygwin: pinfo: use stpcpy where appropriate ...rather than strcpy/strchr. Signed-off-by: Corinna Vinschen <corinna@vinschen.de> Diff: --- winsup/cygwin/pinfo.cc | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/winsup/cygwin/pinfo.cc b/winsup/cygwin/pinfo.cc index bfd338e5b85a..f6a9712a4164 100644 --- a/winsup/cygwin/pinfo.cc +++ b/winsup/cygwin/pinfo.cc @@ -515,7 +515,7 @@ const char * _pinfo::_ctty (char *buf) { if (!CTTY_IS_VALID (ctty)) - strcpy (buf, "no ctty"); + stpcpy (buf, "no ctty"); else { device d; @@ -1170,10 +1170,7 @@ _pinfo::cmdline (size_t& n) char *p; p = s = (char *) cmalloc_abort (HEAP_COMMUNE, n); for (char **a = __argv; *a; a++) - { - strcpy (p, *a); - p = strchr (p, '\0') + 1; - } + p = stpcpy (p, *a) + 1; } return s; } @@ -1231,10 +1228,7 @@ _pinfo::environ (size_t& n) char *p, *s; p = s = (char *) cmalloc_abort (HEAP_COMMUNE, n); for (char **e = env; *e; e++) - { - strcpy (p, *e); - p = strchr (p, '\0') + 1; - } + p = stpcpy (p, *e) + 1; return s; }
reply other threads:[~2024-02-01 11:39 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240201113940.1ED4338582A7@sourceware.org \ --to=corinna@sourceware.org \ --cc=cygwin-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).