public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org>
To: cygwin-cvs@sourceware.org
Subject: [newlib-cygwin/main] Cygwin: CW_CMDLINE_ALLOC: fix a pontentially undefined return value
Date: Thu,  1 Feb 2024 12:34:59 +0000 (GMT)	[thread overview]
Message-ID: <20240201123459.ABAA83858D33@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=92b7ba4bb8ac2218bc376d883dc7944a4f23d66b

commit 92b7ba4bb8ac2218bc376d883dc7944a4f23d66b
Author:     Corinna Vinschen <corinna@vinschen.de>
AuthorDate: Thu Feb 1 13:34:52 2024 +0100
Commit:     Corinna Vinschen <corinna@vinschen.de>
CommitDate: Thu Feb 1 13:34:52 2024 +0100

    Cygwin: CW_CMDLINE_ALLOC: fix a pontentially undefined return value
    
    cmdline has to be initialized, otherwise the return value is
    undefined in case generating the command line fails.
    
    Fixes: 732afede9358 ("Cygwin: redefine CW_CMDLINE to CW_CMDLINE_ALLOC")
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Diff:
---
 winsup/cygwin/external.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/winsup/cygwin/external.cc b/winsup/cygwin/external.cc
index 555422b83ece..6dfd11c44470 100644
--- a/winsup/cygwin/external.cc
+++ b/winsup/cygwin/external.cc
@@ -349,7 +349,7 @@ cygwin_internal (cygwin_getinfo_types t, ...)
 	{
 	  size_t n;
 	  char *cmdline_cheap;
-	  char *cmdline;
+	  char *cmdline = NULL;
 
 	  pid_t pid = va_arg (arg, pid_t);
 	  pinfo p (pid);

                 reply	other threads:[~2024-02-01 12:34 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240201123459.ABAA83858D33@sourceware.org \
    --to=corinna@sourceware.org \
    --cc=cygwin-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).