public inbox for cygwin-cvs@sourceware.org help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org> To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin/cygwin-3_5-branch] Cygwin: newgrp: only allow group from supplementary group list Date: Sat, 24 Feb 2024 12:13:45 +0000 (GMT) [thread overview] Message-ID: <20240224121345.A9691385841B@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=32024ec7f723112a46dae8c7ff17b5ec1157021e commit 32024ec7f723112a46dae8c7ff17b5ec1157021e Author: Corinna Vinschen <corinna@vinschen.de> AuthorDate: Sat Feb 24 12:59:28 2024 +0100 Commit: Corinna Vinschen <corinna@vinschen.de> CommitDate: Sat Feb 24 13:12:37 2024 +0100 Cygwin: newgrp: only allow group from supplementary group list Windows only allows to set the primary group to a group already present in the TOKEN_GROUP list. Cygwin OTOH fakes success at setgid() time, to allow a subsequent call to setuid() to do the actual account switching. To have a sane behaviour in the command line tool, check group membership and disallow to switch to groups other than those already present in the user token. Fixes: 8bd56ec873453 ("Cygwin: newgrp: first full version") Signed-off-by: Corinna Vinschen <corinna@vinschen.de> Diff: --- winsup/doc/utils.xml | 8 +++----- winsup/utils/newgrp.c | 24 ++++++++++++++++++++++++ 2 files changed, 27 insertions(+), 5 deletions(-) diff --git a/winsup/doc/utils.xml b/winsup/doc/utils.xml index 692dae38f5b4..aae1ba643364 100644 --- a/winsup/doc/utils.xml +++ b/winsup/doc/utils.xml @@ -2116,11 +2116,9 @@ D: on /d type fat (binary,user,noumount) has been given as argument, a command and its arguments can be specified on the command line.</para> - <para>Please note that setting the primary group to any arbitrary group - is no privileged operation on Windows. However, even if this group is - not in your current user token, or if the group is in your user token - but marked as <literal>deny-only</literal>, no additional permissions - can be obtained by setting this group as primary group.</para> + <para>The new primary group must be either the old primary group, or + it must be part of the supplementary group list. Setting the primary + group to an arbitrary group is not allowed in Windows.</para> </refsect1> <refsect1 id="newgrp-seealso"> diff --git a/winsup/utils/newgrp.c b/winsup/utils/newgrp.c index e312a3c51d38..414e8cdf8edc 100644 --- a/winsup/utils/newgrp.c +++ b/winsup/utils/newgrp.c @@ -136,6 +136,7 @@ main (int argc, const char **argv) char **child_env; bool new_child_env = false; gid_t gid; + int ngrps; setlocale (LC_ALL, ""); @@ -176,6 +177,29 @@ main (int argc, const char **argv) ++argv; } + /* Windows does not allow to set the primary group to another group if + it's not already part of the supplementary group list. However, our + setgid() allows this, otherwise OpenSSH and other account-switching + processes wouldn't work, given we only actually switch the user + context at setuid() time. Therefore we test this here and don't + allow other groups. */ + ngrps = getgroups (0, NULL); + if (ngrps > 0) + { + gid_t *glist = (gid_t *) alloca (ngrps * sizeof (gid_t)); + + ngrps = getgroups (ngrps, glist); + while (--ngrps >= 0) + if (gid == glist[ngrps]) + break; + if (ngrps < 0) + { + fprintf (stderr, "%s: can't switch primary group to '%s'\n", + program_invocation_short_name, gr->gr_name); + return 2; + } + } + /* Set primary group */ if (setgid (gid) != 0) {
reply other threads:[~2024-02-24 12:13 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240224121345.A9691385841B@sourceware.org \ --to=corinna@sourceware.org \ --cc=cygwin-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).