public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org>
To: cygwin-cvs@sourceware.org
Subject: [newlib-cygwin/main] Cygwin: /proc: fix mem leak in opendir in error case
Date: Wed, 20 Mar 2024 13:50:02 +0000 (GMT)	[thread overview]
Message-ID: <20240320135002.8992A3858C39@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=8bd6ba8f16ec7ae07118d5f0d552efe421b008a5

commit 8bd6ba8f16ec7ae07118d5f0d552efe421b008a5
Author:     Corinna Vinschen <corinna@vinschen.de>
AuthorDate: Wed Mar 20 14:48:55 2024 +0100
Commit:     Corinna Vinschen <corinna@vinschen.de>
CommitDate: Wed Mar 20 14:48:55 2024 +0100

    Cygwin: /proc: fix mem leak in opendir in error case
    
    Fixes: 1f08558f14e45 ("* fhandler.h (fhandler_proc::opendir): Declare.")
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Diff:
---
 winsup/cygwin/fhandler/proc.cc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/winsup/cygwin/fhandler/proc.cc b/winsup/cygwin/fhandler/proc.cc
index cb754185b833..a508d4b14d94 100644
--- a/winsup/cygwin/fhandler/proc.cc
+++ b/winsup/cygwin/fhandler/proc.cc
@@ -243,6 +243,8 @@ fhandler_proc::opendir (int fd)
   DIR *dir = fhandler_virtual::opendir (fd);
   if (dir && !(dir->__handle = (void *) new winpids ((DWORD) 0)))
     {
+      free (dir->__d_dirname);
+      free (dir->__d_dirent);
       free (dir);
       dir = NULL;
       set_errno (ENOMEM);

                 reply	other threads:[~2024-03-20 13:50 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240320135002.8992A3858C39@sourceware.org \
    --to=corinna@sourceware.org \
    --cc=cygwin-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).