From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2155) id 2D58B3858C98; Thu, 4 Apr 2024 16:24:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2D58B3858C98 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1712247857; bh=huoF+OUxC4QIlrSGEUKbCppAcLo62BK4MpViIUDsdwA=; h=From:To:Subject:Date:From; b=YftmfyjhLvP5uxn+GDkSlZL50WkSbnYUx091ZYjesIxXOr2e5ROMqR382YtlzpVti lHFv5xUCkNn8ewv172M1DyzC/L050wENpb7MO4v+jDE65svH1proYejUmYMT6EhK3c QbfUSyz/6/zC4OJ2Vg0dxP2lA99RjWgASRt/CZ78= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Corinna Vinschen To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin/main] Cygwin: FILE_OPEN_NO_RECALL is incompatible with FILE_DIRECTORY_FILE X-Act-Checkin: newlib-cygwin X-Git-Author: Corinna Vinschen X-Git-Refname: refs/heads/main X-Git-Oldrev: ed50a50b9b551ed693d28cd458a49e5196d27f06 X-Git-Newrev: 56e7563b9aa665f35b657537e46a7feb4726f763 Message-Id: <20240404162417.2D58B3858C98@sourceware.org> Date: Thu, 4 Apr 2024 16:24:17 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dnewlib-cygwin.git;h=3D56e7563b9aa= 665f35b657537e46a7feb4726f763 commit 56e7563b9aa665f35b657537e46a7feb4726f763 Author: Corinna Vinschen AuthorDate: Thu Apr 4 17:36:01 2024 +0200 Commit: Corinna Vinschen CommitDate: Thu Apr 4 18:21:13 2024 +0200 Cygwin: FILE_OPEN_NO_RECALL is incompatible with FILE_DIRECTORY_FILE =20 If FILE_DIRECTORY_FILE is given, FILE_OPEN_NO_RECALL is not allowed, otherwise NtCreateFile returns STATUS_INVALID_PARAMETER. =20 Drop FILE_OPEN_NO_RECALL where FILE_DIRECTORY_FILE is specified. =20 Fixes: f6b56abec186 ("Cygwin: try to avoid recalling offline files") Reported-by: Bruce Jerrick Signed-off-by: Corinna Vinschen Diff: --- winsup/cygwin/fhandler/disk_file.cc | 1 - winsup/cygwin/path.cc | 2 -- winsup/cygwin/release/3.5.4 | 6 ++++++ 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/winsup/cygwin/fhandler/disk_file.cc b/winsup/cygwin/fhandler/d= isk_file.cc index 865a05ad95a2..724ce7f7a587 100644 --- a/winsup/cygwin/fhandler/disk_file.cc +++ b/winsup/cygwin/fhandler/disk_file.cc @@ -325,7 +325,6 @@ fhandler_base::fstat_by_name (struct stat *buf) status =3D NtOpenFile (&dir, SYNCHRONIZE | FILE_LIST_DIRECTORY, &attr, &io, FILE_SHARE_VALID_FLAGS, FILE_SYNCHRONOUS_IO_NONALERT - | FILE_OPEN_NO_RECALL | FILE_OPEN_FOR_BACKUP_INTENT | FILE_DIRECTORY_FILE); if (!NT_SUCCESS (status)) diff --git a/winsup/cygwin/path.cc b/winsup/cygwin/path.cc index fa5ceea1065a..5cfcbc0f2f6e 100644 --- a/winsup/cygwin/path.cc +++ b/winsup/cygwin/path.cc @@ -608,7 +608,6 @@ getfileattr (const char *path, bool caseinsensitive) /*= path has to be always ab status =3D NtOpenFile (&dir, SYNCHRONIZE | FILE_LIST_DIRECTORY, &attr, &io, FILE_SHARE_VALID_FLAGS, FILE_SYNCHRONOUS_IO_NONALERT - | FILE_OPEN_NO_RECALL | FILE_OPEN_FOR_BACKUP_INTENT | FILE_DIRECTORY_FILE); if (NT_SUCCESS (status)) @@ -3340,7 +3339,6 @@ restart: status =3D NtOpenFile (&dir, SYNCHRONIZE | FILE_LIST_DIRECTORY, &dattr, &io, FILE_SHARE_VALID_FLAGS, FILE_SYNCHRONOUS_IO_NONALERT - | FILE_OPEN_NO_RECALL | FILE_OPEN_FOR_BACKUP_INTENT | FILE_DIRECTORY_FILE); if (!NT_SUCCESS (status)) diff --git a/winsup/cygwin/release/3.5.4 b/winsup/cygwin/release/3.5.4 new file mode 100644 index 000000000000..e2bd025317e9 --- /dev/null +++ b/winsup/cygwin/release/3.5.4 @@ -0,0 +1,6 @@ +Fixes: +------ + +- Fix regression in 3.5.3 which fails to open files for stat(2) if the + file is opened exclusively by another process. + Addresses: https://cygwin.com/pipermail/cygwin/2024-April/255811.html