From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2072d.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe5b::72d]) by sourceware.org (Postfix) with ESMTPS id 3F01E3857432 for ; Sun, 22 May 2022 16:19:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3F01E3857432 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=cornell.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cornell.edu ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hWRWCH1QfAlwut9tEZvsEPIacJUVRzRv3w8zUfhHHOFLjZW1Fkm8uxv0MYe2/wPn+rVtNeKFRA/7+HE/XIw+Z6WnwLWZmuqqihu7zpQBDliqhDwl/IB3KBD6qGsX8Vgg//4fpTf587vLZ9u0JVR59ClFhUCItP0mldGF80HhJ7wODnsG6DH0g+OJlpzkzQsoS7vTop04V2QhJZ0/z8wHbIQrqCANwoMHMHhKCX/aUaIfJBO+hjGV0JrKb4MiyU9/Vum82yOIu6+7c8g3jxruscxmDuw/A4UJDa2KC3BdiksbaOB4JwAul5+ya58H55lcnf7U5vWQRLh46PVNEKqGKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uLoEItMRRj+8Pk/3wzesGMTmauas1dX/0wvnD6352yI=; b=LBXO53rOY06rVI7AcJEgZ9Zn+CSQr/jilCqiXME1DVqWnBxgzI7rBHv+C6IvAVvUUdU8H75+JLc8mHyiF1qRCQxo5K8IPElq2cXIrKrlAPLrX94TIgLdxGl9CX59yF+xRmiwgKr4VdyIzPLFtVesX5XVllRK0oZ5mtq0SK/BAKU6LpIB7UHv1radCGRjWpCNHHyx6TRGPI1SJ0tGTG9TgoqW51nia+74FeqzTVAuDPIbL18xbdNdSZBt+8h36kMlmUn7tBt4gPaoYK9O0gjuxH2BEknQ3GUw4zN8x9nECdKNylZ/mi1ZAwtbiCgVK3lkFpEHD6FXhm26jQKnRgpZiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu; dkim=pass header.d=cornell.edu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cornell.edu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uLoEItMRRj+8Pk/3wzesGMTmauas1dX/0wvnD6352yI=; b=HXprdisYGCacLpqokGP8cve8L20DoaPPilprqeJk/AfRyE9iDP6noeiLHB4plrlA1yZxfdqhx9yftkMkLshXl+Ci40QwrMbnIEKNGfbcGD0C4WIU+ZAWAP6A60jKAipvXJ/wqjaBjNJNjt2uQg471rHIRzTBzzXaGbkHIzsll9o= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=cornell.edu; Received: from BN7PR04MB4388.namprd04.prod.outlook.com (2603:10b6:406:f8::19) by SA0PR04MB7291.namprd04.prod.outlook.com (2603:10b6:806:e6::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.16; Sun, 22 May 2022 16:19:29 +0000 Received: from BN7PR04MB4388.namprd04.prod.outlook.com ([fe80::ed45:6a5d:b109:673e]) by BN7PR04MB4388.namprd04.prod.outlook.com ([fe80::ed45:6a5d:b109:673e%6]) with mapi id 15.20.5273.022; Sun, 22 May 2022 16:19:29 +0000 Message-ID: <1c72647b-86b8-2d93-20bb-90a82e9507dc@cornell.edu> Date: Sun, 22 May 2022 12:19:28 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: mknod bug? Content-Language: en-US To: cygwin-developers@cygwin.com References: From: Ken Brown In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MN2PR14CA0013.namprd14.prod.outlook.com (2603:10b6:208:23e::18) To BN7PR04MB4388.namprd04.prod.outlook.com (2603:10b6:406:f8::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 076d418c-7810-412b-bef6-08da3c0ed8b0 X-MS-TrafficTypeDiagnostic: SA0PR04MB7291:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oMfkrFQxDMlBz5dpe3r7Eg9LTrCXUS2msfMvY22FbcGHHDnofarToJG/xrzXCUmXGwo5cww93AeQ+ddWF2qFkhO9L2glLJuKqcbkXngfk0pbvRuyAuLrxFtlC2MdwSk3YraeqWmx96lL1x1tEP7KDPkkLF4I98SehJ7AOuXQ8wFkPY7W9Olu+rcB7EqIkrsJGvgN2TThvvsUh4/UvuOWmOKHMXyyQgGMYirRPwyaRmouL0mkF+t54US8KtriKt/iaqPjkYteja/L+BfeGPua91zSfldzPkKwfxMN5Ej2j0gqBgwPNzvALsXj005BxipNq9QdPpW9Z/SLqHBX3FOsnZpdtZHkMWd0CDIitapipX3NuycFo2AYw5O4I3MsgIDw3+qodcwDCe6/RQqwGgx6B8rUHF7c1LO4aUGJgZHnrbKP+kwpM2dnKGDbN5Zp110r57u298mgOZrMf6yCSeKFmBpzx9IAF+AtpwWBfQn9Oz9C2Ay7ADUPy6WyZRmKqraTPpiEBQHh/wn5f/wWQ3mhN/fjJRhW9Zdno5DxL+O6evjBdxHOAaUMd/iR4GDAQ40h7rMo9dScr8FN9xcHK1eTfxa6erV9WDCDIwjab5uJyL2A4Mdz1P+kVHS5xiyuriQ+VidOHGBaIHHxBKSgBIdb5sBGcleDEFdBCBIaXxp2KzrHlDW1xl1nLZWKbw2Lh+d0UfZ7z6Cq7anj71hc5/rN7MjvO1QfJJRVlrwvBGdflnY= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN7PR04MB4388.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(508600001)(2906002)(66556008)(66476007)(6916009)(66946007)(8676002)(786003)(316002)(86362001)(31696002)(6486002)(7116003)(186003)(2616005)(83380400001)(36756003)(75432002)(6512007)(6506007)(5660300002)(3480700007)(8936002)(38100700002)(53546011)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VXM4NzhNN0pJKzcrR1NzNzB1U08zb2gwWUNCbkVxemYwUXpsVDJRN1BQRnZE?= =?utf-8?B?UGl2WHg0YU4vajZXY0c1OGtyWUFoQjRqZmRWNU9FMUFPUmRUdjBUMUFKWGRk?= =?utf-8?B?RFcvM3ZYZ3RQQlZWeFErU3pHR3BLOHVObmE3YXdDOFFEbzhFcnJ1M05QZFZS?= =?utf-8?B?MHZVWWhFTXJFREFDRklmTEs1dFV6QnJDUm93endhUU1wcFo5VjA0YWt2dm55?= =?utf-8?B?RWNDYjBWZWh6di8xQ1pUTGF1MDBMSGdVUXVSRnd2Z3l0STlBR1ZXRk40dmwx?= =?utf-8?B?WWplSzZNZjhRMXduampmZkM0cFJUNmRScGFDSDBXeHJVTk9nc1NRd2d0eE41?= =?utf-8?B?WC9VNXdOcVU3cXNXNVhjbjIraUFoTGRXck5aN3NOVkM2SUtRbW9OMTdaS1F1?= =?utf-8?B?U2piWk1Mdms3WVJnMlRKdVRKTklVWi9GeDluaE1hUzMrc2o3SFdMNnIzNW5h?= =?utf-8?B?WjFrWVFFWWQ3a0hyYmxZU0RUaVF3M2dseDE0L1dGNHJ3ZFZ0WEhrM2gvMERK?= =?utf-8?B?MjBRZEF5V1ZUVFZYVWU5S3lrT3VoUzdaUG1vTWFDbml2dkR2OC8yUzRBZjl1?= =?utf-8?B?bys3WUY4dmJ1U05vdjh3UkVIbnU1bnBEVGlQS0ZXdUV5dUoyTW9oZlRiOTEv?= =?utf-8?B?S3M5bWVKb0hxVk9oZ09WaFRSWFVTZDJ0djRxWFpzVjU3MVRESDdYRWNNNmx6?= =?utf-8?B?eC9ZbHdUeVI1MmNrOUFhUm9IWjNJZDNsNWRJdkNnVGN4dWJHYjRwZm9pK3Ev?= =?utf-8?B?RUFiL1BKRzFvYWlvd0lVc095TFczNUsrSElva1YrOVhaSmdWTUY1a053dk4w?= =?utf-8?B?NHRraDR3WlNpMFpvOHhrS3BnclFYam94OFZwNHZKY0RUM1lNK3NkbkhlOG95?= =?utf-8?B?cEx4dCtFaTJSQTByQjFyNFZvNFZsRkZtRkR1dC9CdGlPNm93ME1Pckp6NThC?= =?utf-8?B?L2RJWlkzMVNMK1V0QkpKMXdWdXNDSDFLSVpEVTlTR0VuTVVyTHBFaEo2TkpQ?= =?utf-8?B?bmJtcGN3SUpnYk1nMktwb2xjUGcwbWJUYlluc2FrNTZUKzg0ZnE0SnBDbzNw?= =?utf-8?B?bjI5TEY1SmpaTDl0NFUxelBPVG1rUWh6UUJxcEJrb2NLWHZ6ZVN3TXhhd0Mw?= =?utf-8?B?T0l3bW5CaWdVTldDRm9FSHI5MVFpTmtLcFNjYWg1enRDb3pGQ3B0anVnTGZJ?= =?utf-8?B?YmwwTHBCVU1OZ0RGMHBGcmU2c3VMQ2dnQ0FEWWtyQVo0UzdQWG1LaGN4czJI?= =?utf-8?B?SDZWZGc0cFFjbE1oWGk4WHdwaWsyMmtLbmY2emtsNFEzUkxkNEFIRW1kSld5?= =?utf-8?B?ZmkyTFNzZW1LSUpaSysrV1VQa2dud0lEalJoVXFjWjAvR2swVGN5MXNXTElE?= =?utf-8?B?MkFyZVZrelhGVitsWlpsNnRXK2N4NWpMcnVKNlRlblB4V1JTYTZrYllGYWxM?= =?utf-8?B?RmpPVWI1YTg2a3RyUVZmSUh0UGVQczZrOUpveHBNNngrVUxpaGdNRTlKekVN?= =?utf-8?B?QTlhbjBoeDdUcS8vWHg4VTZ6VHJKT0JUbjlkOUlxdi9ZbTlaSFkwNThGNzlW?= =?utf-8?B?eXB2bEdGTGo5KzBsanlWd2lBdDRjRDRlVTBOOGNidFJlV2k3OS9lcTkwcXlj?= =?utf-8?B?Qi94OW56emxSV3ZjdTQ4Z09uSzNTUU9LYWR4NE90bEgyZXZTdHhCMEtsVnZK?= =?utf-8?B?Slh2dmJENXFaazBzRnRnRkI3R0ErUWRka2FnZ0tGMUEyV3dsK3NGaEYrZ0ps?= =?utf-8?B?NkFkK3YzcWhGWlBYeHhlTHVrWlhWZEhqUGZTallTYUE2Znh3ekdsR200SjNB?= =?utf-8?B?VVBibFVUZjd2U0FWQ01CRTV6bDlLclI2N2xGc3cvaHBQQjlrQXA1UzREU2xF?= =?utf-8?B?TXVxa054SFFCNlJIZWhQKys4TUdsSHprT1VmcWRCa3JhOE00Q2dvNmlZRmho?= =?utf-8?B?blFWTzlRM0RzeXFlRzdhL3ArbUJKUGtLb0hqbnFGMzdDWkFWNE5wdXNxR3Zl?= =?utf-8?B?RXA0ZzBDeFJrcm5zMGswakVIaWxTK2tjN0JKb0VKM2hIdjZodXp2S1ViL1Fi?= =?utf-8?B?aWFNNjBFRlJ1dFlZS1Q2cVV2VG9pSmV6eVVqd0pJbFErK2I1ZmVEZ3pCNzYv?= =?utf-8?B?cE1jTTl0enRzUzdiOE5nV0tHSGhPdlBGem5VcEpqYmJBckxaLzlVRy9vODVa?= =?utf-8?B?TUJ5enJ1WmQxbW0xK0l4Q04rY01FYm90VHI2Sjl0ZXZaUUpCQktSM1hDRUl1?= =?utf-8?B?NzJ1MWRLNUR6U0pCV1VjS1MvNjVwaG9vck5jYWFPTUU5WDZkSzYrM2s1cFk1?= =?utf-8?B?SjZzMk5yQS85SCtHaGhuYy9jUFNocTIzRjI4bzl1engyL2VuS2hrdnUrM09T?= =?utf-8?Q?+BssSQgYK2Op6UdJ6dclW4HW3Pf2MBCaxjh0nAlenL5Cs?= X-MS-Exchange-AntiSpam-MessageData-1: XVksL+LHUrRkjw== X-OriginatorOrg: cornell.edu X-MS-Exchange-CrossTenant-Network-Message-Id: 076d418c-7810-412b-bef6-08da3c0ed8b0 X-MS-Exchange-CrossTenant-AuthSource: BN7PR04MB4388.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2022 16:19:28.9954 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1RIOImVkkFXzOlQPgtKSVCvIiSvCYJGZe5hNnIjwlyPiGv0BtJjSnQCXlVbxAbIgNbxH0E9bXapP7rDJaC0Jww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR04MB7291 X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, JMQ_SPF_NEUTRAL, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 May 2022 16:19:34 -0000 On 5/21/2022 5:22 PM, Ken Brown wrote: > The definition of mknod in syscalls.cc has a third argument of type __dev16_t > instead of dev_t.  This doesn't matter on 32-bit Cygwin, because calls to mknod > are redirected to mknod32 via NEW_FUNCTIONS in Makefile.am [cygwin-3_3-branch > only].  Presumably this definition exists for the sake of old 32-bit apps that > were built when dev_t was 16 bits. > > But it seems to be a clear bug on 64-bit Cygwin.  I think we need the following, > similar to what we do for many other syscalls: > > diff --git a/winsup/cygwin/syscalls.cc b/winsup/cygwin/syscalls.cc > index 3a652c4f4..344d1d329 100644 > --- a/winsup/cygwin/syscalls.cc > +++ b/winsup/cygwin/syscalls.cc > @@ -3490,11 +3490,15 @@ mknod32 (const char *path, mode_t mode, dev_t dev) >    return -1; >  } > > +#ifdef __i386__ >  extern "C" int >  mknod (const char *_path, mode_t mode, __dev16_t dev) >  { >    return mknod32 (_path, mode, (dev_t) dev); >  } > +#else > +EXPORT_ALIAS (mknod32, mknod) > +#endif > >  extern "C" int >  mkfifo (const char *path, mode_t mode) > > If I'm right, this is a longstanding bug, and I'm surprised no one has noticed > it before.  Am I missing something? I sent the patch to cygwin-patches. Any comments should probably go there. Ken