From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5844 invoked by alias); 14 Apr 2015 14:58:56 -0000 Mailing-List: contact cygwin-developers-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-developers-owner@cygwin.com Mail-Followup-To: cygwin-developers@cygwin.com Received: (qmail 5827 invoked by uid 89); 14 Apr 2015 14:58:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-HELO: calimero.vinschen.de Received: from aquarius.hirmke.de (HELO calimero.vinschen.de) (217.91.18.234) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Apr 2015 14:58:50 +0000 Received: by calimero.vinschen.de (Postfix, from userid 500) id 2B1A8A807D2; Tue, 14 Apr 2015 16:58:48 +0200 (CEST) Date: Tue, 14 Apr 2015 14:58:00 -0000 From: Corinna Vinschen To: cygwin-developers@cygwin.com Subject: Re: [newlib-cygwin] Fix thinko in creating the {DEF_}CLASS_OBJ value on old-style ACLs Message-ID: <20150414145848.GK7343@calimero.vinschen.de> Reply-To: cygwin-developers@cygwin.com Mail-Followup-To: cygwin-developers@cygwin.com References: <20150414084240.119932.qmail@sourceware.org> <552D0DA8.3050405@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="VYvi4N5CyHZx5xNE" Content-Disposition: inline In-Reply-To: <552D0DA8.3050405@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-04/txt/msg00001.txt.bz2 --VYvi4N5CyHZx5xNE Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1952 On Apr 14 06:52, Eric Blake wrote: > On 04/14/2015 02:42 AM, Corinna Vinschen wrote: > > https://sourceware.org/git/gitweb.cgi?p=3Dnewlib-cygwin.git;h=3D4065352= 2b942addc65070275c89078d15aa8b4d5 > >=20 > > commit 40653522b942addc65070275c89078d15aa8b4d5 > > Author: Corinna Vinschen > > Date: Tue Apr 14 10:42:29 2015 +0200 > >=20 > > Fix thinko in creating the {DEF_}CLASS_OBJ value on old-style ACLs > >=20=20=20=20=20 > > * sec_acl.cc (get_posix_access): Don't use GROUP_OBJ access to fix= up > > CLASS_OBJ mask on old-style ACLs. Fix a comment. > >=20=20=20=20=20 > > Signed-off-by: Corinna Vinschen > >=20 >=20 > > - /* Accommodate Windows: Never add SYSTEM and Admins > > - perms to CLASS_OBJ perms. */ > > + /* Accommodate Windows: Never add SYSTEM and Admins to > > + CLASS_OBJ. Unless (implicitely) if they are the >=20 > s/implicitely/implicitly/ >=20 > > + GROUP_OBJ entry. */ > > if (ace_sid !=3D well_known_system_sid > > && ace_sid !=3D well_known_admins_sid) > > class_perm |=3D lacl[pos].a_perm; > > @@ -774,11 +775,12 @@ get_posix_access (PSECURITY_DESCRIPTOR psd, > > if (!new_style) > > { > > /* Fix up DEF_CLASS_OBJ value. */ > > - if (type & (USER | GROUP_OBJ | GROUP)) > > + if (type & (USER | GROUP)) > > { > > has_def_class_perm =3D true; > > - /* Accommodate Windows: Never add SYSTEM and Admins > > - perms to CLASS_OBJ perms. */ > > + /* Accommodate Windows: Never add SYSTEM and Admins to > > + CLASS_OBJ. Unless (implicitely) if they are the >=20 > and again >=20 > (same goes for "explicitly" - not in this patch, but I've noticed you > often add the 'e' there too) Fixed in CVS^Wgit. Thanks, Corinna --=20 Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat --VYvi4N5CyHZx5xNE Content-Type: application/pgp-signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVLSsoAAoJEPU2Bp2uRE+g6PcP+QFOzD7w20mZhHPQSO9pLScB Zed7V4LG3zZP/EO8INnRY4GTxSq2TGOyd1hJof6rlUTr+rAMDbdlmfteCCv1B74y FbbxmbYWEM9FCpLrPbRE4pjsl5fipDVnR/JssWnfEIN4AWdnKnRrJkP8NqDzPGAl Y4vCR5qFg3bBAMI0wwIT/U36osBHNdjyFaApyHBsz0EPoXTvHr88gRZlA0JazXLl 6FfuaGFyKhzY3leLmAKLYyImSo5OEUZFnh7UwatJYTkDjcImgcbY3cG67gV9VPOR OtO25cBk7JXfbrgIpQ/GJ9/E+j0u3HziaK6UicMAWxyBUM7b1ukstb36Siv632zN u78lqxmvXLbm6R8nSH4a2TazYuAB2qCVwNsHXHvofvmv4dtTnkK5kwZ3oNj+z3rE xdPjZlOedQekShz8MPyDLl5Se2mCLTXYTg53r+iKzzq4GyNQhiWzskJ5zzSknhcQ UIX5A4FmXubWtrpTc8riqVFLbdcUG0YFxem/JDWJ9paLtvRVr68eDowm58JdKfWV Izr3qmxXOG+eQygw4h4RqWVthl/TVbtt9FNyNxM2e18b4JY1Ee4Pzp9wZvxhrND+ 3EaGLTAoP1ytpyzXKdd/geuvCLnySd3kkD22AGYGm30Juue2HywR0+//bGZP38w+ Dk5l9dB0183I6OUaGOPn =LFDA -----END PGP SIGNATURE----- --VYvi4N5CyHZx5xNE--