From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31543 invoked by alias); 9 Apr 2018 09:57:32 -0000 Mailing-List: contact cygwin-developers-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-developers-owner@cygwin.com Mail-Followup-To: cygwin-developers@cygwin.com Received: (qmail 31529 invoked by uid 89); 9 Apr 2018 09:57:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-102.1 required=5.0 tests=AWL,BAYES_00,GOOD_FROM_CORINNA_CYGWIN,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=rot, H*Ad:U*cygwin-developers, matrix X-HELO: mout.kundenserver.de Received: from mout.kundenserver.de (HELO mout.kundenserver.de) (212.227.126.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Apr 2018 09:57:28 +0000 Received: from calimero.vinschen.de ([217.91.18.234]) by mrelayeu.kundenserver.de (mreue005 [212.227.15.167]) with ESMTPSA (Nemesis) id 0MXkkl-1f1NFC3yRL-00Wqr9 for ; Mon, 09 Apr 2018 11:57:26 +0200 Received: by calimero.vinschen.de (Postfix, from userid 500) id 2C325A81EC9; Mon, 9 Apr 2018 11:57:25 +0200 (CEST) Date: Mon, 09 Apr 2018 09:57:00 -0000 From: Corinna Vinschen To: cygwin-developers@cygwin.com Subject: Re: winpty injection Message-ID: <20180409095725.GP18998@calimero.vinschen.de> Reply-To: cygwin-developers@cygwin.com Mail-Followup-To: cygwin-developers@cygwin.com References: <20180405084733.GP2833@calimero.vinschen.de> <848d804d-8dad-a176-4fa9-a51e1544da3a@towo.net> <075cb1a4-7508-306b-a3a6-a1d9db939ba9@towo.net> <8dbc29b9-eb6e-9385-9ef4-cd7bc00099f2@towo.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RIYY1s2vRbPFwWeW" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-UI-Out-Filterresults: notjunk:1;V01:K0:Eu6YAqMtvFE=:RE2tH37bTVKBMFx/TuQGqn b44HA9en0NF8CfWSHJNFtshkyC5Xr3+gf3ivA/TSTGoyFD7dC/aS4TNdy1xvLIVQmgAfw0A05 Sx0ZccFqHxiImSyLCabi1ZaEfJodb5NB1RyEb5Tls8WMhWKZulzXfcCNeGB2AZTXT/M3ue1Ya +5bF3Guxpcz1YTaldbag0YSouWbX7Gcl6HWQD5VWCad/4WhfDjNn6EEvAqx+3/I5Svw0PTpwO CNpwyX4QDm2YCvAVSws+E7HnJLNRLtylsH7n3P38cD5fTJ2dvdZfWS2zdxFHmRyZ3ZuXEenY0 pUkfIrNz7Vt1SvQKrJoelWpAbtuaaPGkmBlnyQd3M+NEAi7SKoYpWfT7qu9EplYaOfaRcPNT9 gSMUa2U5dF6dVjpH0ElEN5+eQ2fgIvi7vomxYUnJdhq87Ydt22906Rgb1PkSrpu8kYkjw0hLj auedqtnXKhrZYnAP0cOUdh2Nwy+o1MhpeWGl/5+YwJfkxnJVCxg1W2GL9Em7jw8j6BOhitbAl YpygRPLvE8tx+kbDCC1YPUqbvKZbf68CVCn/6L+AyC9u43lraa8jM2E8WGxejt3MsT9JeoowL +baXiMfMWD8/t1/8Tu4Z8veCdTorj7uTYs+GnEzooEVQDrUNcSzleZzBhrnGK+4+9fdl0bRCn 3wbFQAFNodadWqIgHc5pPDXgEiqFGSOUxXyhFWKtsvgKryET7Zoh9OtAYDD4Nbvqztq0tswOt bpTNiTprirlCSsCaVf6923ovP+e2NQ59MELjdg== X-SW-Source: 2018-04/txt/msg00016.txt.bz2 --RIYY1s2vRbPFwWeW Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 2480 On Apr 6 21:22, Johannes Schindelin wrote: > Hi Thomas, >=20 > On Fri, 6 Apr 2018, Thomas Wolff wrote: >=20 > > Am 06.04.2018 um 12:31 schrieb Johannes Schindelin: > > > > > > On Fri, 6 Apr 2018, Thomas Wolff wrote: > > > > > > > These symptoms suggest to me: winpty is not the culprit, but its > > > > presence in the invocation chain seems to trigger the effect in a > > > > yet unclear way. > > > > > > Sure, `winpty` is not the culprit. > > > > > Actually, as it turns out, winpty *is* the culprit. I've raised winpty > > issue https://github.com/rprichard/winpty/issues/140 about it. >=20 > I am not sure you understand the issue here. The `winpty` helper opens a > Win32 console for the native Windows application to use. Then it polls > this (hidden) console for changes and tries to reflect them in the Cygwin > pty. >=20 > If that Windows application writes something to that console containing > Escape sequences, then those Escape sequences occupy certain cells in that > matrix of rows and columns making up that console. >=20 > However, if the Windows application uses random-access functions to put > individual characters into cells specified by given absolute positions, > winpty cannot tell the difference. So what winpty would be asked to > consider an ANSI sequence may never have been an ANSI sequence. >=20 > Sure, this is a construed example, but it shows that you should not be so > sure that winpty *can* detect ANSI sequences and handle them in a way that > *you* want. > [...] > In the least, therefore, it should be configurable. And I would even argue > that the default behavior should remain the same as current in Cygwin: do > not use winpty by default. >=20 > Of course, this is just my opinion, and I am but a user and infrequent > contributor to Cygwin. But I would hope that the Cygwin maintainers use a > lot of care and reluctant deliberation when considering a potentially > disruptive change such as this, a change that may very well occupy a lot > of time in dealing with the unwanted fallout. Point taken. Nicely explained. However, that makes calling winpty from Cygwin a somewhat questionable endeavor. Adding optional code paths which are in all likelyhood not used very often, thus not tested very often, thus bound to rot, are not really something I'm looking forward to. Corinna --=20 Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat --RIYY1s2vRbPFwWeW Content-Type: application/pgp-signature; name="signature.asc" Content-length: 833 -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEoVYPmneWZnwT6kwF9TYGna5ET6AFAlrLOQQACgkQ9TYGna5E T6B39BAAo8Jm016bLKM90xHo/dGqlRXWjcviJGLDY2cA61y1xCsQOOmUDEq6/yBC GR0gwMNmpJdG/StXf1k4rCavC8cF/lwcyxieAEEAfg9JKA/l4wINz5oEgM2vVOpG DIeBtBmmclOHv5b7yrtD+vyNeQDwh4qE7dJfxA0s+BOKtnHpXQeei93pbPEJjEyF +rzfZ2TKT6JZkaV/N+q5jwIPCtZgS3L/MWnLb8D2gMFklvQbW/Mc2G5EXaYp162Z mUPBjUsvEnMsqF3SyhlVHuy7amzOhWpjuUaHf/8hhPZOhuOmGEqO+yG/yXzC5fzq nfrnyJ1kqwj+maQngkqQfYO6bNxAhjxWtxKJURta59wRChOnd3nHQhd8VP6o1fNl ma4aie5zEk59mGUbB+hZNr9gfySoj88B1Ejv03/2ZVZnNVGePdxXMeXdoAE08h6i 5JpAEvn+UJpDT3ENAGaEncdTiZwODzTy4CSLXqAM63aGqPRkVZq9aXWFJLyyCk3u D9s63ShxUbk9xBqh09eiwHr5maB/HlkAXcU4UtJE8x9pvfTpuQARFNRgGd6dTtFb 9ZKtuMyxzlQ3Mcd0CuEo0VAgUnw6Lb2cc+d/X3yAbIQRi16o4xrDQqVwEMAoks4v V98OwYExrEn2oef9UH91a/hapjeDAPRXxuEsmz8pSMSR9fm+4IE= =TJ5r -----END PGP SIGNATURE----- --RIYY1s2vRbPFwWeW--