public inbox for cygwin-developers@cygwin.com
 help / color / mirror / Atom feed
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-developers@cygwin.com
Subject: Re: Shared memory
Date: Fri, 28 Feb 2020 11:41:00 -0000	[thread overview]
Message-ID: <20200228114129.GE4045@calimero.vinschen.de> (raw)
In-Reply-To: <eeef552c-9b61-509b-b918-b8bd01cbe07c@cornell.edu>

[-- Attachment #1: Type: text/plain, Size: 785 bytes --]

On Feb 27 15:35, Ken Brown wrote:
> Hi Corinna,
> 
> I think I see how to enable FIFOs to be opened for reading multiple times,
> by using shared memory to maintain data needed by all readers.
> 
> To this end I'm trying to imitate some of what you did in
> fhandler_socket_unix.cc, and I find I'm confused about the use of
> reopen_shmem. When this is called by fhandler_socket_unix::dup, shouldn't
> the call actually be
> 
>   fhs->reopen_shmem () ?
> 
> It's the new fhandler that needs to open the shared memory, isn't it?  Or am
> I misunderstanding something?

You're right.  And then it's also called too early.
It should only be called after fhs->shmem_handle is valid.

I applied a patch.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2020-02-28 11:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-27 20:35 Ken Brown
2020-02-28 11:41 ` Corinna Vinschen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200228114129.GE4045@calimero.vinschen.de \
    --to=corinna-cygwin@cygwin.com \
    --cc=cygwin-developers@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).