From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from conssluserg-04.nifty.com (conssluserg-04.nifty.com [210.131.2.83]) by sourceware.org (Postfix) with ESMTPS id 90A0E39960EA for ; Sat, 18 Jul 2020 05:07:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 90A0E39960EA Received: from Express5800-S70 (v038192.dynamic.ppp.asahi-net.or.jp [124.155.38.192]) (authenticated) by conssluserg-04.nifty.com with ESMTP id 06I57KDX016416; Sat, 18 Jul 2020 14:07:20 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-04.nifty.com 06I57KDX016416 X-Nifty-SrcIP: [124.155.38.192] Date: Sat, 18 Jul 2020 14:07:33 +0900 From: Takashi Yano To: cygwin-developers@cygwin.com Subject: Re: New implementation of pseudo console support (experimental) Message-Id: <20200718140733.f04fc48ff55b203064b7ce0d@nifty.ne.jp> In-Reply-To: References: <20200513211609.011d188c3a735b00d55591df@nifty.ne.jp> <20200514182859.c5236a8889ab3081d2e8c937@nifty.ne.jp> <20200514183420.c246647a6d9e396d42c6b47e@nifty.ne.jp> <20200516092956.74369d694d611b1dcd095607@nifty.ne.jp> <20200516164735.2a2ef183788b151e9185ef41@nifty.ne.jp> <20200519224018.746f6324badd8a5762df42b1@nifty.ne.jp> <20200525195332.cf60ab2f38d167a76513740e@nifty.ne.jp> <20200526100955.30b1a2baea517e0565f30db6@nifty.ne.jp> <20200529004024.0c2ac3c68b588bda987e0837@nifty.ne.jp> <20200701204751.27609a8f5701010468521a87@nifty.ne.jp> <20200717111912.GG3784@calimero.vinschen.de> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Jul 2020 05:08:01 -0000 Hi Ken, Thanks for testing. On Fri, 17 Jul 2020 08:52:15 -0400 Ken Brown via Cygwin-developers wrote: > On 7/17/2020 7:19 AM, Corinna Vinschen wrote: > > Hi Takashi, > > > > On Jul 1 20:47, Takashi Yano via Cygwin-developers wrote: > >> On Fri, 29 May 2020 00:40:24 +0900 > >> Takashi Yano via Cygwin-developers wrote: > >>> On Tue, 26 May 2020 10:09:55 +0900 > >>> Takashi Yano via Cygwin-developers wrote: > >>>> On Mon, 25 May 2020 19:53:32 +0900 > >>>> Takashi Yano via Cygwin-developers wrote: > >>>>> On Tue, 19 May 2020 22:40:18 +0900 > >>>>> Takashi Yano via Cygwin-developers wrote: > >>>>>> On Sat, 16 May 2020 16:47:35 +0900 > >>>>>> Takashi Yano via Cygwin-developers wrote: > >>>>>>> On Sat, 16 May 2020 09:29:56 +0900 > >>>>>>> Takashi Yano via Cygwin-developers wrote: > >>>>>>>> Fix a small bug caused when stdio is redirected to another pty. > >>>>>>> > >>>>>>> Fix another bug caused when stdio is redirected to another pty. > >>>>>> > >>>>>> Revise the patch to fit the current git head. > >>>>> > >>>>> Revise the patch again to fit the current git head. > >>>> > >>>> Make app, which reads stdin, work under gdb. > >>> > >>> * Prevent ResizePseudoConsole() calls unless the pty is resized. > >>> * Revise the patch to fit the current git head. > >> > >> Revise the patch to fit the current git head. > > > > are you satisfied with the code? If you want to merge it, > > I'd bump Cygwin to 3.2. > > FWIW, I just installed this patch locally and am seeing noticeable speed > improvements. For example, here's the result of running 'make -j13 check' in > the info subdirectory of the texinfo source directory. [I chose this test > because it uses both FIFOs and ptys.] > > Without the patch: > > $ time make -j13 check > [...] > real 0m20.705s > user 0m18.639s > sys 0m40.187s > > With the patch: > > $ time make -j13 check > [...] > real 0m9.332s > user 0m14.153s > sys 0m30.235s This is the advantage 1) in my first post. Advantage: 1) No performance degradation in pty output for cygwin process. https://sourceware.org/pipermail/cygwin/2020-February/243651.html -- Takashi Yano