From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from conssluserg-02.nifty.com (conssluserg-02.nifty.com [210.131.2.81]) by sourceware.org (Postfix) with ESMTPS id 8D9E7384406D for ; Tue, 21 Jul 2020 18:18:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8D9E7384406D Received: from Express5800-S70 (v038192.dynamic.ppp.asahi-net.or.jp [124.155.38.192]) (authenticated) by conssluserg-02.nifty.com with ESMTP id 06LIHl3G004857 for ; Wed, 22 Jul 2020 03:17:47 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-02.nifty.com 06LIHl3G004857 X-Nifty-SrcIP: [124.155.38.192] Date: Wed, 22 Jul 2020 03:17:51 +0900 From: Takashi Yano To: cygwin-developers@cygwin.com Subject: Re: New implementation of pseudo console support (experimental) Message-Id: <20200722031751.e02bf24a7519b43d80e5db71@nifty.ne.jp> In-Reply-To: <20200720080613.GE16360@calimero.vinschen.de> References: <20200514183420.c246647a6d9e396d42c6b47e@nifty.ne.jp> <20200516092956.74369d694d611b1dcd095607@nifty.ne.jp> <20200516164735.2a2ef183788b151e9185ef41@nifty.ne.jp> <20200519224018.746f6324badd8a5762df42b1@nifty.ne.jp> <20200525195332.cf60ab2f38d167a76513740e@nifty.ne.jp> <20200526100955.30b1a2baea517e0565f30db6@nifty.ne.jp> <20200529004024.0c2ac3c68b588bda987e0837@nifty.ne.jp> <20200701204751.27609a8f5701010468521a87@nifty.ne.jp> <20200717111912.GG3784@calimero.vinschen.de> <20200718143024.45920213c7aa81912939d944@nifty.ne.jp> <20200720080613.GE16360@calimero.vinschen.de> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jul 2020 18:18:23 -0000 Hi Corinna, On Mon, 20 Jul 2020 10:06:13 +0200 Corinna Vinschen wrote: > On Jul 18 14:30, Takashi Yano via Cygwin-developers wrote: > > Hi Corinna, > > > > On Fri, 17 Jul 2020 13:19:12 +0200 > > Corinna Vinschen wrote: > > > Hi Takashi, > > > > > > On Jul 1 20:47, Takashi Yano via Cygwin-developers wrote: > > > > [...] > > > > Revise the patch to fit the current git head. > > > > > > are you satisfied with the code? If you want to merge it, > > > I'd bump Cygwin to 3.2. > > > > Since this new implementation has both advantages and disadvantages, > > there might be some options. > > > > 1) Default to new implementation and leave the current one as an > > alternative. Switch them using the environment CYGWIN. > > 2) Default to current implementation and add the new one as an > > alternative. Switch them using the environment CYGWIN. > > 3) Adopt only new implementation and throw the current one away. > > > > What do you think? > > Do you really want to maintain twice as much code doing the same stuff > and constantly having to ask users which version of the code they are > running? The maintenance cost outweighs the advantages, IMHO. > Personally I'd go for option 3. Personally, I feel a tinge of sadness to discard the current code, however, your opinion sounds reasonable. I will submit a new patch in which all the codes specific to the current implementation are removed. -- Takashi Yano