From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.187]) by sourceware.org (Postfix) with ESMTPS id E81AF382E04F for ; Wed, 22 Jul 2020 11:49:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E81AF382E04F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=cygwin.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=corinna-cygwin@cygwin.com Received: from calimero.vinschen.de ([217.91.18.234]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MXH3e-1kJiO12OTe-00Yivb for ; Wed, 22 Jul 2020 13:49:43 +0200 Received: by calimero.vinschen.de (Postfix, from userid 500) id 04BC6A81007; Wed, 22 Jul 2020 13:49:43 +0200 (CEST) Date: Wed, 22 Jul 2020 13:49:42 +0200 From: Corinna Vinschen To: cygwin-developers@cygwin.com Subject: Re: New implementation of pseudo console support (experimental) Message-ID: <20200722114942.GU16360@calimero.vinschen.de> Reply-To: cygwin-developers@cygwin.com Mail-Followup-To: cygwin-developers@cygwin.com References: <20200519224018.746f6324badd8a5762df42b1@nifty.ne.jp> <20200525195332.cf60ab2f38d167a76513740e@nifty.ne.jp> <20200526100955.30b1a2baea517e0565f30db6@nifty.ne.jp> <20200529004024.0c2ac3c68b588bda987e0837@nifty.ne.jp> <20200701204751.27609a8f5701010468521a87@nifty.ne.jp> <20200717111912.GG3784@calimero.vinschen.de> <20200718143024.45920213c7aa81912939d944@nifty.ne.jp> <20200720080613.GE16360@calimero.vinschen.de> <20200722031751.e02bf24a7519b43d80e5db71@nifty.ne.jp> <20200722174541.c8113635236fd217cb9ebb77@nifty.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200722174541.c8113635236fd217cb9ebb77@nifty.ne.jp> X-Provags-ID: V03:K1:J+ksSwNUiEaRG+2ZiElaz7NaTQqNXBQKpG6HrNiYTH4pjYAMcpv hmmTDVDmq8X+9ho2wXt5hhFOmmP1Hbejmjkxwn1nLeP6QtDoBoD3IbGlXJnkuI6mW0Y8E4L oejmDyMj8NH1WKNPX/qxTDroZ/3ZCXp7ZyJLIkd4OiTqeXNTiUBW7W1ryELYcp/iRgtZ6vv E3ZaA0twveKM7WlB1yD/g== X-UI-Out-Filterresults: notjunk:1;V03:K0:J7xPIzJFBSQ=:WZgreM5aVuOqTzd7xpgmhp CVgb6gf3EBPp5xBp+F96lFeU4rddS9HIjKOdaWjGHSwuKVRXsd+edjebX0i/cDU/dD5sotsGi QtKecBZSYBiCGI9w24EHns1gPnJXQlJciCrdwwRxTpw+S0uiwALDh4idqKLAOsaTvc2pW9H0K f7Zpr9dgqa9v2Q0l5/oV57KyRPjrAsG3S0VsWyV1mRzJ4Rgd1abFl4jndULSeAy/GbJKOWPsH +ID6io2/kIUSAIju2C6tzBbaEoomfcPu/RL4pwcu+8d4CeXPKn4IQzyIWqgxXTHdJgJyfPIXc 3fzOekh4vasHt/IdiP4z9f2jBr18qHy++8GvBmUagJ4eSF3uYL+hFN0mpCg8XsBI5sAsW6OHQ 0eT1/pGH2w/RxW+1CiPo1iAYZ0e+OQkX4D3bRwvqlXDGF5BBCFrsniC15HIPD5HQaj9F6duFq 8nKUXgTLDHKCGREG0j5JrG09tZrHl8XGXTFeFb/k8QuwCSJ2Gjrtts3j+uCm/nYgOXKSbEx/+ d4iT8qp82Nsfe+KIqFRfMVrfJEOz6keBadQLZB4Hqw8c0QCzwAOTY3N48BQLzlsc7wXg9vmMR W5feSBguv/1rjSTMFqUFFP3xhWsd25KYpXTP58C3PQGXODL25VsREkgbn6xAZf7IAIV/HrfNL Ii0vpjybA+F81Yv3MqwMoCqWNSRDGNDU/Y34wd7ssaCBn4OfLMiwyTh8lxRekC29v38b2ywcM 1weRu7ZYwImCcHNLu6SjMPqiia5A0gQuLg0/kdQtot6d+fY6qb7iW2ImeFKgqo7k//6PJFwJd e5XvzNJ3zIzw+HabJA1eCtZ2NSg1Oh9YQNVM8xMnaUrH1eH3MEhLLxiKxE49URmVULeCvC10F Och3BplWI/nPrCQHhPbg== X-Spam-Status: No, score=-99.6 required=5.0 tests=BAYES_00, GOOD_FROM_CORINNA_CYGWIN, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jul 2020 11:49:47 -0000 On Jul 22 17:45, Takashi Yano via Cygwin-developers wrote: > On Wed, 22 Jul 2020 03:17:51 +0900 > Takashi Yano via Cygwin-developers wrote: > > Hi Corinna, > > > > On Mon, 20 Jul 2020 10:06:13 +0200 > > Corinna Vinschen wrote: > > > On Jul 18 14:30, Takashi Yano via Cygwin-developers wrote: > > > > Hi Corinna, > > > > > > > > On Fri, 17 Jul 2020 13:19:12 +0200 > > > > Corinna Vinschen wrote: > > > > > Hi Takashi, > > > > > > > > > > On Jul 1 20:47, Takashi Yano via Cygwin-developers wrote: > > > > > > [...] > > > > > > Revise the patch to fit the current git head. > > > > > > > > > > are you satisfied with the code? If you want to merge it, > > > > > I'd bump Cygwin to 3.2. > > > > > > > > Since this new implementation has both advantages and disadvantages, > > > > there might be some options. > > > > > > > > 1) Default to new implementation and leave the current one as an > > > > alternative. Switch them using the environment CYGWIN. > > > > 2) Default to current implementation and add the new one as an > > > > alternative. Switch them using the environment CYGWIN. > > > > 3) Adopt only new implementation and throw the current one away. > > > > > > > > What do you think? > > > > > > Do you really want to maintain twice as much code doing the same stuff > > > and constantly having to ask users which version of the code they are > > > running? The maintenance cost outweighs the advantages, IMHO. > > > Personally I'd go for option 3. > > > > Personally, I feel a tinge of sadness to discard the current code, > > however, your opinion sounds reasonable. > > > > I will submit a new patch in which all the codes specific to the > > current implementation are removed. > > Attached is the patch in git format-patch format. > All the codes specific to the current implementation are removed. > > Despite the utmost care, the changes are relatively large, so some > degradation may exist. > > I will appreciate if you could test. I built a new DLL with this patch and this looks pretty good to me so far. I'm a bad tester for this stuff, though, using just basic Cygwin tools usually. At one point we should probably just apply this patch and create developer snapshots to broaden the tester base, but for now, maybe I should upload my test DLL somewhere? Is anybody besides Thomas willing to test this new pseudo console stuff? Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer