From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.133]) by sourceware.org (Postfix) with ESMTPS id 7A8423850405 for ; Sun, 2 Aug 2020 12:01:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7A8423850405 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=cygwin.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=corinna-cygwin@cygwin.com Received: from calimero.vinschen.de ([217.91.18.234]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.167]) with ESMTPSA (Nemesis) id 1N2Ujn-1kkuqd2sTX-013t1O; Sun, 02 Aug 2020 14:01:04 +0200 Received: by calimero.vinschen.de (Postfix, from userid 500) id 1B59CA80D89; Sun, 2 Aug 2020 14:01:04 +0200 (CEST) Date: Sun, 2 Aug 2020 14:01:04 +0200 From: Corinna Vinschen To: Takashi Yano Cc: cygwin-developers@cygwin.com Subject: Re: New implementation of pseudo console support (experimental) Message-ID: <20200802120104.GD460314@calimero.vinschen.de> Reply-To: cygwin-developers@cygwin.com Mail-Followup-To: Takashi Yano , cygwin-developers@cygwin.com References: <20200529004024.0c2ac3c68b588bda987e0837@nifty.ne.jp> <20200701204751.27609a8f5701010468521a87@nifty.ne.jp> <20200717111912.GG3784@calimero.vinschen.de> <20200718143024.45920213c7aa81912939d944@nifty.ne.jp> <20200720080613.GE16360@calimero.vinschen.de> <20200722031751.e02bf24a7519b43d80e5db71@nifty.ne.jp> <20200722174541.c8113635236fd217cb9ebb77@nifty.ne.jp> <20200723093328.709654ea6a539cb9b3251ab2@nifty.ne.jp> <20200724143842.020cea9ffa2f6e7ffe760f67@nifty.ne.jp> <20200724202219.16ad238f515da19db21d3a6c@nifty.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200724202219.16ad238f515da19db21d3a6c@nifty.ne.jp> X-Provags-ID: V03:K1:WjIAUnRFMikonvjZIcScvNFJMwpBNXhdiD2bffe3rnEvebs/T5I TZlXY4k5RAia3Jag9pit8ThdT01xTa8sqgEg6Wl84xHvecdka8hZ6GVTZDWX3s/f4FuYWMe k8buagSOcS/gKSG7vXmJ8/Zatb69TfbgIlnrnowu4fWAoeZMMqDqWYKLDLODqCPBQ69ITRN RbkoiuYuhVzleR7brKPsg== X-UI-Out-Filterresults: notjunk:1;V03:K0:n32mhCEDck8=:kI4Nd3CIE3g462Qj6NdCeU g5tsID4siFHdk1P6+p00sQQjjicNP7hrOg7YB5sRhIJAVMpj4rcvau7Wgjp3+t+pzjGfulb4w Ob843UCs5mmt5h1y2WRFCqtk1EtUgdqqIoEhAq9ahrSQd7II0MGX0+3WR5kcb56CE5CAaFj6R JEcicHoCqDEfNNhTG7YDiOF4MVChEpeT1FFjDjVPwDYrc0mZDmLV9y26qBK+Pk+oO0vSHnbk0 pLCketRRd/hQEYr7M8uUxEQqsq1siBKCmPNgie9mniVSK3eRDIUxa+LMnGS1y2Rw4omCOXcYG snMye2NCXvMlFx8muWAtLs6c/9HgMBExCsN/yWp2n5S4DdCFsXUPc0VKTC6Ymb9avH1PTE3BO xEafvj616HIARr5qWy9Zf0MMyVbf7rhXS6TL9W+sK8VZFKsp06OIMycBq0tos1QvPBiz7qr81 VUGvVKV+wMUrvGeIMlkvGa1k6UBVu+K2r4KsDhc6U0ljH81EtRHg+65K4WKF/qkspJaBZZHF1 L1c+bNzeA0noDngjpDa8XeGD1UVv8wCfJIyknczCtBIPi6KP0wWJwCGvc/3WWXEedekC3S7N8 e9xIj61KEaJbPT/hvSLizRMaNg64X1vm2rQcIMjMi1O20ph29H+yVQ2odjRh1IOBE+TAloBZ+ 806ryxHke0uEGpEGFewztuUDgdxcIEyxLh5fG/hzdjIQTJs6jo8/zMdq5AV46tNNXdMzrksvH mKraFQOMOLjGyw7ekCH09X6yKTzBk4IWqR3h83H+Tw3Yf2jcoAIirFzVRRfqDeUWWv42EFDX7 /9T/DJbVg8xMgJPi/j1bGQjLyI4zG2iD1tSDWY7/KVxLLJeo1XAvYG+mPIkabsqahxnMtyM3f fnSGeI877GNCro+UXRZA== X-Spam-Status: No, score=-99.6 required=5.0 tests=BAYES_00, GOOD_FROM_CORINNA_CYGWIN, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Aug 2020 12:01:11 -0000 Hi Takashi, On Jul 24 20:22, Takashi Yano via Cygwin-developers wrote: > On Fri, 24 Jul 2020 14:38:42 +0900 > Takashi Yano via Cygwin-developers wrote: > > On Thu, 23 Jul 2020 09:33:28 +0900 > > Takashi Yano via Cygwin-developers wrote: > > > On Wed, 22 Jul 2020 17:45:41 +0900 > > > Takashi Yano via Cygwin-developers wrote: > > > > > [...] > > > > Attached is the patch in git format-patch format. > > > > All the codes specific to the current implementation are removed. > > > > > > > > Despite the utmost care, the changes are relatively large, so some > > > > degradation may exist. > > > > > > > > I will appreciate if you could test. > > > > > > There were still unused code. Please try attached patch instead. > > > > Changes: > > * Do not activate pseudo console if it is already activated for > > another process on same pty. > > Changes: > * Fix a bug in the latest change. > > -- > Takashi Yano While hacking on the posix_spawn thingy, I noticed this hunk of yours: @@ -897,6 +910,11 @@ child_info_spawn::worker (const char *prog_arg, const char *const *argv, && WaitForSingleObject (pi.hProcess, 0) == WAIT_TIMEOUT) wait_for_myself (); } + if (enable_pcon) + { + WaitForSingleObject (pi.hProcess, INFINITE); + ptys_primary->close_pseudoconsole (); + } myself.exit (EXITCODE_NOSET); break; case _P_WAIT: Wait... what? So the exec'ing process hangs infinitely if the exec'ed process runs infinitely? Doesn't that have weird side effects by any chance? Thanks, Corinna