From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <corinna-cygwin@cygwin.com>
Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.131])
 by sourceware.org (Postfix) with ESMTPS id A6DCF3857C62
 for <cygwin-developers@cygwin.com>; Wed,  5 Aug 2020 20:52:56 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A6DCF3857C62
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=cygwin.com
Authentication-Results: sourceware.org;
 spf=fail smtp.mailfrom=corinna-cygwin@cygwin.com
Received: from calimero.vinschen.de ([217.91.18.234]) by
 mrelayeu.kundenserver.de (mreue010 [212.227.15.167]) with ESMTPSA (Nemesis)
 id 1N4yqC-1kml7K4BBk-010vpt for <cygwin-developers@cygwin.com>; Wed, 05 Aug
 2020 22:52:55 +0200
Received: by calimero.vinschen.de (Postfix, from userid 500)
 id 7BEC7A80A4D; Wed,  5 Aug 2020 22:52:54 +0200 (CEST)
Date: Wed, 5 Aug 2020 22:52:54 +0200
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-developers@cygwin.com
Subject: switch fallthrough change
Message-ID: <20200805205254.GG1107715@calimero.vinschen.de>
Reply-To: cygwin-developers@cygwin.com
Mail-Followup-To: cygwin-developers@cygwin.com
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
X-Provags-ID: V03:K1:TWJL3usUT9N29yxuBVne0BuKYeTG0ceGT8tIo+6KAY8QL0GwQT5
 H0QTL/bLFiP25YJteLtOl0Ic1LD2rlQuZiROyopdPGaFWqzg3RXA8Do87vAnMo101LAaqRi
 PRdN2Oj2JfiQnQEBCb5RU4601swmoZsDsRdisd2sgjBR2A0unuIVE+Qkb9cFB+y308GYFYV
 mYSH6yTbtAH4ZcNIm/v3w==
X-UI-Out-Filterresults: notjunk:1;V03:K0:p5SAie0Zuec=:keYiTIZmfp0lhudviS8OYu
 tS8Fwh4NrxN6vYXzvgfzIurzh+MGdqIDqtjXORs/rAi/0NGuXPqsSEJdRPhyFBk5i5d7xX5fh
 SLQsorcmJy/pwMyKstN9tdphVpCwKW19VNiV7bpXlxSX2W6VaTtYb0O2UejvaMWtttKRpUb0m
 ZJTCXpCQfnv7ALHKSe23RQIhsVOiRyMibubmv2fN70fYDXklFKW5ni5ZI1d06MDeO2oOhixdp
 7tAh6rvne60vjnXuY+EqFjkMj+RFW8oTDRxzYwy5fHjOL2VCCraQ9Rba5yKNcr4xonnQ5UEzs
 eU6SiooJ5uKLvGZVxIkjYCkZZ4ZjYhCF1PboAaLoBCwDJO1Ect8+6PFwIb+UUBy6RYGahK4/k
 rSTaw/ZhvkHKbIZ+EgO9itROuUk15BbbjA7+lqvZH9VFBUA5bqscjvG7zbbJ5z1jlur7zkn40
 +9PKYpgS5vtYrPrhvb4Y4eSRep0kge6Jy3qINeKaq1ncqqEP4bx/rxiwAtIaYeKMieBpsrsu1
 OBi807n6QAtinDi3tQ3RTBieqaISHqF5pi192nEioHmXJLUj9gQjXJSOrPsXcu1M+IJFMub6S
 PgMHlAaVU7TRe5gKiQiO0HJxVjBoWxC8bMJ4846AK3rvOKAryWulSApemVgx0PFj6hmkjm/+u
 6XFxJmmHe0mvre1C8cYsH7CTByixwJ8It6yZfDy5U/gWwCfor9DujDOc3ukxctJ9q/kblKPKy
 DRGc4aAiFEj1Xk7FqV/Z9ZBcqG6fw4ww2YJ3m7VadXkZo1/iT+VW44YWFMu6bQGn3zCT+7lcI
 Tn3rqPywaUjvNjAQxNug33XX9N+ul/7iGtwsFoiFdnxkrsCni8tM8x81oZAVfmbw5R9eKavwk
 UK64vhsFtwiFk9wI8uhw==
X-Spam-Status: No, score=-100.0 required=5.0 tests=BAYES_00,
 GOOD_FROM_CORINNA_CYGWIN, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE,
 RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: cygwin-developers@cygwin.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Cygwin core component developers mailing list
 <cygwin-developers.cygwin.com>
List-Unsubscribe: <https://cygwin.com/mailman/options/cygwin-developers>,
 <mailto:cygwin-developers-request@cygwin.com?subject=unsubscribe>
List-Archive: <https://cygwin.com/pipermail/cygwin-developers/>
List-Post: <mailto:cygwin-developers@cygwin.com>
List-Help: <mailto:cygwin-developers-request@cygwin.com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin-developers>,
 <mailto:cygwin-developers-request@cygwin.com?subject=subscribe>
X-List-Received-Date: Wed, 05 Aug 2020 20:52:58 -0000

Hi folks,

Just a small headsup here.

I introduced a change already in the Linux kernel for a couple of
months.  Rather than various comments /*FALLTHRU*/, /* fall through */,
etc., Cygwin is using a statement

  fallthrough;

at the end of a switch case intentionally falling through to the
next case branch.  This is using a GCC attribute under the hood,
__attribute__ ((__fallthrough__)) introduced with GCC 7.1.

The advantage is a better control of the way a switch case ends.
It now *has* to end with either one of

  break;
  fallthrough;
  goto <label>;
  return [expression];
  continue;

otherwise GCC complains.  For this I added -Wimplicit-fallthrough=5 to
our build flags.  Just by checking our switch statements I found a
couple of missing break statements as well as one or two missing
intentional fallthrough comments.

For now this only affects the cygwin dir, not the utils or cygserver
dirs, lacking a common header file for this purpose.  Patches welcome.


Corinna