From: Takashi Yano <takashi.yano@nifty.ne.jp>
To: cygwin-developers@cygwin.com
Subject: Re: New implementation of pseudo console support (experimental)
Date: Tue, 1 Sep 2020 18:42:15 +0900 [thread overview]
Message-ID: <20200901184215.e4764181c4c86ec12b90c314@nifty.ne.jp> (raw)
In-Reply-To: <20200901182303.76c0ab7a52553910b540f2bc@nifty.ne.jp>
Hi Johannes,
On Tue, 1 Sep 2020 18:23:03 +0900
Takashi Yano via Cygwin-developers <cygwin-developers@cygwin.com> wrote:
> On Tue, 1 Sep 2020 06:46:53 +0200 (CEST)
> Johannes Schindelin wrote:
>
> > -- snip --
> > diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
> > index 43eebc174..65b4d45fa 100644
> > --- a/winsup/cygwin/fhandler_tty.cc
> > +++ b/winsup/cygwin/fhandler_tty.cc
> > @@ -2867,7 +2867,16 @@ fhandler_pty_slave::setup_locale (void)
> > char charset[ENCODING_LEN + 1] = "ASCII";
> > LCID lcid = get_langinfo (locale, charset);
> >
> > - /* Set console code page form locale */
> > + /* Special-case the UTF-8 character set */
> > + if (strcasecmp (charset, "UTF-8") == 0)
> > + {
> > + get_ttyp ()->term_code_page = CP_UTF8;
> > + SetConsoleCP (CP_UTF8);
> > + SetConsoleOutputCP (CP_UTF8);
> > + return;
> > + }
> > +
> > + /* Set console code page from locale */
> > if (get_pseudo_console ())
> > {
> > UINT code_page;
> > -- snap --
>
> I don't think you do right thing. Your first test case makes
> garbled output in command prompt, therefore output in cygwin
> should be the same.
>
> I believe the correct maner as Windows programs are such as:
>
> [Code A]
> #include <windows.h>
> #include <stdio.h>
>
> int main(){
> int origcp = GetConsoleOutputCP();
> SetConsoleOutputCP(CP_UTF8);
> puts("Привет мир! Hello world!");
> SetConsoleOutputCP(origcp);
> return 0;
> }
>
> [Code B]
> #include <locale.h>
> #include <stdio.h>
>
> int main(){
> setlocale (LC_ALL, "");
> _putws(L"Привет мир! Hello world!");
> return 0;
> }
>
> if the source code is in UTF-8 coding. Or compiled
> with -fexec-charset=utf-8.
>
> Both work as expected in command prompt as well as
> in current cygwin.
What is your expectation if your test case is compiled
with -fexec-charset=cp1251?
This will cause garbled output if your default code page
is not 1251.
In this case, SetConsoleOutputCP(1251) is necessary.
Why do you think only the UTF-8 output should work without
SetConsoleOutputCP(CP_UTF8)?
--
Takashi Yano <takashi.yano@nifty.ne.jp>
next prev parent reply other threads:[~2020-09-01 9:42 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 12:16 Takashi Yano
2020-05-13 12:35 ` Thomas Wolff
2020-05-14 9:28 ` Takashi Yano
2020-05-14 9:34 ` Takashi Yano
2020-05-16 0:29 ` Takashi Yano
2020-05-16 7:47 ` Takashi Yano
2020-05-19 13:40 ` Takashi Yano
2020-05-25 10:53 ` Takashi Yano
2020-05-25 15:22 ` Corinna Vinschen
2020-05-25 19:16 ` Thomas Wolff
2020-05-26 1:00 ` Takashi Yano
2020-05-26 7:14 ` Thomas Wolff
2020-05-26 9:21 ` Takashi Yano
2020-05-26 9:32 ` Thomas Wolff
2020-05-26 8:33 ` Corinna Vinschen
2020-05-26 1:09 ` Takashi Yano
2020-05-28 15:40 ` Takashi Yano
2020-05-29 15:30 ` Corinna Vinschen
2020-05-30 7:36 ` Takashi Yano
2020-05-30 13:14 ` Takashi Yano
2020-05-30 17:43 ` Corinna Vinschen
2020-05-31 5:52 ` Takashi Yano
2020-07-01 11:47 ` Takashi Yano
2020-07-17 11:19 ` Corinna Vinschen
2020-07-17 12:47 ` Thomas Wolff
2020-07-17 14:59 ` Thomas Wolff
2020-07-18 5:05 ` Takashi Yano
2020-07-18 20:57 ` Thomas Wolff
2020-07-23 17:17 ` Takashi Yano
2020-07-27 17:10 ` Thomas Wolff
2020-07-17 12:52 ` Ken Brown
2020-07-18 5:07 ` Takashi Yano
2020-07-18 5:30 ` Takashi Yano
2020-07-20 8:06 ` Corinna Vinschen
2020-07-21 18:17 ` Takashi Yano
2020-07-22 8:45 ` Takashi Yano
2020-07-22 11:49 ` Corinna Vinschen
2020-07-22 12:13 ` Ken Brown
2020-07-23 0:33 ` Takashi Yano
2020-07-24 5:38 ` Takashi Yano
2020-07-24 11:22 ` Takashi Yano
2020-08-02 12:01 ` Corinna Vinschen
2020-08-03 2:05 ` Takashi Yano
2020-08-03 10:50 ` Corinna Vinschen
2020-08-03 2:11 ` Takashi Yano
2020-08-03 12:23 ` Takashi Yano
2020-08-11 11:12 ` Takashi Yano
2020-08-13 9:58 ` Takashi Yano
2020-08-17 11:57 ` Takashi Yano
2020-08-19 11:39 ` Takashi Yano
2020-08-19 13:41 ` Corinna Vinschen
2020-08-19 15:43 ` Thomas Wolff
2020-08-19 20:47 ` Mark Geisert
2020-08-20 8:02 ` Takashi Yano
2020-08-31 12:49 ` Johannes Schindelin
2020-08-31 14:14 ` Takashi Yano
[not found] ` <20200831231253.332c66fdddb33ceed5f61db6@nifty.ne.jp>
2020-08-31 14:22 ` Johannes Schindelin
2020-08-31 14:53 ` Takashi Yano
2020-08-31 15:56 ` Johannes Schindelin
2020-08-31 16:12 ` Thomas Wolff
2020-08-31 17:39 ` Thomas Wolff
2020-08-31 19:17 ` Johannes Schindelin
2020-08-31 19:37 ` Corinna Vinschen
2020-09-01 4:46 ` Johannes Schindelin
2020-09-01 9:23 ` Takashi Yano
2020-09-01 6:32 ` Johannes Schindelin
2020-09-01 22:33 ` Takashi Yano
2020-09-02 6:13 ` Johannes Schindelin
2020-09-01 9:42 ` Takashi Yano [this message]
2020-08-31 21:07 ` Thomas Wolff
2020-08-31 23:23 ` Takashi Yano
2020-09-01 5:00 ` Johannes Schindelin
2020-09-01 8:56 ` Thomas Wolff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200901184215.e4764181c4c86ec12b90c314@nifty.ne.jp \
--to=takashi.yano@nifty.ne.jp \
--cc=cygwin-developers@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).