From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from conssluserg-05.nifty.com (conssluserg-05.nifty.com [210.131.2.90]) by sourceware.org (Postfix) with ESMTPS id 4EAEA385840F for ; Fri, 3 Sep 2021 10:14:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4EAEA385840F Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=nifty.ne.jp Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=nifty.ne.jp Received: from Express5800-S70 (z221123.dynamic.ppp.asahi-net.or.jp [110.4.221.123]) (authenticated) by conssluserg-05.nifty.com with ESMTP id 183ADeYP027839 for ; Fri, 3 Sep 2021 19:13:40 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-05.nifty.com 183ADeYP027839 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.ne.jp; s=dec2015msa; t=1630664020; bh=iDTkP9Qggw/am74QcjfsydO1LorYm+3/PlycbKqNrV8=; h=Date:From:To:Subject:In-Reply-To:References:From; b=VmGsx84vsRgxI0+8jQLmuCrNtOEzDAUP5h5khzf17bIh9FHSkdKl6ixazMrqq/0aX jyYoWscnxGOpQL4XIx5M17ZoWxJWds8bZFFXFkFjVa2KvENpep5OLaJSv0IurxdTdS TAlvipWIDlJn8heMgbKTpV0TwFgWHHiJUzWH+hFHC17/PDqnG8ukon6Ak7Bo+s49Mc qXNbdAlCgcOkq+QBlSHZmmuqj3+2Vw2wDPAqmZQXuCwJn5AgqbprXfqYTQngLZC8cB iCopw95dezG4WpdYWuD0QZbRdGivVK32FywuEPQJCY41c05i8kLQs7JXKwomfl8gNZ ne2+hTEwnROYw== X-Nifty-SrcIP: [110.4.221.123] Date: Fri, 3 Sep 2021 19:13:40 +0900 From: Takashi Yano To: cygwin-developers@cygwin.com Subject: Re: cygrunsrv + sshd + rsync = 20 times too slow -- throttled? Message-Id: <20210903191340.c28ae366e79ca14799bacc1f@nifty.ne.jp> In-Reply-To: <20210903190046.663c60fb11c936e344821383@nifty.ne.jp> References: <20210901091652.6bf3cccbcaed4a22f6ffa6b0@nifty.ne.jp> <20210901172339.1039604b7067e0492534a20f@nifty.ne.jp> <24138e20-aa97-cfea-bf48-198fc67755ea@cornell.edu> <9ba687eb-f4a0-18f8-b10b-76e7e51e123e@cornell.edu> <152bfc0c-2f72-c684-6fc5-aa7c36c136b8@cornell.edu> <20210903190046.663c60fb11c936e344821383@nifty.ne.jp> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Multipart=_Fri__3_Sep_2021_19_13_40_+0900_PeQXrR6W4dGHw49O" X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Sep 2021 10:14:05 -0000 This is a multi-part message in MIME format. --Multipart=_Fri__3_Sep_2021_19_13_40_+0900_PeQXrR6W4dGHw49O Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 3 Sep 2021 19:00:46 +0900 Takashi Yano wrote: > On Thu, 2 Sep 2021 21:35:21 +0200 > Corinna Vinschen wrote: > > On Sep 2 21:00, Corinna Vinschen wrote: > > > On Sep 2 09:01, Ken Brown wrote: > > > > On 9/2/2021 4:17 AM, Corinna Vinschen wrote: > > > > > What if the readers never request more than, say, 50 or even 25% of the > > > > > available buffer space? Our buffer is 64K and there's no guarantee that > > > > > any read > PIPE_BUF (== 4K) is atomic anyway. This can work without > > > > > having to check the other side of the pipe. Something like this, > > > > > ignoring border cases: > > > > > > > > > > pipe::create() > > > > > { > > > > > [...] > > > > > mutex = CreateMutex(); > > > > > } > > > > > > > > > > pipe::raw_read(char *buf, size_t num_requested) > > > > > { > > > > > if (blocking) > > > > > { > > > > > WFSO(mutex); > > > > > NtQueryInformationFile(FilePipeLocalInformation); > > > > > if (!fpli.ReadDataAvailable > > > > > && num_requested > fpli.InboundQuota / 4) > > > > > num_requested = fpli.InboundQuota / 4; > > > > > NtReadFile(pipe, buf, num_requested); > > > > > ReleaseMutex(mutex); > > > > > } > > > > > } > > > > > > > > > > It's not entirely foolproof, but it should fix 99% of the cases. > > > > > > > > I like it! > > > > > > > > Do you think there's anything we can or should do to avoid a deadlock in the > > > > rare cases where this fails? The only thing I can think of immediately is > > > > to always impose a timeout if select is called with infinite timeout on the > > > > write side of a pipe, after which we report that the pipe is write ready. > > > > After all, we've lived since 2008 with a bug that caused select to *always* > > > > report write ready. > > > > > > Indeed. Hmm. What timeout are you thinking of? Seconds? Minutes? > > > > > > > Alternatively, we could just wait and see if there's an actual use case in > > > > which someone encounters a deadlock. > > > > > > Or that. Fixing up select isn't too hard in that case, I guess. > > > > It's getting too late again. I drop off for tonight, but I attached > > my POC code I have so far. It also adds the snippets from my previous > > patch which fixes stuff Takashi found during testing. It also fixes > > something which looks like a bug in raw_write: > > > > - ptr = ((char *) ptr) + chunk; > > + ptr = ((char *) ptr) + nbytes_now; > > > > Incrementing ptr by chunk bytes while only nbytes_now have been written > > looks incorrect. > > > > As for the reader, it makes the # of bytes to read dependent on the > > number of reader handles. I don't know if that's such a bright idea, > > but this can be changed easily. > > > > Anyway, this runs all my testcases successfully but they are anything > > but thorough. > > > > Patch relativ to topic/pipe attached. Would you both mind to take a > > scrutinizing look? > > Thanks. > > Your code seems that read() returns only the partial data even > if the pipe stil has more data. Is this by design? > > This happes in both blocking and non-blocking case. The patch attached seems to fix the issue. -- Takashi Yano --Multipart=_Fri__3_Sep_2021_19_13_40_+0900_PeQXrR6W4dGHw49O Content-Type: application/octet-stream; name="pipe-corinna4-fix.patch" Content-Disposition: attachment; filename="pipe-corinna4-fix.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL3dpbnN1cC9jeWd3aW4vZmhhbmRsZXJfcGlwZS5jYyBiL3dpbnN1cC9jeWd3 aW4vZmhhbmRsZXJfcGlwZS5jYwppbmRleCA3YTVjZWZiM2QuLjViNmI5ODg5MiAxMDA2NDQKLS0t IGEvd2luc3VwL2N5Z3dpbi9maGFuZGxlcl9waXBlLmNjCisrKyBiL3dpbnN1cC9jeWd3aW4vZmhh bmRsZXJfcGlwZS5jYwpAQCAtMjIyLDYgKzIyMiw3IEBAIGZoYW5kbGVyX3BpcGU6OnJhd19yZWFk ICh2b2lkICpwdHIsIHNpemVfdCYgbGVuKQogICBEV09SRCB3YWl0cmV0ID0gV0FJVF9PQkpFQ1Rf MDsKICAgYm9vbCBrZWVwX2xvb3BpbmcgPSBmYWxzZTsKICAgc2l6ZV90IG9yaWdfbGVuID0gbGVu OworICBzaXplX3QgdG90YWxfbGVuID0gMDsKIAogICBpZiAoIWxlbikKICAgICByZXR1cm47CkBA IC0yMzYsMjkgKzIzNywzNyBAQCBmaGFuZGxlcl9waXBlOjpyYXdfcmVhZCAodm9pZCAqcHRyLCBz aXplX3QmIGxlbikKIAogICBkbwogICAgIHsKLSAgICAgIGxlbiA9IG9yaWdfbGVuOworICAgICAg Y2hhciAqcHRyMSA9IChjaGFyICopIHB0ciArIHRvdGFsX2xlbjsKKyAgICAgIGxlbiA9IG9yaWdf bGVuIC0gdG90YWxfbGVuOwogICAgICAga2VlcF9sb29waW5nID0gZmFsc2U7CiAgICAgICBpZiAo ZXZ0KQogCVJlc2V0RXZlbnQgKGV2dCk7Ci0gICAgICBpZiAoIWlzX25vbmJsb2NraW5nICgpKQor CisgICAgICBGSUxFX1BJUEVfTE9DQUxfSU5GT1JNQVRJT04gZnBsaTsKKyAgICAgIFVMT05HIHJl YWRlcl9jb3VudDsKKyAgICAgIFVMT05HIG1heF9sZW4gPSA2NDsKKworICAgICAgV2FpdEZvclNp bmdsZU9iamVjdCAocmVhZF9tdHgsIElORklOSVRFKTsKKworICAgICAgLyogTWFrZSBzdXJlIG5l dmVyIHRvIHJlcXVlc3QgbW9yZSBieXRlcyB0aGFuIGhhbGYgdGhlIHBpcGUKKwkgYnVmZmVyIHNp emUuICBFdmVyeSBwZW5kaW5nIHJlYWQgbG93ZXJzIFdyaXRlUXVvdGFBdmFpbGFibGUKKwkgb24g dGhlIHdyaXRlIHNpZGUgYW5kIHRodXMgYWZmZWN0cyBzZWxlY3QncyBhYmlsaXR5IHRvIHJldHVy bgorCSBtb3JlIG9yIGxlc3MgcmVsaWFibGUgaW5mbyB3aGV0aGVyIGEgd3JpdGUgc3VjY2VlZHMg b3Igbm90LgorCisJIExldCB0aGUgc2l6ZSBvZiB0aGUgcmVxdWVzdCBkZXBlbmQgb24gdGhlIG51 bWJlciBvZiByZWFkZXJzCisJIGF0IHRoZSB0aW1lLiAqLworICAgICAgc3RhdHVzID0gTnRRdWVy eUluZm9ybWF0aW9uRmlsZSAoZ2V0X2hhbmRsZSAoKSwgJmlvLAorCQkJCSAgICAgICAmZnBsaSwg c2l6ZW9mIChmcGxpKSwKKwkJCQkgICAgICAgRmlsZVBpcGVMb2NhbEluZm9ybWF0aW9uKTsKKyAg ICAgIGlmIChOVF9TVUNDRVNTIChzdGF0dXMpICYmIGZwbGkuUmVhZERhdGFBdmFpbGFibGUgPT0g MCkKIAl7Ci0JICBGSUxFX1BJUEVfTE9DQUxfSU5GT1JNQVRJT04gZnBsaTsKLQkgIFVMT05HIHJl YWRlcl9jb3VudDsKLQkgIFVMT05HIG1heF9sZW4gPSA2NDsKLQotCSAgV2FpdEZvclNpbmdsZU9i amVjdCAocmVhZF9tdHgsIElORklOSVRFKTsKLQotCSAgLyogTWFrZSBzdXJlIG5ldmVyIHRvIHJl cXVlc3QgbW9yZSBieXRlcyB0aGFuIGhhbGYgdGhlIHBpcGUKLQkgICAgIGJ1ZmZlciBzaXplLiAg RXZlcnkgcGVuZGluZyByZWFkIGxvd2VycyBXcml0ZVF1b3RhQXZhaWxhYmxlCi0JICAgICBvbiB0 aGUgd3JpdGUgc2lkZSBhbmQgdGh1cyBhZmZlY3RzIHNlbGVjdCdzIGFiaWxpdHkgdG8gcmV0dXJu Ci0JICAgICBtb3JlIG9yIGxlc3MgcmVsaWFibGUgaW5mbyB3aGV0aGVyIGEgd3JpdGUgc3VjY2Vl ZHMgb3Igbm90LgotCi0JICAgICBMZXQgdGhlIHNpemUgb2YgdGhlIHJlcXVlc3QgZGVwZW5kIG9u IHRoZSBudW1iZXIgb2YgcmVhZGVycwotCSAgICAgYXQgdGhlIHRpbWUuICovCi0JICBzdGF0dXMg PSBOdFF1ZXJ5SW5mb3JtYXRpb25GaWxlIChnZXRfaGFuZGxlICgpLCAmaW8sCi0JCQkJCSAgICZm cGxpLCBzaXplb2YgKGZwbGkpLAotCQkJCQkgICBGaWxlUGlwZUxvY2FsSW5mb3JtYXRpb24pOwot CSAgaWYgKE5UX1NVQ0NFU1MgKHN0YXR1cykgJiYgZnBsaS5SZWFkRGF0YUF2YWlsYWJsZSA9PSAw KQorCSAgaWYgKHRvdGFsX2xlbiAhPSAwKQorCSAgICB7CisJICAgICAgbGVuID0gdG90YWxfbGVu OworCSAgICAgIFJlbGVhc2VNdXRleCAocmVhZF9tdHgpOworCSAgICAgIGJyZWFrOworCSAgICB9 CisJICBpZiAoIWlzX25vbmJsb2NraW5nICgpKQogCSAgICB7CiAJICAgICAgcmVhZGVyX2NvdW50 ID0gZ2V0X29ial9oYW5kbGVfY291bnQgKGdldF9oYW5kbGUgKCkpOwogCSAgICAgIGlmIChyZWFk ZXJfY291bnQgPCAxMCkKQEAgLTI2NywxMCArMjc2LDExIEBAIGZoYW5kbGVyX3BpcGU6OnJhd19y ZWFkICh2b2lkICpwdHIsIHNpemVfdCYgbGVuKQogCQlsZW4gPSBtYXhfbGVuOwogCSAgICB9CiAJ fQotICAgICAgc3RhdHVzID0gTnRSZWFkRmlsZSAoZ2V0X2hhbmRsZSAoKSwgZXZ0LCBOVUxMLCBO VUxMLCAmaW8sIHB0ciwKKworICAgICAgc3RhdHVzID0gTnRSZWFkRmlsZSAoZ2V0X2hhbmRsZSAo KSwgZXZ0LCBOVUxMLCBOVUxMLCAmaW8sIHB0cjEsCiAJCQkgICBsZW4sIE5VTEwsIE5VTEwpOwot ICAgICAgaWYgKCFpc19ub25ibG9ja2luZyAoKSkKLQlSZWxlYXNlTXV0ZXggKHJlYWRfbXR4KTsK KyAgICAgIFJlbGVhc2VNdXRleCAocmVhZF9tdHgpOworCiAgICAgICBpZiAoZXZ0ICYmIHN0YXR1 cyA9PSBTVEFUVVNfUEVORElORykKIAl7CiAJICB3YWl0cmV0ID0gY3lnd2FpdCAoZXZ0KTsKQEAg LTI5MSw5ICszMDEsMTEgQEAgZmhhbmRsZXJfcGlwZTo6cmF3X3JlYWQgKHZvaWQgKnB0ciwgc2l6 ZV90JiBsZW4pCiAJfQogICAgICAgZWxzZSBpZiAoTlRfU1VDQ0VTUyAoc3RhdHVzKSkKIAl7Ci0J ICBsZW4gPSBpby5JbmZvcm1hdGlvbjsKLQkgIGlmIChsZW4gPT0gMCkKKwkgIHRvdGFsX2xlbiAr PSBpby5JbmZvcm1hdGlvbjsKKwkgIGlmICh0b3RhbF9sZW4gPCBvcmlnX2xlbikKIAkgICAga2Vl cF9sb29waW5nID0gdHJ1ZTsKKwkgIGVsc2UKKwkgICAgbGVuID0gdG90YWxfbGVuOwogCX0KICAg ICAgIGVsc2UKIAl7CkBAIC0zMDgsOSArMzIwLDExIEBAIGZoYW5kbGVyX3BpcGU6OnJhd19yZWFk ICh2b2lkICpwdHIsIHNpemVfdCYgbGVuKQogCSAgICBjYXNlIFNUQVRVU19NT1JFX0VOVFJJRVM6 CiAJICAgIGNhc2UgU1RBVFVTX0JVRkZFUl9PVkVSRkxPVzoKIAkgICAgICAvKiBgaW8uSW5mb3Jt YXRpb24nIGlzIHN1cHBvc2VkbHkgdmFsaWQuICAqLwotCSAgICAgIGxlbiA9IGlvLkluZm9ybWF0 aW9uOwotCSAgICAgIGlmIChsZW4gPT0gMCkKKwkgICAgICB0b3RhbF9sZW4gKz0gaW8uSW5mb3Jt YXRpb247CisJICAgICAgaWYgKHRvdGFsX2xlbiA8IG9yaWdfbGVuKQogCQlrZWVwX2xvb3Bpbmcg PSB0cnVlOworCSAgICAgIGVsc2UKKwkJbGVuID0gdG90YWxfbGVuOwogCSAgICAgIGJyZWFrOwog CSAgICBjYXNlIFNUQVRVU19QSVBFX0xJU1RFTklORzoKIAkgICAgY2FzZSBTVEFUVVNfUElQRV9F TVBUWToK --Multipart=_Fri__3_Sep_2021_19_13_40_+0900_PeQXrR6W4dGHw49O--