From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from conssluserg-04.nifty.com (conssluserg-04.nifty.com [210.131.2.83]) by sourceware.org (Postfix) with ESMTPS id 3D4DB385743A for ; Wed, 8 Sep 2021 00:08:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3D4DB385743A Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=nifty.ne.jp Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=nifty.ne.jp Received: from Express5800-S70 (z221123.dynamic.ppp.asahi-net.or.jp [110.4.221.123]) (authenticated) by conssluserg-04.nifty.com with ESMTP id 18807er7014302 for ; Wed, 8 Sep 2021 09:07:40 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-04.nifty.com 18807er7014302 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.ne.jp; s=dec2015msa; t=1631059660; bh=aArv/aH4sKAwfdfRBBQL/1lUve86V+Nnn0zprBq3X+o=; h=Date:From:To:Subject:In-Reply-To:References:From; b=jUoWsuhXf/dFH6UeB9Ms0OZYltBg2J85uHKjMtXvfdBBWf71HrJogKSs9SdNfnZ2h hzLZsPg0tTMxjBdn3nJiyAXYrUN7BVKX4vh1B47hR4B5Kazmt2zIsa90aj6XKK48Ie mYauq++CsnhMSgDGVz3fMaW7ocTOK6R2fstGV6q9jlMK53+vlihKFpRDdlj/KS6Cph LI9V7vqVcoZAE9bikvVA5QI+jAJFtrjuLpbibezEabXXL1htso/U/IpCf8UL8KbHwf UNZMwavZ4S8j2UA+TWfM5k6mKO3D9XWdRzljJz7GwY6oiyfGnFhCPaEZXkXC0/XJz5 fzuT1fTXCh9Ww== X-Nifty-SrcIP: [110.4.221.123] Date: Wed, 8 Sep 2021 09:07:48 +0900 From: Takashi Yano To: cygwin-developers@cygwin.com Subject: Re: cygrunsrv + sshd + rsync = 20 times too slow -- throttled? Message-Id: <20210908090748.3e70ed5aea3fa3c320b5ae0d@nifty.ne.jp> In-Reply-To: <20210907195023.31ad8194457bb90c2b6971b4@nifty.ne.jp> References: <41A583E1-C8E7-42AB-9F24-EEC33A41EC60@house.org> <20210825201845.07b6400b79dc5558a7761efe@nifty.ne.jp> <20210826062934.54f2f2216021c095bb7ba13b@nifty.ne.jp> <3b560051-ab27-f392-ca4b-d1fd9b5733b0@cornell.edu> <20210827202440.47706fc2fc07c5e9a1bc0047@nifty.ne.jp> <20210907122631.65452be8d021ec72259431d5@nifty.ne.jp> <20210907195023.31ad8194457bb90c2b6971b4@nifty.ne.jp> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Sep 2021 00:08:18 -0000 On Tue, 7 Sep 2021 19:50:23 +0900 Takashi Yano wrote: > @@ -796,7 +792,8 @@ pipe_cleanup (select_record *, select_stuff *stuff) > pi->stop_thread = true; > SetEvent (pi->bye); ~~~~~~~~~~~~~~~~~~~ This is not correct. SetEvent() wakes-up one of thread_pipe()s, but it may be other thread than one which should be stopped. > pi->thread->detach (); > - CloseHandle (pi->bye); > + if (me->fh->get_select_evt () == NULL) > + CloseHandle (pi->bye); > } > delete pi; > stuff->device_specific_pipe = NULL; I think it also should be > + for (ULONG i = 0; i < get_obj_handle_count (select_evt); i++) > + SetEvent (select_evt); Actually I want to use PulseEvent() here if it is not **UNRELIABLE**. https://docs.microsoft.com/en-us/windows-hardware/drivers/devtest/28648-pulseevent-is-an-unreliable-function Does using semaphore object instead of event, and releasing resources equal to the number of handles make sense? -- Takashi Yano