From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from conssluserg-03.nifty.com (conssluserg-03.nifty.com [210.131.2.82]) by sourceware.org (Postfix) with ESMTPS id 7D0973858414 for ; Wed, 8 Sep 2021 12:33:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7D0973858414 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=nifty.ne.jp Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=nifty.ne.jp Received: from Express5800-S70 (z221123.dynamic.ppp.asahi-net.or.jp [110.4.221.123]) (authenticated) by conssluserg-03.nifty.com with ESMTP id 188CXJWt007163 for ; Wed, 8 Sep 2021 21:33:19 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-03.nifty.com 188CXJWt007163 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.ne.jp; s=dec2015msa; t=1631104399; bh=kp6f7RQrofqieDsEpjleSwT4RLlspxpLtr4kUHxP+Ag=; h=Date:From:To:Subject:In-Reply-To:References:From; b=Mr3JrapdofLrQsr1o8BGvf3N8LHvlXnshiGFUAaZwSpxEokPEeiKD1v3nN3ZJnI5t /QRq7LrvQmV0ynkE7+dwqXfWNBJWht4nfiirzBO1EKCKwfwr1OEfvNaaE7scWR1E+7 eRiqKd8RgQb5071JI4ZSg3oh4cPrjUw3s9PWnHGuJYvnq4x58rFeChUygm4lrUG0eH SYkBApTMCIpbW0bpzH5vk5Epal1BI9RJBrLYcotqDgpxrSSmvhohl3+zRurluM7SRs CRZXqK5zHQXUqVPxWyII0982mHDLRbjSPzwJEBzCLCgmNMqCEShTpYe8lNtXWwNIGE jICLi9UbuJa6Q== X-Nifty-SrcIP: [110.4.221.123] Date: Wed, 8 Sep 2021 21:33:21 +0900 From: Takashi Yano To: cygwin-developers@cygwin.com Subject: Re: cygrunsrv + sshd + rsync = 20 times too slow -- throttled? Message-Id: <20210908213321.a748458de7d1a67c9492b5d6@nifty.ne.jp> In-Reply-To: References: <20210901172339.1039604b7067e0492534a20f@nifty.ne.jp> <24138e20-aa97-cfea-bf48-198fc67755ea@cornell.edu> <9ba687eb-f4a0-18f8-b10b-76e7e51e123e@cornell.edu> <152bfc0c-2f72-c684-6fc5-aa7c36c136b8@cornell.edu> <20210908203234.8cc6215e05108d9ad0507bd3@nifty.ne.jp> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Sep 2021 12:33:53 -0000 On Wed, 8 Sep 2021 13:55:41 +0200 Corinna Vinschen wrote: > On Sep 8 20:32, Takashi Yano wrote: > > Hi Corinna, > > > > On Thu, 2 Sep 2021 21:35:21 +0200 > > Corinna Vinschen wrote: > > > It's getting too late again. I drop off for tonight, but I attached > > > my POC code I have so far. It also adds the snippets from my previous > > > patch which fixes stuff Takashi found during testing. > > > [...] > > > Patch relativ to topic/pipe attached. Would you both mind to take a > > > scrutinizing look? > > > > Sorry for replying to old post. > > > > As for this patch, read_mtx was introduced. This handle is initialized > > only for read pipe. However, this seems to be NULL even without > > initialization in write pipe. I wonder why initializing read_mtx in > > the constructor is not necessary. > > > > How do you guarantee that read_mtx is NULL on the write pipe? > > fhandlers are always calloc'ed on the cygheap, so you don't have > to initialize anything to NULL. It doesn't hurt, of course, but > it's certainly not required. Thanks for the answer. I understand. -- Takashi Yano