From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from conssluserg-04.nifty.com (conssluserg-04.nifty.com [210.131.2.83]) by sourceware.org (Postfix) with ESMTPS id 098CF38654A4 for ; Thu, 9 Sep 2021 03:21:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 098CF38654A4 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=nifty.ne.jp Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=nifty.ne.jp Received: from Express5800-S70 (z221123.dynamic.ppp.asahi-net.or.jp [110.4.221.123]) (authenticated) by conssluserg-04.nifty.com with ESMTP id 1893LVU6000425 for ; Thu, 9 Sep 2021 12:21:31 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-04.nifty.com 1893LVU6000425 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.ne.jp; s=dec2015msa; t=1631157691; bh=IbcxaDAevlKFHLFXWL9KtGtmwTlFxAvdw8gMm76iqV8=; h=Date:From:To:Subject:In-Reply-To:References:From; b=Q+u7cuf3gF0z5W7/s1wcCGgEwZQwuJgmTyC0ZLEAO4JBGvnsHfOYKykz38+OlxAcl oIpl/6iRMvuAVszKSveWnwo+PuaFJbvEViMIFW+9NK/THfzylaAlOwYkLH0Rmkqvci v9d5JwgW3atHGYn1XNE8mIIsMAUzBylR1yUzvMxL/RZyXC0kq3vM8FUpyBADMx+WQZ jW9mfGTvkFzy1lpXWQnDpDXw4sRZg8vzv6zLNCddWCnFFSQzmlpocLHcZ8qxYAmG/h CI36aGL+ZyGvQaN5pcxS4npLGcllBQx4fPZ1vC90anhtQYNilamOJSVrMlJ6P1tCaY tWehtVxQbGcpw== X-Nifty-SrcIP: [110.4.221.123] Date: Thu, 9 Sep 2021 12:21:41 +0900 From: Takashi Yano To: cygwin-developers@cygwin.com Subject: Re: cygrunsrv + sshd + rsync = 20 times too slow -- throttled? Message-Id: <20210909122141.ad3fb87c03395a59d961fc3d@nifty.ne.jp> In-Reply-To: References: <20210827202440.47706fc2fc07c5e9a1bc0047@nifty.ne.jp> <20210907122631.65452be8d021ec72259431d5@nifty.ne.jp> <20210907195023.31ad8194457bb90c2b6971b4@nifty.ne.jp> <20210908090748.3e70ed5aea3fa3c320b5ae0d@nifty.ne.jp> <20210908131141.bf63a795ce13c8dd8f5c13a8@nifty.ne.jp> <20210908184511.75c901b132c71911aaaa6ad6@nifty.ne.jp> <20210908194529.148fe98ca7593b079d0b1e65@nifty.ne.jp> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Multipart=_Thu__9_Sep_2021_12_21_41_+0900_M3u1wuqHX.z7IR8C" X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Sep 2021 03:21:54 -0000 This is a multi-part message in MIME format. --Multipart=_Thu__9_Sep_2021_12_21_41_+0900_M3u1wuqHX.z7IR8C Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 8 Sep 2021 12:51:31 +0200 Corinna Vinschen wrote: > On Sep 8 19:45, Takashi Yano wrote: > > Hi Corinna, > > > > On Wed, 8 Sep 2021 12:04:21 +0200 > > Corinna Vinschen wrote: > > > On Sep 8 18:45, Takashi Yano wrote: > > > > On Wed, 8 Sep 2021 11:26:21 +0200 > > > > Corinna Vinschen wrote: > > > > > On Sep 8 11:01, Corinna Vinschen wrote: > > > > > > What exactly is the problem in the code which results in high CPU > > > > > > load? Can you explain this a bit? Maybe we need an entirely > > > > > > different approach to avoid that. > > > > > > > > > > I saw your new patch, but I don't see the problem. I typed a lot of > > > > > keys in mintty quickly and what happens is that the load of mintty > > > > > goes up to 9% on a 4 CPU system, but only temporarily while typing. > > > > > How do you reproduce the problem? > > > > > > > > Did you apply the patch > > > > 0001-Cygwin-select-Introduce-select_evt-event-for-pipe.patch > > > > or > > > > 0001-Cygwin-select-Introduce-select_sem-semaphore-for-pip.patch > > > > ? > > > > > > > > With these patch, the problem does not occur. The problem occurs > > > > with the commit dccde0dc. > > > > > > dccde0dc is 23bb19efcc45 in topic/pipe ATM (after force push) so, yes, > > > I'm running this with topic/pipe HEAD including this patch. > > > > > > > With my 4 core 8 thread CPU, CPU loads goes up to 12-13 % if > > > > I type keys using key repeat (30cps) after the commit dccde0dc. > > > > > > Oh, wow! As I wrote above, before applying "Cygwin: select: Introduce > > > select_sem semaphore for pipe." I only saw a 9% load. After applying > > > the patch I saw the same load. > > > > > > I don't know what I did differently, but after reverting your semaphore > > > patch I now see loads of up to 30%. So, never mind, apparently I tested > > > wrongly before. Your patch reduces the load tremendously. > > > > Thanks for testing again. > > > > > Just one question. Would you mind to split your patch into two parts, > > > one being just the revert of your "Improve select/poll response." patch > > > and one introducing select_sem? > > > > I split the patch as you advised. > > Pushed. Timing of select_sem notification is fixed by the patch attached. -- Takashi Yano --Multipart=_Thu__9_Sep_2021_12_21_41_+0900_M3u1wuqHX.z7IR8C Content-Type: application/octet-stream; name="0001-Cygwin-pipe-Fix-notification-timing-of-select_sem.patch" Content-Disposition: attachment; filename="0001-Cygwin-pipe-Fix-notification-timing-of-select_sem.patch" Content-Transfer-Encoding: base64 RnJvbSA1NmZmNjRlYWRmYjUzOWExOGY0YjdkNWZmZDMzNTVkZmIyMzM5MWFiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUYWthc2hpIFlhbm8gPHRha2FzaGkueWFub0BuaWZ0eS5uZS5q cD4KRGF0ZTogVGh1LCA5IFNlcCAyMDIxIDEyOjA4OjM5ICswOTAwClN1YmplY3Q6IFtQQVRDSF0g Q3lnd2luOiBwaXBlOiBGaXggbm90aWZpY2F0aW9uIHRpbWluZyBvZiBzZWxlY3Rfc2VtLgoKLSBN YWtlIHNlbGVjdF9zZW0gbm90aWZ5IGV2ZW4gd2hlbiByZWFkL3dyaXRlIHBhcnRpYWxseS4KLS0t CiB3aW5zdXAvY3lnd2luL2ZoYW5kbGVyX3BpcGUuY2MgfCAxNCArKysrKysrKysrLS0tLQogMSBm aWxlIGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvd2luc3VwL2N5Z3dpbi9maGFuZGxlcl9waXBlLmNjIGIvd2luc3VwL2N5Z3dpbi9maGFuZGxl cl9waXBlLmNjCmluZGV4IGVhOGVhNDFkZC4uNDg4ZTE0YmU4IDEwMDY0NAotLS0gYS93aW5zdXAv Y3lnd2luL2ZoYW5kbGVyX3BpcGUuY2MKKysrIGIvd2luc3VwL2N5Z3dpbi9maGFuZGxlcl9waXBl LmNjCkBAIC0zMTEsNiArMzExLDkgQEAgZmhhbmRsZXJfcGlwZTo6cmF3X3JlYWQgKHZvaWQgKnB0 ciwgc2l6ZV90JiBsZW4pCiAJICAgIHsKIAkgICAgICBzdGF0dXMgPSBTVEFUVVNfVEhSRUFEX1NJ R05BTEVEOwogCSAgICAgIG5ieXRlcyArPSBpby5JbmZvcm1hdGlvbjsKKwkgICAgICBpZiAoc2Vs ZWN0X3NlbSAmJiBpby5JbmZvcm1hdGlvbiA+IDApCisJCVJlbGVhc2VTZW1hcGhvcmUgKHNlbGVj dF9zZW0sCisJCQkJICBnZXRfb2JqX2hhbmRsZV9jb3VudCAoc2VsZWN0X3NlbSksIE5VTEwpOwog CSAgICAgIGJyZWFrOwogCSAgICB9CiAJICBzdGF0dXMgPSBpby5TdGF0dXM7CkBAIC0zNjUsNiAr MzY4LDggQEAgZmhhbmRsZXJfcGlwZTo6cmF3X3JlYWQgKHZvaWQgKnB0ciwgc2l6ZV90JiBsZW4p CiAKICAgICAgIGlmIChuYnl0ZXNfbm93ID09IDApCiAJYnJlYWs7CisgICAgICBlbHNlIGlmIChz ZWxlY3Rfc2VtKQorCVJlbGVhc2VTZW1hcGhvcmUgKHNlbGVjdF9zZW0sIGdldF9vYmpfaGFuZGxl X2NvdW50IChzZWxlY3Rfc2VtKSwgTlVMTCk7CiAgICAgfQogICBSZWxlYXNlTXV0ZXggKHJlYWRf bXR4KTsKICAgaWYgKGV2dCkKQEAgLTM3Niw4ICszODEsNiBAQCBmaGFuZGxlcl9waXBlOjpyYXdf cmVhZCAodm9pZCAqcHRyLCBzaXplX3QmIGxlbikKICAgICB9CiAgIGVsc2UgaWYgKHN0YXR1cyA9 PSBTVEFUVVNfVEhSRUFEX0NBTkNFTEVEKQogICAgIHB0aHJlYWQ6OnN0YXRpY19jYW5jZWxfc2Vs ZiAoKTsKLSAgaWYgKHNlbGVjdF9zZW0gJiYgbmJ5dGVzKQotICAgIFJlbGVhc2VTZW1hcGhvcmUg KHNlbGVjdF9zZW0sIGdldF9vYmpfaGFuZGxlX2NvdW50IChzZWxlY3Rfc2VtKSwgTlVMTCk7CiAg IGxlbiA9IG5ieXRlczsKIH0KIApAQCAtNDcyLDYgKzQ3NSw5IEBAIGZoYW5kbGVyX3BpcGVfZmlm bzo6cmF3X3dyaXRlIChjb25zdCB2b2lkICpwdHIsIHNpemVfdCBsZW4pCiAJICAgIHsKIAkgICAg ICBzdGF0dXMgPSBTVEFUVVNfVEhSRUFEX1NJR05BTEVEOwogCSAgICAgIG5ieXRlcyArPSBpby5J bmZvcm1hdGlvbjsKKwkgICAgICBpZiAoc2VsZWN0X3NlbSAmJiBpby5JbmZvcm1hdGlvbiA+IDAp CisJCVJlbGVhc2VTZW1hcGhvcmUgKHNlbGVjdF9zZW0sCisJCQkJICBnZXRfb2JqX2hhbmRsZV9j b3VudCAoc2VsZWN0X3NlbSksIE5VTEwpOwogCSAgICAgIGJyZWFrOwogCSAgICB9CiAJICBzdGF0 dXMgPSBpby5TdGF0dXM7CkBAIC01MDIsNiArNTA4LDggQEAgZmhhbmRsZXJfcGlwZV9maWZvOjpy YXdfd3JpdGUgKGNvbnN0IHZvaWQgKnB0ciwgc2l6ZV90IGxlbikKIAogICAgICAgaWYgKG5ieXRl c19ub3cgPT0gMCkKIAlicmVhazsKKyAgICAgIGVsc2UgaWYgKHNlbGVjdF9zZW0pCisJUmVsZWFz ZVNlbWFwaG9yZSAoc2VsZWN0X3NlbSwgZ2V0X29ial9oYW5kbGVfY291bnQgKHNlbGVjdF9zZW0p LCBOVUxMKTsKICAgICB9CiAgIGlmIChldnQpCiAgICAgQ2xvc2VIYW5kbGUgKGV2dCk7CkBAIC01 MDksOCArNTE3LDYgQEAgZmhhbmRsZXJfcGlwZV9maWZvOjpyYXdfd3JpdGUgKGNvbnN0IHZvaWQg KnB0ciwgc2l6ZV90IGxlbikKICAgICBzZXRfZXJybm8gKEVJTlRSKTsKICAgZWxzZSBpZiAoc3Rh dHVzID09IFNUQVRVU19USFJFQURfQ0FOQ0VMRUQpCiAgICAgcHRocmVhZDo6c3RhdGljX2NhbmNl bF9zZWxmICgpOwotICBpZiAoc2VsZWN0X3NlbSAmJiBuYnl0ZXMpCi0gICAgUmVsZWFzZVNlbWFw aG9yZSAoc2VsZWN0X3NlbSwgZ2V0X29ial9oYW5kbGVfY291bnQgKHNlbGVjdF9zZW0pLCBOVUxM KTsKICAgcmV0dXJuIG5ieXRlcyA/OiAtMTsKIH0KIAotLSAKMi4zMy4wCgo= --Multipart=_Thu__9_Sep_2021_12_21_41_+0900_M3u1wuqHX.z7IR8C--