From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from conssluserg-01.nifty.com (conssluserg-01.nifty.com [210.131.2.80]) by sourceware.org (Postfix) with ESMTPS id 8BADA384A887 for ; Thu, 9 Sep 2021 10:56:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8BADA384A887 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=nifty.ne.jp Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=nifty.ne.jp Received: from Express5800-S70 (z221123.dynamic.ppp.asahi-net.or.jp [110.4.221.123]) (authenticated) by conssluserg-01.nifty.com with ESMTP id 189Atkqh007169 for ; Thu, 9 Sep 2021 19:55:46 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-01.nifty.com 189Atkqh007169 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.ne.jp; s=dec2015msa; t=1631184946; bh=AKu+gzgAPMlgllZ0GcG0VmI6crRG4y8/bcGgrTcHnJg=; h=Date:From:To:Subject:In-Reply-To:References:From; b=SEuzFA0rSHwGx+5VJ5RTHc+Uv8iAWgnuTiy9QyBzPVHYtx0OXwtUjFttyaGyY0hZB yHIWJpSppP75jwQcq/gRc2CuanwCCm0rls1LfRe8CumnXIAQjHFDkQ0g06w457WFyK 4vppj9baf4SBTF/Imt0oC2aI1Jguc9mHNv/Fl1HxTGvUPLv8jCGnDtYNNPbzTIOGWg N/x354ShiQ26Fy4vqNghW7HDr9xqaMFZynxNNNlPtZNV+bpM57HM0eJlS5o/JsgkFc NVg7RcykUFqoMXyx09FHIzG56LENVuLmnTnntOK4V3pQo0jkxGHNiNLLWZIHfVKy7L fmtZLhJ7ynu+g== X-Nifty-SrcIP: [110.4.221.123] Date: Thu, 9 Sep 2021 19:55:47 +0900 From: Takashi Yano To: cygwin-developers@cygwin.com Subject: Re: cygrunsrv + sshd + rsync = 20 times too slow -- throttled? Message-Id: <20210909195547.506b52eaa3bcb36c88006a96@nifty.ne.jp> In-Reply-To: References: <20210907195023.31ad8194457bb90c2b6971b4@nifty.ne.jp> <20210908090748.3e70ed5aea3fa3c320b5ae0d@nifty.ne.jp> <20210908131141.bf63a795ce13c8dd8f5c13a8@nifty.ne.jp> <20210908184511.75c901b132c71911aaaa6ad6@nifty.ne.jp> <20210908194529.148fe98ca7593b079d0b1e65@nifty.ne.jp> <20210909122141.ad3fb87c03395a59d961fc3d@nifty.ne.jp> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Sep 2021 10:56:14 -0000 Hi Corinna, On Thu, 9 Sep 2021 11:37:06 +0200 Corinna Vinschen wrote: > On Sep 9 12:21, Takashi Yano wrote: > > On Wed, 8 Sep 2021 12:51:31 +0200 > > Corinna Vinschen wrote: > > > > > Just one question. Would you mind to split your patch into two parts, > > > > > one being just the revert of your "Improve select/poll response." patch > > > > > and one introducing select_sem? > > > > > > > > I split the patch as you advised. > > > > > > Pushed. > > > > Timing of select_sem notification is fixed by the patch attached. > > If I'm not entirely off-track, I think this isn't quite right yet. > I assume you want to release the semaphore in all cases some bytes > have been read or written, right? Right. > If so, this should cover the STATUS_THREAD_CANCELED and > STATUS_BUFFER_OVERFLOW cases as well. But then again, the > ReleaseSemaphore calls are a bit spread out over the calls. > > I took the liberty to create a followup patch to the attached one. It > merges all cases potentially reading or writing some bytes into a single > if branch, so only a single ReleaseSemaphore should be required. I > dropped STATUS_MORE_ENTRIES because it's not an error, subsumed under > NT_SUCCESS, and IIUC, never emitted by the underlying code. > > I attached the patch to this mail, can you please check it? Thanks for the patch. LGTM. I also confirmed that your patch solves the problem which I wanted to fix. Thanks again. -- Takashi Yano