From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from conssluserg-01.nifty.com (conssluserg-01.nifty.com [210.131.2.80]) by sourceware.org (Postfix) with ESMTPS id 91F493858430 for ; Thu, 9 Sep 2021 12:20:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 91F493858430 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=nifty.ne.jp Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=nifty.ne.jp Received: from Express5800-S70 (z221123.dynamic.ppp.asahi-net.or.jp [110.4.221.123]) (authenticated) by conssluserg-01.nifty.com with ESMTP id 189CJd3F016668 for ; Thu, 9 Sep 2021 21:19:39 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-01.nifty.com 189CJd3F016668 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.ne.jp; s=dec2015msa; t=1631189979; bh=ZjjRevFqwPtidgqpvgihtmlBQAAWIi3dIJk2lg/q9/4=; h=Date:From:To:Subject:In-Reply-To:References:From; b=zIRMeNgE9HvPAauXRi63UtZahYdi2z5JO8IAXmxZ31Q8dP19HuTV/rqRfOp68pLrw R7majQUzh2JWxV5uxfrMuhiIWL1GjsYbG6zDtySUhNqCm3aW8WJhn6ZIrtIKblkTh+ JSffyY6a3eNoYEKQuP9z8LXwnhWzaEIPh86wgOTOGCQ9YeJbNxjLsvDz48z/afFjvQ gjPxCU6kK4Vijj2tNUC4ih3U51xfvCAGG1MIHLuEhjRPhz7o3/Z0wIlYDddrFKv2PR rO+RZEX8rwcqjx6Fnr3cNNDazNk/wTO4bXZT2OTxnwGkm+4+vtY/xkpg45vy/r2s4I Eo1MXhpQQqs1w== X-Nifty-SrcIP: [110.4.221.123] Date: Thu, 9 Sep 2021 21:19:40 +0900 From: Takashi Yano To: cygwin-developers@cygwin.com Subject: Re: cygrunsrv + sshd + rsync = 20 times too slow -- throttled? Message-Id: <20210909211940.51ef391e27d43f0421962cb8@nifty.ne.jp> In-Reply-To: <20210909170549.506cc3c1f6029d904fece6dd@nifty.ne.jp> References: <41A583E1-C8E7-42AB-9F24-EEC33A41EC60@house.org> <20210825201845.07b6400b79dc5558a7761efe@nifty.ne.jp> <20210826062934.54f2f2216021c095bb7ba13b@nifty.ne.jp> <3b560051-ab27-f392-ca4b-d1fd9b5733b0@cornell.edu> <20210827202440.47706fc2fc07c5e9a1bc0047@nifty.ne.jp> <20210907122631.65452be8d021ec72259431d5@nifty.ne.jp> <20210909124115.555c6be15d675500617d284a@nifty.ne.jp> <20210909170549.506cc3c1f6029d904fece6dd@nifty.ne.jp> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Multipart=_Thu__9_Sep_2021_21_19_40_+0900_wsBxo4SE99whGpKc" X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Sep 2021 12:20:14 -0000 This is a multi-part message in MIME format. --Multipart=_Thu__9_Sep_2021_21_19_40_+0900_wsBxo4SE99whGpKc Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 9 Sep 2021 17:05:49 +0900 Takashi Yano wrote: > On Thu, 9 Sep 2021 12:41:15 +0900 > Takashi Yano wrote: > > diff --git a/winsup/cygwin/fhandler_fifo.cc b/winsup/cygwin/fhandler_fifo.cc > > index 6709fb974..c40573783 100644 > > --- a/winsup/cygwin/fhandler_fifo.cc > > +++ b/winsup/cygwin/fhandler_fifo.cc > > @@ -1047,6 +1047,12 @@ writer_shmem: > > ResetEvent (writer_opening); > > nwriters_unlock (); > > success: > > + if (!select_sem) > > + { > > + char name[MAX_PATH]; > > + __small_sprintf(name, "semaphore-%W", get_pipe_name ()->Buffer); > > + select_sem = CreateSemaphore (&sec_none, 0, INT32_MAX, name); > > + } > > return 1; > > err_close_reader: > > saved_errno = get_errno (); > > Should this be: > > + select_sem = CreateSemaphore (sa_buf, 0, INT32_MAX, name); > ? I revised the patch a bit. -- Takashi Yano --Multipart=_Thu__9_Sep_2021_21_19_40_+0900_wsBxo4SE99whGpKc Content-Type: application/octet-stream; name="0001-Cygwin-fifo-Utilize-select_sem-for-fifo-as-well-as-p.patch" Content-Disposition: attachment; filename="0001-Cygwin-fifo-Utilize-select_sem-for-fifo-as-well-as-p.patch" Content-Transfer-Encoding: base64 RnJvbSBiN2JlNWZiMTFiYWM2MjU4ZTFhYzAxZWNjZmNmY2YyNDAxZGExMjI1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUYWthc2hpIFlhbm8gPHRha2FzaGkueWFub0BuaWZ0eS5uZS5q cD4KRGF0ZTogVGh1LCA5IFNlcCAyMDIxIDE3OjE2OjUwICswOTAwClN1YmplY3Q6IFtQQVRDSF0g Q3lnd2luOiBmaWZvOiBVdGlsaXplIHNlbGVjdF9zZW0gZm9yIGZpZm8gYXMgd2VsbCBhcyBwaXBl LgoKLS0tCiB3aW5zdXAvY3lnd2luL2ZoYW5kbGVyX2ZpZm8uY2MgfCAzNiArKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKystCiB3aW5zdXAvY3lnd2luL3NlbGVjdC5jYyAgICAgICAgfCAx MCArKysrKysrKy0tCiAyIGZpbGVzIGNoYW5nZWQsIDQzIGluc2VydGlvbnMoKyksIDMgZGVsZXRp b25zKC0pCgpkaWZmIC0tZ2l0IGEvd2luc3VwL2N5Z3dpbi9maGFuZGxlcl9maWZvLmNjIGIvd2lu c3VwL2N5Z3dpbi9maGFuZGxlcl9maWZvLmNjCmluZGV4IDY3MDlmYjk3NC4uYTZmY2MzOGY0IDEw MDY0NAotLS0gYS93aW5zdXAvY3lnd2luL2ZoYW5kbGVyX2ZpZm8uY2MKKysrIGIvd2luc3VwL2N5 Z3dpbi9maGFuZGxlcl9maWZvLmNjCkBAIC0xMDQ3LDYgKzEwNDcsMTEgQEAgd3JpdGVyX3NobWVt OgogICBSZXNldEV2ZW50ICh3cml0ZXJfb3BlbmluZyk7CiAgIG53cml0ZXJzX3VubG9jayAoKTsK IHN1Y2Nlc3M6CisgIGlmICghc2VsZWN0X3NlbSkKKyAgICB7CisgICAgICBfX3NtYWxsX3Nwcmlu dGYgKG5wYnVmLCAic2VtYXBob3JlLiUwOHguJTAxNlgiLCBnZXRfZGV2ICgpLCBnZXRfaW5vICgp KTsKKyAgICAgIHNlbGVjdF9zZW0gPSBDcmVhdGVTZW1hcGhvcmUgKHNhX2J1ZiwgMCwgSU5UMzJf TUFYLCBucGJ1Zik7CisgICAgfQogICByZXR1cm4gMTsKIGVycl9jbG9zZV9yZWFkZXI6CiAgIHNh dmVkX2Vycm5vID0gZ2V0X2Vycm5vICgpOwpAQCAtMTIzNSw2ICsxMjQwLDEwIEBAIGZoYW5kbGVy X2ZpZm86OnJhd19yZWFkICh2b2lkICppbl9wdHIsIHNpemVfdCYgbGVuKQogCQkgIGxlbiA9IGlv LkluZm9ybWF0aW9uOwogCQkgIGZpZm9fY2xpZW50X3VubG9jayAoKTsKIAkJICByZWFkaW5nX3Vu bG9jayAoKTsKKwkJICBpZiAoc2VsZWN0X3NlbSkKKwkJICAgIFJlbGVhc2VTZW1hcGhvcmUgKHNl bGVjdF9zZW0sCisJCQkJICAgICAgZ2V0X29ial9oYW5kbGVfY291bnQgKHNlbGVjdF9zZW0pLAor CQkJCSAgICAgIE5VTEwpOwogCQkgIHJldHVybjsKIAkJfQogCSAgICAgIGJyZWFrOwpAQCAtMTI3 Myw2ICsxMjgyLDEwIEBAIGZoYW5kbGVyX2ZpZm86OnJhd19yZWFkICh2b2lkICppbl9wdHIsIHNp emVfdCYgbGVuKQogCQkgICAgZmNfaGFuZGxlcltpXS5sYXN0X3JlYWQgPSB0cnVlOwogCQkgICAg Zmlmb19jbGllbnRfdW5sb2NrICgpOwogCQkgICAgcmVhZGluZ191bmxvY2sgKCk7CisJCSAgICBp ZiAoc2VsZWN0X3NlbSkKKwkJICAgICAgUmVsZWFzZVNlbWFwaG9yZSAoc2VsZWN0X3NlbSwKKwkJ CQkJZ2V0X29ial9oYW5kbGVfY291bnQgKHNlbGVjdF9zZW0pLAorCQkJCQlOVUxMKTsKIAkJICAg IHJldHVybjsKIAkJICB9CiAJCWJyZWFrOwpAQCAtMTMxMiw2ICsxMzI1LDEwIEBAIGZoYW5kbGVy X2ZpZm86OnJhd19yZWFkICh2b2lkICppbl9wdHIsIHNpemVfdCYgbGVuKQogCQkgICAgZmNfaGFu ZGxlcltpXS5sYXN0X3JlYWQgPSB0cnVlOwogCQkgICAgZmlmb19jbGllbnRfdW5sb2NrICgpOwog CQkgICAgcmVhZGluZ191bmxvY2sgKCk7CisJCSAgICBpZiAoc2VsZWN0X3NlbSkKKwkJICAgICAg UmVsZWFzZVNlbWFwaG9yZSAoc2VsZWN0X3NlbSwKKwkJCQkJZ2V0X29ial9oYW5kbGVfY291bnQg KHNlbGVjdF9zZW0pLAorCQkJCQlOVUxMKTsKIAkJICAgIHJldHVybjsKIAkJICB9CiAJCWJyZWFr OwpAQCAtMTM0NSw3ICsxMzYyLDcgQEAgbWF5YmVfcmV0cnk6CiAgICAgICBlbHNlCiAJewogCSAg LyogQWxsb3cgaW50ZXJydXB0aW9uIGFuZCBkb24ndCBob2cgdGhlIENQVS4gKi8KLQkgIERXT1JE IHdhaXRyZXQgPSBjeWd3YWl0IChOVUxMLCAxLCBjd19jYW5jZWwgfCBjd19zaWdfZWludHIpOwor CSAgRFdPUkQgd2FpdHJldCA9IGN5Z3dhaXQgKHNlbGVjdF9zZW0sIDEsIGN3X2NhbmNlbCB8IGN3 X3NpZ19laW50cik7CiAJICBpZiAod2FpdHJldCA9PSBXQUlUX0NBTkNFTEVEKQogCSAgICBwdGhy ZWFkOjpzdGF0aWNfY2FuY2VsX3NlbGYgKCk7CiAJICBlbHNlIGlmICh3YWl0cmV0ID09IFdBSVRf U0lHTkFMRUQpCkBAIC0xNTY5LDYgKzE1ODYsMTEgQEAgZmhhbmRsZXJfZmlmbzo6Y2xvc2UgKCkK ICAgICBOdENsb3NlICh3cml0ZV9yZWFkeSk7CiAgIGlmICh3cml0ZXJfb3BlbmluZykKICAgICBO dENsb3NlICh3cml0ZXJfb3BlbmluZyk7CisgIGlmIChzZWxlY3Rfc2VtKQorICAgIHsKKyAgICAg IFJlbGVhc2VTZW1hcGhvcmUgKHNlbGVjdF9zZW0sIGdldF9vYmpfaGFuZGxlX2NvdW50IChzZWxl Y3Rfc2VtKSwgTlVMTCk7CisgICAgICBOdENsb3NlIChzZWxlY3Rfc2VtKTsKKyAgICB9CiAgIGlm IChub2hhbmRsZSAoKSkKICAgICByZXR1cm4gMDsKICAgZWxzZQpAQCAtMTY4Myw3ICsxNzA1LDE3 IEBAIGZoYW5kbGVyX2ZpZm86OmR1cCAoZmhhbmRsZXJfYmFzZSAqY2hpbGQsIGludCBmbGFncykK ICAgICB9CiAgIGlmICh3cml0ZXIpCiAgICAgaW5jX253cml0ZXJzICgpOworICBpZiAoc2VsZWN0 X3NlbSAmJgorICAgICAgIUR1cGxpY2F0ZUhhbmRsZSAoR2V0Q3VycmVudFByb2Nlc3MgKCksIHNl bGVjdF9zZW0sCisJCQlHZXRDdXJyZW50UHJvY2VzcyAoKSwgJmZoZi0+c2VsZWN0X3NlbSwKKwkJ CTAsICEoZmxhZ3MgJiBPX0NMT0VYRUMpLCBEVVBMSUNBVEVfU0FNRV9BQ0NFU1MpKQorICAgIHsK KyAgICAgIF9fc2V0ZXJybm8gKCk7CisgICAgICBnb3RvIGVycl9jbG9zZV90aHJfc3luY19ldnQ7 CisgICAgfQogICByZXR1cm4gMDsKK2Vycl9jbG9zZV90aHJfc3luY19ldnQ6CisgIE50Q2xvc2Ug KGZoZi0+dGhyX3N5bmNfZXZ0KTsKIGVycl9jbG9zZV9jYW5jZWxfZXZ0OgogICBOdENsb3NlIChm aGYtPmNhbmNlbF9ldnQpOwogZXJyX2Nsb3NlX3VwZGF0ZV9uZWVkZWRfZXZ0OgpAQCAtMTc0Myw2 ICsxNzc1LDggQEAgZmhhbmRsZXJfZmlmbzo6Zml4dXBfYWZ0ZXJfZm9yayAoSEFORExFIHBhcmVu dCkKICAgICAgIG1lLndpbnBpZCA9IEdldEN1cnJlbnRQcm9jZXNzSWQgKCk7CiAgICAgICBuZXcg Y3lndGhyZWFkIChmaWZvX3JlYWRlcl90aHJlYWQsIHRoaXMsICJmaWZvX3JlYWRlciIsIHRocl9z eW5jX2V2dCk7CiAgICAgfQorICBpZiAoc2VsZWN0X3NlbSkKKyAgICBmb3JrX2ZpeHVwIChwYXJl bnQsIHNlbGVjdF9zZW0sICJzZWxlY3Rfc2VtIik7CiAgIGlmICh3cml0ZXIpCiAgICAgaW5jX253 cml0ZXJzICgpOwogfQpkaWZmIC0tZ2l0IGEvd2luc3VwL2N5Z3dpbi9zZWxlY3QuY2MgYi93aW5z dXAvY3lnd2luL3NlbGVjdC5jYwppbmRleCBlOWU3MWIyNjkuLjVlNTgzNDM0YyAxMDA2NDQKLS0t IGEvd2luc3VwL2N5Z3dpbi9zZWxlY3QuY2MKKysrIGIvd2luc3VwL2N5Z3dpbi9zZWxlY3QuY2MK QEAgLTk2Myw3ICs5NjMsMTMgQEAgc3RhcnRfdGhyZWFkX2ZpZm8gKHNlbGVjdF9yZWNvcmQgKm1l LCBzZWxlY3Rfc3R1ZmYgKnN0dWZmKQogICAgIHsKICAgICAgIHBpLT5zdGFydCA9ICZzdHVmZi0+ c3RhcnQ7CiAgICAgICBwaS0+c3RvcF90aHJlYWQgPSBmYWxzZTsKLSAgICAgIHBpLT5ieWUgPSBD cmVhdGVFdmVudCAoJnNlY19ub25lX25paCwgVFJVRSwgRkFMU0UsIE5VTEwpOworICAgICAgcGkt PmJ5ZSA9IG1lLT5maC0+Z2V0X3NlbGVjdF9zZW0gKCk7CisgICAgICBpZiAocGktPmJ5ZSkKKwlE dXBsaWNhdGVIYW5kbGUgKEdldEN1cnJlbnRQcm9jZXNzICgpLCBwaS0+YnllLAorCQkJIEdldEN1 cnJlbnRQcm9jZXNzICgpLCAmcGktPmJ5ZSwKKwkJCSAwLCAwLCBEVVBMSUNBVEVfU0FNRV9BQ0NF U1MpOworICAgICAgZWxzZQorCXBpLT5ieWUgPSBDcmVhdGVTZW1hcGhvcmUgKCZzZWNfbm9uZV9u aWgsIDAsIElOVDMyX01BWCwgTlVMTCk7CiAgICAgICBwaS0+dGhyZWFkID0gbmV3IGN5Z3RocmVh ZCAodGhyZWFkX2ZpZm8sIHBpLCAiZmlmb3NlbCIpOwogICAgICAgbWUtPmggPSAqcGktPnRocmVh ZDsKICAgICAgIGlmICghbWUtPmgpCkBAIC05ODEsNyArOTg3LDcgQEAgZmlmb19jbGVhbnVwIChz ZWxlY3RfcmVjb3JkICosIHNlbGVjdF9zdHVmZiAqc3R1ZmYpCiAgIGlmIChwaS0+dGhyZWFkKQog ICAgIHsKICAgICAgIHBpLT5zdG9wX3RocmVhZCA9IHRydWU7Ci0gICAgICBTZXRFdmVudCAocGkt PmJ5ZSk7CisgICAgICBSZWxlYXNlU2VtYXBob3JlIChwaS0+YnllLCBnZXRfb2JqX2hhbmRsZV9j b3VudCAocGktPmJ5ZSksIE5VTEwpOwogICAgICAgcGktPnRocmVhZC0+ZGV0YWNoICgpOwogICAg ICAgQ2xvc2VIYW5kbGUgKHBpLT5ieWUpOwogICAgIH0KLS0gCjIuMzMuMAoK --Multipart=_Thu__9_Sep_2021_21_19_40_+0900_wsBxo4SE99whGpKc--