From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from conssluserg-05.nifty.com (conssluserg-05.nifty.com [210.131.2.90]) by sourceware.org (Postfix) with ESMTPS id 25F27384B0FB for ; Thu, 9 Sep 2021 12:43:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 25F27384B0FB Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=nifty.ne.jp Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=nifty.ne.jp Received: from Express5800-S70 (z221123.dynamic.ppp.asahi-net.or.jp [110.4.221.123]) (authenticated) by conssluserg-05.nifty.com with ESMTP id 189CgjhM012838 for ; Thu, 9 Sep 2021 21:42:46 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-05.nifty.com 189CgjhM012838 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.ne.jp; s=dec2015msa; t=1631191366; bh=YeGQEYTIcqfTspOhxxlVvEzPBsZ3y0jb3BPcyHbm3TI=; h=Date:From:To:Subject:In-Reply-To:References:From; b=QEcBT/UtN5m6CdRl/uTtSc6ba2u9BmH+eNC3alp7RKeb8OBl2wAdWrmIbKParhULO qdqieMEg4GX399KSKPQvAysTgpEfjVrnp6+nlyfKm/Milg0sQUoV710gyOetELgJrz N9qqurDnMC8joxMnziQFD/zdgBmPfHOVdJuzvzr8HNTbOtpQACwlhTCRpoXmEDIR5f hyZYafx1bq6XBpnwfSfcelp2RjabwFSBhn2yXRvG7tJMeOME6jKCFP8VJvwpTbT44M 0Tw8upLo+LTYCFa357j7/CIk/FKGsrNf1mZu6G4B2hnfplJiWFV40ckHEu93p29ZtX 0O3cleOnTFB1Q== X-Nifty-SrcIP: [110.4.221.123] Date: Thu, 9 Sep 2021 21:42:46 +0900 From: Takashi Yano To: cygwin-developers@cygwin.com Subject: Re: cygrunsrv + sshd + rsync = 20 times too slow -- throttled? Message-Id: <20210909214246.cd1ff1a3062fea27e51ad4ae@nifty.ne.jp> In-Reply-To: <20210909211940.51ef391e27d43f0421962cb8@nifty.ne.jp> References: <41A583E1-C8E7-42AB-9F24-EEC33A41EC60@house.org> <20210825201845.07b6400b79dc5558a7761efe@nifty.ne.jp> <20210826062934.54f2f2216021c095bb7ba13b@nifty.ne.jp> <3b560051-ab27-f392-ca4b-d1fd9b5733b0@cornell.edu> <20210827202440.47706fc2fc07c5e9a1bc0047@nifty.ne.jp> <20210907122631.65452be8d021ec72259431d5@nifty.ne.jp> <20210909124115.555c6be15d675500617d284a@nifty.ne.jp> <20210909170549.506cc3c1f6029d904fece6dd@nifty.ne.jp> <20210909211940.51ef391e27d43f0421962cb8@nifty.ne.jp> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Multipart=_Thu__9_Sep_2021_21_42_46_+0900_g8cndJgXC.7_lWZ9" X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Sep 2021 12:43:03 -0000 This is a multi-part message in MIME format. --Multipart=_Thu__9_Sep_2021_21_42_46_+0900_g8cndJgXC.7_lWZ9 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 9 Sep 2021 21:19:40 +0900 Takashi Yano wrote: > On Thu, 9 Sep 2021 17:05:49 +0900 > Takashi Yano wrote: > > On Thu, 9 Sep 2021 12:41:15 +0900 > > Takashi Yano wrote: > > > diff --git a/winsup/cygwin/fhandler_fifo.cc b/winsup/cygwin/fhandler_fifo.cc > > > index 6709fb974..c40573783 100644 > > > --- a/winsup/cygwin/fhandler_fifo.cc > > > +++ b/winsup/cygwin/fhandler_fifo.cc > > > @@ -1047,6 +1047,12 @@ writer_shmem: > > > ResetEvent (writer_opening); > > > nwriters_unlock (); > > > success: > > > + if (!select_sem) > > > + { > > > + char name[MAX_PATH]; > > > + __small_sprintf(name, "semaphore-%W", get_pipe_name ()->Buffer); > > > + select_sem = CreateSemaphore (&sec_none, 0, INT32_MAX, name); > > > + } > > > return 1; > > > err_close_reader: > > > saved_errno = get_errno (); > > > > Should this be: > > > + select_sem = CreateSemaphore (sa_buf, 0, INT32_MAX, name); > > ? > > I revised the patch a bit. Sorry, I revised the patch again. -- Takashi Yano --Multipart=_Thu__9_Sep_2021_21_42_46_+0900_g8cndJgXC.7_lWZ9 Content-Type: application/octet-stream; name="0001-Cygwin-fifo-Utilize-select_sem-for-fifo-as-well-as-p.patch" Content-Disposition: attachment; filename="0001-Cygwin-fifo-Utilize-select_sem-for-fifo-as-well-as-p.patch" Content-Transfer-Encoding: base64 RnJvbSBiYTkyYTFmZmIxYzliOWJkYWNjMzYzNDQ0ZjI3ZmQzMjgxMzdmZWZkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUYWthc2hpIFlhbm8gPHRha2FzaGkueWFub0BuaWZ0eS5uZS5q cD4KRGF0ZTogVGh1LCA5IFNlcCAyMDIxIDIxOjQwOjM3ICswOTAwClN1YmplY3Q6IFtQQVRDSF0g Q3lnd2luOiBmaWZvOiBVdGlsaXplIHNlbGVjdF9zZW0gZm9yIGZpZm8gYXMgd2VsbCBhcyBwaXBl LgoKLS0tCiB3aW5zdXAvY3lnd2luL2ZoYW5kbGVyX2ZpZm8uY2MgfCAzOCArKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKy0tCiB3aW5zdXAvY3lnd2luL3NlbGVjdC5jYyAgICAgICAgfCAx MCArKysrKysrLS0KIDIgZmlsZXMgY2hhbmdlZCwgNDQgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlv bnMoLSkKCmRpZmYgLS1naXQgYS93aW5zdXAvY3lnd2luL2ZoYW5kbGVyX2ZpZm8uY2MgYi93aW5z dXAvY3lnd2luL2ZoYW5kbGVyX2ZpZm8uY2MKaW5kZXggNjcwOWZiOTc0Li42ZGU5YTIyOWIgMTAw NjQ0Ci0tLSBhL3dpbnN1cC9jeWd3aW4vZmhhbmRsZXJfZmlmby5jYworKysgYi93aW5zdXAvY3ln d2luL2ZoYW5kbGVyX2ZpZm8uY2MKQEAgLTEwNDcsNiArMTA0NywxMSBAQCB3cml0ZXJfc2htZW06 CiAgIFJlc2V0RXZlbnQgKHdyaXRlcl9vcGVuaW5nKTsKICAgbndyaXRlcnNfdW5sb2NrICgpOwog c3VjY2VzczoKKyAgaWYgKCFzZWxlY3Rfc2VtKQorICAgIHsKKyAgICAgIF9fc21hbGxfc3ByaW50 ZiAobnBidWYsICJzZW1hcGhvcmUuJTA4eC4lMDE2WCIsIGdldF9kZXYgKCksIGdldF9pbm8gKCkp OworICAgICAgc2VsZWN0X3NlbSA9IENyZWF0ZVNlbWFwaG9yZSAoc2FfYnVmLCAwLCBJTlQzMl9N QVgsIG5wYnVmKTsKKyAgICB9CiAgIHJldHVybiAxOwogZXJyX2Nsb3NlX3JlYWRlcjoKICAgc2F2 ZWRfZXJybm8gPSBnZXRfZXJybm8gKCk7CkBAIC0xMjM1LDYgKzEyNDAsMTAgQEAgZmhhbmRsZXJf Zmlmbzo6cmF3X3JlYWQgKHZvaWQgKmluX3B0ciwgc2l6ZV90JiBsZW4pCiAJCSAgbGVuID0gaW8u SW5mb3JtYXRpb247CiAJCSAgZmlmb19jbGllbnRfdW5sb2NrICgpOwogCQkgIHJlYWRpbmdfdW5s b2NrICgpOworCQkgIGlmIChzZWxlY3Rfc2VtKQorCQkgICAgUmVsZWFzZVNlbWFwaG9yZSAoc2Vs ZWN0X3NlbSwKKwkJCQkgICAgICBnZXRfb2JqX2hhbmRsZV9jb3VudCAoc2VsZWN0X3NlbSksCisJ CQkJICAgICAgTlVMTCk7CiAJCSAgcmV0dXJuOwogCQl9CiAJICAgICAgYnJlYWs7CkBAIC0xMjcz LDYgKzEyODIsMTAgQEAgZmhhbmRsZXJfZmlmbzo6cmF3X3JlYWQgKHZvaWQgKmluX3B0ciwgc2l6 ZV90JiBsZW4pCiAJCSAgICBmY19oYW5kbGVyW2ldLmxhc3RfcmVhZCA9IHRydWU7CiAJCSAgICBm aWZvX2NsaWVudF91bmxvY2sgKCk7CiAJCSAgICByZWFkaW5nX3VubG9jayAoKTsKKwkJICAgIGlm IChzZWxlY3Rfc2VtKQorCQkgICAgICBSZWxlYXNlU2VtYXBob3JlIChzZWxlY3Rfc2VtLAorCQkJ CQlnZXRfb2JqX2hhbmRsZV9jb3VudCAoc2VsZWN0X3NlbSksCisJCQkJCU5VTEwpOwogCQkgICAg cmV0dXJuOwogCQkgIH0KIAkJYnJlYWs7CkBAIC0xMzEyLDYgKzEzMjUsMTAgQEAgZmhhbmRsZXJf Zmlmbzo6cmF3X3JlYWQgKHZvaWQgKmluX3B0ciwgc2l6ZV90JiBsZW4pCiAJCSAgICBmY19oYW5k bGVyW2ldLmxhc3RfcmVhZCA9IHRydWU7CiAJCSAgICBmaWZvX2NsaWVudF91bmxvY2sgKCk7CiAJ CSAgICByZWFkaW5nX3VubG9jayAoKTsKKwkJICAgIGlmIChzZWxlY3Rfc2VtKQorCQkgICAgICBS ZWxlYXNlU2VtYXBob3JlIChzZWxlY3Rfc2VtLAorCQkJCQlnZXRfb2JqX2hhbmRsZV9jb3VudCAo c2VsZWN0X3NlbSksCisJCQkJCU5VTEwpOwogCQkgICAgcmV0dXJuOwogCQkgIH0KIAkJYnJlYWs7 CkBAIC0xMzQ1LDcgKzEzNjIsNyBAQCBtYXliZV9yZXRyeToKICAgICAgIGVsc2UKIAl7CiAJICAv KiBBbGxvdyBpbnRlcnJ1cHRpb24gYW5kIGRvbid0IGhvZyB0aGUgQ1BVLiAqLwotCSAgRFdPUkQg d2FpdHJldCA9IGN5Z3dhaXQgKE5VTEwsIDEsIGN3X2NhbmNlbCB8IGN3X3NpZ19laW50cik7CisJ ICBEV09SRCB3YWl0cmV0ID0gY3lnd2FpdCAoc2VsZWN0X3NlbSwgMSwgY3dfY2FuY2VsIHwgY3df c2lnX2VpbnRyKTsKIAkgIGlmICh3YWl0cmV0ID09IFdBSVRfQ0FOQ0VMRUQpCiAJICAgIHB0aHJl YWQ6OnN0YXRpY19jYW5jZWxfc2VsZiAoKTsKIAkgIGVsc2UgaWYgKHdhaXRyZXQgPT0gV0FJVF9T SUdOQUxFRCkKQEAgLTE1NjksNiArMTU4NiwxMSBAQCBmaGFuZGxlcl9maWZvOjpjbG9zZSAoKQog ICAgIE50Q2xvc2UgKHdyaXRlX3JlYWR5KTsKICAgaWYgKHdyaXRlcl9vcGVuaW5nKQogICAgIE50 Q2xvc2UgKHdyaXRlcl9vcGVuaW5nKTsKKyAgaWYgKHNlbGVjdF9zZW0pCisgICAgeworICAgICAg UmVsZWFzZVNlbWFwaG9yZSAoc2VsZWN0X3NlbSwgZ2V0X29ial9oYW5kbGVfY291bnQgKHNlbGVj dF9zZW0pLCBOVUxMKTsKKyAgICAgIE50Q2xvc2UgKHNlbGVjdF9zZW0pOworICAgIH0KICAgaWYg KG5vaGFuZGxlICgpKQogICAgIHJldHVybiAwOwogICBlbHNlCkBAIC0xNjMyLDYgKzE2NTQsMTQg QEAgZmhhbmRsZXJfZmlmbzo6ZHVwIChmaGFuZGxlcl9iYXNlICpjaGlsZCwgaW50IGZsYWdzKQog ICAgICAgX19zZXRlcnJubyAoKTsKICAgICAgIGdvdG8gZXJyX2Nsb3NlX3dyaXRlcl9vcGVuaW5n OwogICAgIH0KKyAgaWYgKHNlbGVjdF9zZW0gJiYKKyAgICAgICFEdXBsaWNhdGVIYW5kbGUgKEdl dEN1cnJlbnRQcm9jZXNzICgpLCBzZWxlY3Rfc2VtLAorCQkJR2V0Q3VycmVudFByb2Nlc3MgKCks ICZmaGYtPnNlbGVjdF9zZW0sCisJCQkwLCAhKGZsYWdzICYgT19DTE9FWEVDKSwgRFVQTElDQVRF X1NBTUVfQUNDRVNTKSkKKyAgICB7CisgICAgICBfX3NldGVycm5vICgpOworICAgICAgZ290byBl cnJfY2xvc2Vfc2htZW07CisgICAgfQogICBpZiAoZmhmLT5yZW9wZW5fc2htZW0gKCkgPCAwKQog ICAgIGdvdG8gZXJyX2Nsb3NlX3NobWVtX2hhbmRsZTsKICAgaWYgKHJlYWRlcikKQEAgLTE2NDgs NyArMTY3OCw3IEBAIGZoYW5kbGVyX2ZpZm86OmR1cCAoZmhhbmRsZXJfYmFzZSAqY2hpbGQsIGlu dCBmbGFncykKIAkJCSAgICAwLCAhKGZsYWdzICYgT19DTE9FWEVDKSwgRFVQTElDQVRFX1NBTUVf QUNDRVNTKSkKIAl7CiAJICBfX3NldGVycm5vICgpOwotCSAgZ290byBlcnJfY2xvc2Vfc2htZW07 CisJICBnb3RvIGVycl9jbG9zZV9zZWxlY3Rfc2VtOwogCX0KICAgICAgIGlmIChmaGYtPnJlb3Bl bl9zaGFyZWRfZmNfaGFuZGxlciAoKSA8IDApCiAJZ290byBlcnJfY2xvc2Vfc2hhcmVkX2ZjX2hk bDsKQEAgLTE2OTYsNiArMTcyNiw4IEBAIGVycl9jbG9zZV9zaGFyZWRfZmNfaGFuZGxlcjoKICAg TnRVbm1hcFZpZXdPZlNlY3Rpb24gKEdldEN1cnJlbnRQcm9jZXNzICgpLCBmaGYtPnNoYXJlZF9m Y19oYW5kbGVyKTsKIGVycl9jbG9zZV9zaGFyZWRfZmNfaGRsOgogICBOdENsb3NlIChmaGYtPnNo YXJlZF9mY19oZGwpOworZXJyX2Nsb3NlX3NlbGVjdF9zZW06CisgIE50Q2xvc2UgKGZoZi0+c2Vs ZWN0X3NlbSk7CiBlcnJfY2xvc2Vfc2htZW06CiAgIE50VW5tYXBWaWV3T2ZTZWN0aW9uIChHZXRD dXJyZW50UHJvY2VzcyAoKSwgZmhmLT5zaG1lbSk7CiBlcnJfY2xvc2Vfc2htZW1faGFuZGxlOgpA QCAtMTcyMCw2ICsxNzUyLDggQEAgZmhhbmRsZXJfZmlmbzo6Zml4dXBfYWZ0ZXJfZm9yayAoSEFO RExFIHBhcmVudCkKICAgZm9ya19maXh1cCAocGFyZW50LCBzaG1lbV9oYW5kbGUsICJzaG1lbV9o YW5kbGUiKTsKICAgaWYgKHJlb3Blbl9zaG1lbSAoKSA8IDApCiAgICAgYXBpX2ZhdGFsICgiQ2Fu J3QgcmVvcGVuIHNoYXJlZCBtZW1vcnkgZHVyaW5nIGZvcmssICVFIik7CisgIGlmIChzZWxlY3Rf c2VtKQorICAgIGZvcmtfZml4dXAgKHBhcmVudCwgc2VsZWN0X3NlbSwgInNlbGVjdF9zZW0iKTsK ICAgaWYgKHJlYWRlcikKICAgICB7CiAgICAgICAvKiBNYWtlIHN1cmUgdGhlIGNoaWxkIHN0YXJ0 cyB1bmxvY2tlZC4gKi8KZGlmZiAtLWdpdCBhL3dpbnN1cC9jeWd3aW4vc2VsZWN0LmNjIGIvd2lu c3VwL2N5Z3dpbi9zZWxlY3QuY2MKaW5kZXggZTllNzFiMjY5Li41ZTU4MzQzNGMgMTAwNjQ0Ci0t LSBhL3dpbnN1cC9jeWd3aW4vc2VsZWN0LmNjCisrKyBiL3dpbnN1cC9jeWd3aW4vc2VsZWN0LmNj CkBAIC05NjMsNyArOTYzLDEzIEBAIHN0YXJ0X3RocmVhZF9maWZvIChzZWxlY3RfcmVjb3JkICpt ZSwgc2VsZWN0X3N0dWZmICpzdHVmZikKICAgICB7CiAgICAgICBwaS0+c3RhcnQgPSAmc3R1ZmYt PnN0YXJ0OwogICAgICAgcGktPnN0b3BfdGhyZWFkID0gZmFsc2U7Ci0gICAgICBwaS0+YnllID0g Q3JlYXRlRXZlbnQgKCZzZWNfbm9uZV9uaWgsIFRSVUUsIEZBTFNFLCBOVUxMKTsKKyAgICAgIHBp LT5ieWUgPSBtZS0+ZmgtPmdldF9zZWxlY3Rfc2VtICgpOworICAgICAgaWYgKHBpLT5ieWUpCisJ RHVwbGljYXRlSGFuZGxlIChHZXRDdXJyZW50UHJvY2VzcyAoKSwgcGktPmJ5ZSwKKwkJCSBHZXRD dXJyZW50UHJvY2VzcyAoKSwgJnBpLT5ieWUsCisJCQkgMCwgMCwgRFVQTElDQVRFX1NBTUVfQUND RVNTKTsKKyAgICAgIGVsc2UKKwlwaS0+YnllID0gQ3JlYXRlU2VtYXBob3JlICgmc2VjX25vbmVf bmloLCAwLCBJTlQzMl9NQVgsIE5VTEwpOwogICAgICAgcGktPnRocmVhZCA9IG5ldyBjeWd0aHJl YWQgKHRocmVhZF9maWZvLCBwaSwgImZpZm9zZWwiKTsKICAgICAgIG1lLT5oID0gKnBpLT50aHJl YWQ7CiAgICAgICBpZiAoIW1lLT5oKQpAQCAtOTgxLDcgKzk4Nyw3IEBAIGZpZm9fY2xlYW51cCAo c2VsZWN0X3JlY29yZCAqLCBzZWxlY3Rfc3R1ZmYgKnN0dWZmKQogICBpZiAocGktPnRocmVhZCkK ICAgICB7CiAgICAgICBwaS0+c3RvcF90aHJlYWQgPSB0cnVlOwotICAgICAgU2V0RXZlbnQgKHBp LT5ieWUpOworICAgICAgUmVsZWFzZVNlbWFwaG9yZSAocGktPmJ5ZSwgZ2V0X29ial9oYW5kbGVf Y291bnQgKHBpLT5ieWUpLCBOVUxMKTsKICAgICAgIHBpLT50aHJlYWQtPmRldGFjaCAoKTsKICAg ICAgIENsb3NlSGFuZGxlIChwaS0+YnllKTsKICAgICB9Ci0tIAoyLjMzLjAKCg== --Multipart=_Thu__9_Sep_2021_21_42_46_+0900_g8cndJgXC.7_lWZ9--