From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from conssluserg-05.nifty.com (conssluserg-05.nifty.com [210.131.2.90]) by sourceware.org (Postfix) with ESMTPS id 655A63858C2C for ; Thu, 9 Sep 2021 21:54:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 655A63858C2C Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=nifty.ne.jp Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=nifty.ne.jp Received: from Express5800-S70 (z221123.dynamic.ppp.asahi-net.or.jp [110.4.221.123]) (authenticated) by conssluserg-05.nifty.com with ESMTP id 189LrSu7021463 for ; Fri, 10 Sep 2021 06:53:28 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-05.nifty.com 189LrSu7021463 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.ne.jp; s=dec2015msa; t=1631224408; bh=+MEUcHMBoHfUBh56U0K04BodR4QARhAlkQaFfJO3b7w=; h=Date:From:To:Subject:In-Reply-To:References:From; b=Axhhh9K5/42UmMrGFZEMOHJaY1r126ONFqIRLUfmNt7sj0EgvSVoS+plsM7g2ZsE8 nZNk7Af82/h54m71PLEzx8hu/I5ZuoufAeOt2sqSjtkivVFwJ3uOHoryKmlcWR9hxn QJhViMh1ZyETKirhLyt/nQPSHj0yDq1KE+If8ou0Soal1X+HSzASIjgaNxucLyFnCA oSdT+rndxDiMyQsi783qQFxgnKzsT0NITnUJO86RUdPEbj+kUxDPz1HE8TWumGfHlO 5uVIEK+l4DlHx6u4vaedlzapmr/1VvqcYIfmUj4jPwxIc7/o8hAEdcm/suthIobgVN hqyt+lSKVYjaQ== X-Nifty-SrcIP: [110.4.221.123] Date: Fri, 10 Sep 2021 06:53:34 +0900 From: Takashi Yano To: cygwin-developers@cygwin.com Subject: Re: cygrunsrv + sshd + rsync = 20 times too slow -- throttled? Message-Id: <20210910065334.dbad24eb6b8ea48e9cace6e7@nifty.ne.jp> In-Reply-To: <20210909214246.cd1ff1a3062fea27e51ad4ae@nifty.ne.jp> References: <41A583E1-C8E7-42AB-9F24-EEC33A41EC60@house.org> <20210825201845.07b6400b79dc5558a7761efe@nifty.ne.jp> <20210826062934.54f2f2216021c095bb7ba13b@nifty.ne.jp> <3b560051-ab27-f392-ca4b-d1fd9b5733b0@cornell.edu> <20210827202440.47706fc2fc07c5e9a1bc0047@nifty.ne.jp> <20210907122631.65452be8d021ec72259431d5@nifty.ne.jp> <20210909124115.555c6be15d675500617d284a@nifty.ne.jp> <20210909170549.506cc3c1f6029d904fece6dd@nifty.ne.jp> <20210909211940.51ef391e27d43f0421962cb8@nifty.ne.jp> <20210909214246.cd1ff1a3062fea27e51ad4ae@nifty.ne.jp> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Multipart=_Fri__10_Sep_2021_06_53_34_+0900_upjQP5Uqyc7PKM5L" X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Sep 2021 21:54:08 -0000 This is a multi-part message in MIME format. --Multipart=_Fri__10_Sep_2021_06_53_34_+0900_upjQP5Uqyc7PKM5L Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 9 Sep 2021 21:42:46 +0900 Takashi Yano wrote: > On Thu, 9 Sep 2021 21:19:40 +0900 > Takashi Yano wrote: > > On Thu, 9 Sep 2021 17:05:49 +0900 > > Takashi Yano wrote: > > > On Thu, 9 Sep 2021 12:41:15 +0900 > > > Takashi Yano wrote: > > > > diff --git a/winsup/cygwin/fhandler_fifo.cc b/winsup/cygwin/fhandler_fifo.cc > > > > index 6709fb974..c40573783 100644 > > > > --- a/winsup/cygwin/fhandler_fifo.cc > > > > +++ b/winsup/cygwin/fhandler_fifo.cc > > > > @@ -1047,6 +1047,12 @@ writer_shmem: > > > > ResetEvent (writer_opening); > > > > nwriters_unlock (); > > > > success: > > > > + if (!select_sem) > > > > + { > > > > + char name[MAX_PATH]; > > > > + __small_sprintf(name, "semaphore-%W", get_pipe_name ()->Buffer); > > > > + select_sem = CreateSemaphore (&sec_none, 0, INT32_MAX, name); > > > > + } > > > > return 1; > > > > err_close_reader: > > > > saved_errno = get_errno (); > > > > > > Should this be: > > > > + select_sem = CreateSemaphore (sa_buf, 0, INT32_MAX, name); > > > ? > > > > I revised the patch a bit. > > Sorry, I revised the patch again. The patch still has a mistake. Revised again. -- Takashi Yano --Multipart=_Fri__10_Sep_2021_06_53_34_+0900_upjQP5Uqyc7PKM5L Content-Type: application/octet-stream; name="0001-Cygwin-fifo-Utilize-select_sem-for-fifo-as-well-as-p.patch" Content-Disposition: attachment; filename="0001-Cygwin-fifo-Utilize-select_sem-for-fifo-as-well-as-p.patch" Content-Transfer-Encoding: base64 RnJvbSA2OWU4ZmVhNWMzNGQ3NDZmYWE5YTI2OGVjM2EzZDAwZDkyNDk4MTI3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUYWthc2hpIFlhbm8gPHRha2FzaGkueWFub0BuaWZ0eS5uZS5q cD4KRGF0ZTogRnJpLCAxMCBTZXAgMjAyMSAwNjo0Njo0MCArMDkwMApTdWJqZWN0OiBbUEFUQ0hd IEN5Z3dpbjogZmlmbzogVXRpbGl6ZSBzZWxlY3Rfc2VtIGZvciBmaWZvIGFzIHdlbGwgYXMgcGlw ZS4KCi0tLQogd2luc3VwL2N5Z3dpbi9maGFuZGxlcl9maWZvLmNjIHwgMzggKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKystLQogd2luc3VwL2N5Z3dpbi9zZWxlY3QuY2MgICAgICAgIHwg MTAgKysrKysrKy0tCiAyIGZpbGVzIGNoYW5nZWQsIDQ0IGluc2VydGlvbnMoKyksIDQgZGVsZXRp b25zKC0pCgpkaWZmIC0tZ2l0IGEvd2luc3VwL2N5Z3dpbi9maGFuZGxlcl9maWZvLmNjIGIvd2lu c3VwL2N5Z3dpbi9maGFuZGxlcl9maWZvLmNjCmluZGV4IDY3MDlmYjk3NC4uMWU2MDVkNjk3IDEw MDY0NAotLS0gYS93aW5zdXAvY3lnd2luL2ZoYW5kbGVyX2ZpZm8uY2MKKysrIGIvd2luc3VwL2N5 Z3dpbi9maGFuZGxlcl9maWZvLmNjCkBAIC0xMDQ3LDYgKzEwNDcsMTEgQEAgd3JpdGVyX3NobWVt OgogICBSZXNldEV2ZW50ICh3cml0ZXJfb3BlbmluZyk7CiAgIG53cml0ZXJzX3VubG9jayAoKTsK IHN1Y2Nlc3M6CisgIGlmICghc2VsZWN0X3NlbSkKKyAgICB7CisgICAgICBfX3NtYWxsX3Nwcmlu dGYgKG5wYnVmLCAic2VtYXBob3JlLiUwOHguJTAxNlgiLCBnZXRfZGV2ICgpLCBnZXRfaW5vICgp KTsKKyAgICAgIHNlbGVjdF9zZW0gPSBDcmVhdGVTZW1hcGhvcmUgKHNhX2J1ZiwgMCwgSU5UMzJf TUFYLCBucGJ1Zik7CisgICAgfQogICByZXR1cm4gMTsKIGVycl9jbG9zZV9yZWFkZXI6CiAgIHNh dmVkX2Vycm5vID0gZ2V0X2Vycm5vICgpOwpAQCAtMTIzNSw2ICsxMjQwLDEwIEBAIGZoYW5kbGVy X2ZpZm86OnJhd19yZWFkICh2b2lkICppbl9wdHIsIHNpemVfdCYgbGVuKQogCQkgIGxlbiA9IGlv LkluZm9ybWF0aW9uOwogCQkgIGZpZm9fY2xpZW50X3VubG9jayAoKTsKIAkJICByZWFkaW5nX3Vu bG9jayAoKTsKKwkJICBpZiAoc2VsZWN0X3NlbSkKKwkJICAgIFJlbGVhc2VTZW1hcGhvcmUgKHNl bGVjdF9zZW0sCisJCQkJICAgICAgZ2V0X29ial9oYW5kbGVfY291bnQgKHNlbGVjdF9zZW0pLAor CQkJCSAgICAgIE5VTEwpOwogCQkgIHJldHVybjsKIAkJfQogCSAgICAgIGJyZWFrOwpAQCAtMTI3 Myw2ICsxMjgyLDEwIEBAIGZoYW5kbGVyX2ZpZm86OnJhd19yZWFkICh2b2lkICppbl9wdHIsIHNp emVfdCYgbGVuKQogCQkgICAgZmNfaGFuZGxlcltpXS5sYXN0X3JlYWQgPSB0cnVlOwogCQkgICAg Zmlmb19jbGllbnRfdW5sb2NrICgpOwogCQkgICAgcmVhZGluZ191bmxvY2sgKCk7CisJCSAgICBp ZiAoc2VsZWN0X3NlbSkKKwkJICAgICAgUmVsZWFzZVNlbWFwaG9yZSAoc2VsZWN0X3NlbSwKKwkJ CQkJZ2V0X29ial9oYW5kbGVfY291bnQgKHNlbGVjdF9zZW0pLAorCQkJCQlOVUxMKTsKIAkJICAg IHJldHVybjsKIAkJICB9CiAJCWJyZWFrOwpAQCAtMTMxMiw2ICsxMzI1LDEwIEBAIGZoYW5kbGVy X2ZpZm86OnJhd19yZWFkICh2b2lkICppbl9wdHIsIHNpemVfdCYgbGVuKQogCQkgICAgZmNfaGFu ZGxlcltpXS5sYXN0X3JlYWQgPSB0cnVlOwogCQkgICAgZmlmb19jbGllbnRfdW5sb2NrICgpOwog CQkgICAgcmVhZGluZ191bmxvY2sgKCk7CisJCSAgICBpZiAoc2VsZWN0X3NlbSkKKwkJICAgICAg UmVsZWFzZVNlbWFwaG9yZSAoc2VsZWN0X3NlbSwKKwkJCQkJZ2V0X29ial9oYW5kbGVfY291bnQg KHNlbGVjdF9zZW0pLAorCQkJCQlOVUxMKTsKIAkJICAgIHJldHVybjsKIAkJICB9CiAJCWJyZWFr OwpAQCAtMTM0NSw3ICsxMzYyLDcgQEAgbWF5YmVfcmV0cnk6CiAgICAgICBlbHNlCiAJewogCSAg LyogQWxsb3cgaW50ZXJydXB0aW9uIGFuZCBkb24ndCBob2cgdGhlIENQVS4gKi8KLQkgIERXT1JE IHdhaXRyZXQgPSBjeWd3YWl0IChOVUxMLCAxLCBjd19jYW5jZWwgfCBjd19zaWdfZWludHIpOwor CSAgRFdPUkQgd2FpdHJldCA9IGN5Z3dhaXQgKHNlbGVjdF9zZW0sIDEsIGN3X2NhbmNlbCB8IGN3 X3NpZ19laW50cik7CiAJICBpZiAod2FpdHJldCA9PSBXQUlUX0NBTkNFTEVEKQogCSAgICBwdGhy ZWFkOjpzdGF0aWNfY2FuY2VsX3NlbGYgKCk7CiAJICBlbHNlIGlmICh3YWl0cmV0ID09IFdBSVRf U0lHTkFMRUQpCkBAIC0xNTY5LDYgKzE1ODYsMTEgQEAgZmhhbmRsZXJfZmlmbzo6Y2xvc2UgKCkK ICAgICBOdENsb3NlICh3cml0ZV9yZWFkeSk7CiAgIGlmICh3cml0ZXJfb3BlbmluZykKICAgICBO dENsb3NlICh3cml0ZXJfb3BlbmluZyk7CisgIGlmIChzZWxlY3Rfc2VtKQorICAgIHsKKyAgICAg IFJlbGVhc2VTZW1hcGhvcmUgKHNlbGVjdF9zZW0sIGdldF9vYmpfaGFuZGxlX2NvdW50IChzZWxl Y3Rfc2VtKSwgTlVMTCk7CisgICAgICBOdENsb3NlIChzZWxlY3Rfc2VtKTsKKyAgICB9CiAgIGlm IChub2hhbmRsZSAoKSkKICAgICByZXR1cm4gMDsKICAgZWxzZQpAQCAtMTYzNCw2ICsxNjU2LDE0 IEBAIGZoYW5kbGVyX2ZpZm86OmR1cCAoZmhhbmRsZXJfYmFzZSAqY2hpbGQsIGludCBmbGFncykK ICAgICB9CiAgIGlmIChmaGYtPnJlb3Blbl9zaG1lbSAoKSA8IDApCiAgICAgZ290byBlcnJfY2xv c2Vfc2htZW1faGFuZGxlOworICBpZiAoc2VsZWN0X3NlbSAmJgorICAgICAgIUR1cGxpY2F0ZUhh bmRsZSAoR2V0Q3VycmVudFByb2Nlc3MgKCksIHNlbGVjdF9zZW0sCisJCQlHZXRDdXJyZW50UHJv Y2VzcyAoKSwgJmZoZi0+c2VsZWN0X3NlbSwKKwkJCTAsICEoZmxhZ3MgJiBPX0NMT0VYRUMpLCBE VVBMSUNBVEVfU0FNRV9BQ0NFU1MpKQorICAgIHsKKyAgICAgIF9fc2V0ZXJybm8gKCk7CisgICAg ICBnb3RvIGVycl9jbG9zZV9zaG1lbTsKKyAgICB9CiAgIGlmIChyZWFkZXIpCiAgICAgewogICAg ICAgLyogTWFrZSBzdXJlIHRoZSBjaGlsZCBzdGFydHMgdW5sb2NrZWQuICovCkBAIC0xNjQ4LDcg KzE2NzgsNyBAQCBmaGFuZGxlcl9maWZvOjpkdXAgKGZoYW5kbGVyX2Jhc2UgKmNoaWxkLCBpbnQg ZmxhZ3MpCiAJCQkgICAgMCwgIShmbGFncyAmIE9fQ0xPRVhFQyksIERVUExJQ0FURV9TQU1FX0FD Q0VTUykpCiAJewogCSAgX19zZXRlcnJubyAoKTsKLQkgIGdvdG8gZXJyX2Nsb3NlX3NobWVtOwor CSAgZ290byBlcnJfY2xvc2Vfc2VsZWN0X3NlbTsKIAl9CiAgICAgICBpZiAoZmhmLT5yZW9wZW5f c2hhcmVkX2ZjX2hhbmRsZXIgKCkgPCAwKQogCWdvdG8gZXJyX2Nsb3NlX3NoYXJlZF9mY19oZGw7 CkBAIC0xNjk2LDYgKzE3MjYsOCBAQCBlcnJfY2xvc2Vfc2hhcmVkX2ZjX2hhbmRsZXI6CiAgIE50 VW5tYXBWaWV3T2ZTZWN0aW9uIChHZXRDdXJyZW50UHJvY2VzcyAoKSwgZmhmLT5zaGFyZWRfZmNf aGFuZGxlcik7CiBlcnJfY2xvc2Vfc2hhcmVkX2ZjX2hkbDoKICAgTnRDbG9zZSAoZmhmLT5zaGFy ZWRfZmNfaGRsKTsKK2Vycl9jbG9zZV9zZWxlY3Rfc2VtOgorICBOdENsb3NlIChmaGYtPnNlbGVj dF9zZW0pOwogZXJyX2Nsb3NlX3NobWVtOgogICBOdFVubWFwVmlld09mU2VjdGlvbiAoR2V0Q3Vy cmVudFByb2Nlc3MgKCksIGZoZi0+c2htZW0pOwogZXJyX2Nsb3NlX3NobWVtX2hhbmRsZToKQEAg LTE3MjAsNiArMTc1Miw4IEBAIGZoYW5kbGVyX2ZpZm86OmZpeHVwX2FmdGVyX2ZvcmsgKEhBTkRM RSBwYXJlbnQpCiAgIGZvcmtfZml4dXAgKHBhcmVudCwgc2htZW1faGFuZGxlLCAic2htZW1faGFu ZGxlIik7CiAgIGlmIChyZW9wZW5fc2htZW0gKCkgPCAwKQogICAgIGFwaV9mYXRhbCAoIkNhbid0 IHJlb3BlbiBzaGFyZWQgbWVtb3J5IGR1cmluZyBmb3JrLCAlRSIpOworICBpZiAoc2VsZWN0X3Nl bSkKKyAgICBmb3JrX2ZpeHVwIChwYXJlbnQsIHNlbGVjdF9zZW0sICJzZWxlY3Rfc2VtIik7CiAg IGlmIChyZWFkZXIpCiAgICAgewogICAgICAgLyogTWFrZSBzdXJlIHRoZSBjaGlsZCBzdGFydHMg dW5sb2NrZWQuICovCmRpZmYgLS1naXQgYS93aW5zdXAvY3lnd2luL3NlbGVjdC5jYyBiL3dpbnN1 cC9jeWd3aW4vc2VsZWN0LmNjCmluZGV4IGU5ZTcxYjI2OS4uNWU1ODM0MzRjIDEwMDY0NAotLS0g YS93aW5zdXAvY3lnd2luL3NlbGVjdC5jYworKysgYi93aW5zdXAvY3lnd2luL3NlbGVjdC5jYwpA QCAtOTYzLDcgKzk2MywxMyBAQCBzdGFydF90aHJlYWRfZmlmbyAoc2VsZWN0X3JlY29yZCAqbWUs IHNlbGVjdF9zdHVmZiAqc3R1ZmYpCiAgICAgewogICAgICAgcGktPnN0YXJ0ID0gJnN0dWZmLT5z dGFydDsKICAgICAgIHBpLT5zdG9wX3RocmVhZCA9IGZhbHNlOwotICAgICAgcGktPmJ5ZSA9IENy ZWF0ZUV2ZW50ICgmc2VjX25vbmVfbmloLCBUUlVFLCBGQUxTRSwgTlVMTCk7CisgICAgICBwaS0+ YnllID0gbWUtPmZoLT5nZXRfc2VsZWN0X3NlbSAoKTsKKyAgICAgIGlmIChwaS0+YnllKQorCUR1 cGxpY2F0ZUhhbmRsZSAoR2V0Q3VycmVudFByb2Nlc3MgKCksIHBpLT5ieWUsCisJCQkgR2V0Q3Vy cmVudFByb2Nlc3MgKCksICZwaS0+YnllLAorCQkJIDAsIDAsIERVUExJQ0FURV9TQU1FX0FDQ0VT Uyk7CisgICAgICBlbHNlCisJcGktPmJ5ZSA9IENyZWF0ZVNlbWFwaG9yZSAoJnNlY19ub25lX25p aCwgMCwgSU5UMzJfTUFYLCBOVUxMKTsKICAgICAgIHBpLT50aHJlYWQgPSBuZXcgY3lndGhyZWFk ICh0aHJlYWRfZmlmbywgcGksICJmaWZvc2VsIik7CiAgICAgICBtZS0+aCA9ICpwaS0+dGhyZWFk OwogICAgICAgaWYgKCFtZS0+aCkKQEAgLTk4MSw3ICs5ODcsNyBAQCBmaWZvX2NsZWFudXAgKHNl bGVjdF9yZWNvcmQgKiwgc2VsZWN0X3N0dWZmICpzdHVmZikKICAgaWYgKHBpLT50aHJlYWQpCiAg ICAgewogICAgICAgcGktPnN0b3BfdGhyZWFkID0gdHJ1ZTsKLSAgICAgIFNldEV2ZW50IChwaS0+ YnllKTsKKyAgICAgIFJlbGVhc2VTZW1hcGhvcmUgKHBpLT5ieWUsIGdldF9vYmpfaGFuZGxlX2Nv dW50IChwaS0+YnllKSwgTlVMTCk7CiAgICAgICBwaS0+dGhyZWFkLT5kZXRhY2ggKCk7CiAgICAg ICBDbG9zZUhhbmRsZSAocGktPmJ5ZSk7CiAgICAgfQotLSAKMi4zMy4wCgo= --Multipart=_Fri__10_Sep_2021_06_53_34_+0900_upjQP5Uqyc7PKM5L--