From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from conssluserg-01.nifty.com (conssluserg-01.nifty.com [210.131.2.80]) by sourceware.org (Postfix) with ESMTPS id A9B943858C3B for ; Fri, 10 Sep 2021 03:41:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A9B943858C3B Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=nifty.ne.jp Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=nifty.ne.jp Received: from Express5800-S70 (z221123.dynamic.ppp.asahi-net.or.jp [110.4.221.123]) (authenticated) by conssluserg-01.nifty.com with ESMTP id 18A3fB41013488 for ; Fri, 10 Sep 2021 12:41:11 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-01.nifty.com 18A3fB41013488 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.ne.jp; s=dec2015msa; t=1631245272; bh=j2LaO2Cr3SOvaDzbuGQ7PsWw3Iy09cajXGVR6y9Btdo=; h=Date:From:To:Subject:In-Reply-To:References:From; b=Y1cL9MyUIUU0MGnsIjKIERiC1/8x5KWCp/hV5YOZvUoP40CwEzsXhxQDupFBVDJns zNonPMa7ghxrnjQLA4qPofTrX3cGi2U8HEA5fTybRx3KFCE6avS5Jc8YOmh6y1WHh0 TZ5RgM7+uSeJQ+/t0eyyHqiPm6eKRwAydZlBy6coy0f425Qwhduc6fn9jgrKN0bOhb GxJqwRpQtaCMIk5pYn30kihMn9CRBJHWmDoTkcLyJJ4XS/QgIqsc6lecCvHM78rMCO JPMb5uL+CR+TtdgeWwMxRsqEFI0RpfTGivArX/2vOGC8vjxSLd733dq8L+Yph69EMt mEeH2ydtU/hCQ== X-Nifty-SrcIP: [110.4.221.123] Date: Fri, 10 Sep 2021 12:41:21 +0900 From: Takashi Yano To: cygwin-developers@cygwin.com Subject: Re: cygrunsrv + sshd + rsync = 20 times too slow -- throttled? Message-Id: <20210910124121.e4a6d9b80b457e1614148941@nifty.ne.jp> In-Reply-To: <20210910065334.dbad24eb6b8ea48e9cace6e7@nifty.ne.jp> References: <41A583E1-C8E7-42AB-9F24-EEC33A41EC60@house.org> <20210825201845.07b6400b79dc5558a7761efe@nifty.ne.jp> <20210826062934.54f2f2216021c095bb7ba13b@nifty.ne.jp> <3b560051-ab27-f392-ca4b-d1fd9b5733b0@cornell.edu> <20210827202440.47706fc2fc07c5e9a1bc0047@nifty.ne.jp> <20210907122631.65452be8d021ec72259431d5@nifty.ne.jp> <20210909124115.555c6be15d675500617d284a@nifty.ne.jp> <20210909170549.506cc3c1f6029d904fece6dd@nifty.ne.jp> <20210909211940.51ef391e27d43f0421962cb8@nifty.ne.jp> <20210909214246.cd1ff1a3062fea27e51ad4ae@nifty.ne.jp> <20210910065334.dbad24eb6b8ea48e9cace6e7@nifty.ne.jp> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Multipart=_Fri__10_Sep_2021_12_41_21_+0900_a3peZdd9k6BPecZA" X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Sep 2021 03:41:37 -0000 This is a multi-part message in MIME format. --Multipart=_Fri__10_Sep_2021_12_41_21_+0900_a3peZdd9k6BPecZA Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 10 Sep 2021 06:53:34 +0900 Takashi Yano wrote: > On Thu, 9 Sep 2021 21:42:46 +0900 > Takashi Yano wrote: > > On Thu, 9 Sep 2021 21:19:40 +0900 > > Takashi Yano wrote: > > > On Thu, 9 Sep 2021 17:05:49 +0900 > > > Takashi Yano wrote: > > > > On Thu, 9 Sep 2021 12:41:15 +0900 > > > > Takashi Yano wrote: > > > > > diff --git a/winsup/cygwin/fhandler_fifo.cc b/winsup/cygwin/fhandler_fifo.cc > > > > > index 6709fb974..c40573783 100644 > > > > > --- a/winsup/cygwin/fhandler_fifo.cc > > > > > +++ b/winsup/cygwin/fhandler_fifo.cc > > > > > @@ -1047,6 +1047,12 @@ writer_shmem: > > > > > ResetEvent (writer_opening); > > > > > nwriters_unlock (); > > > > > success: > > > > > + if (!select_sem) > > > > > + { > > > > > + char name[MAX_PATH]; > > > > > + __small_sprintf(name, "semaphore-%W", get_pipe_name ()->Buffer); > > > > > + select_sem = CreateSemaphore (&sec_none, 0, INT32_MAX, name); > > > > > + } > > > > > return 1; > > > > > err_close_reader: > > > > > saved_errno = get_errno (); > > > > > > > > Should this be: > > > > > + select_sem = CreateSemaphore (sa_buf, 0, INT32_MAX, name); > > > > ? > > > > > > I revised the patch a bit. > > > > Sorry, I revised the patch again. > > The patch still has a mistake. Revised again. Partially commonize the codes regarding ReleaseSemaphore() in raw_read(). -- Takashi Yano --Multipart=_Fri__10_Sep_2021_12_41_21_+0900_a3peZdd9k6BPecZA Content-Type: application/octet-stream; name="0001-Cygwin-fifo-Utilize-select_sem-for-fifo-as-well-as-p.patch" Content-Disposition: attachment; filename="0001-Cygwin-fifo-Utilize-select_sem-for-fifo-as-well-as-p.patch" Content-Transfer-Encoding: base64 RnJvbSA3M2U4M2QzMjBiYjdkZTdmNWE2ODkxOGUwM2VhMzc3ZTZlZGYyZDEyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUYWthc2hpIFlhbm8gPHRha2FzaGkueWFub0BuaWZ0eS5uZS5q cD4KRGF0ZTogRnJpLCAxMCBTZXAgMjAyMSAwODo0Mzo1OSArMDkwMApTdWJqZWN0OiBbUEFUQ0hd IEN5Z3dpbjogZmlmbzogVXRpbGl6ZSBzZWxlY3Rfc2VtIGZvciBmaWZvIGFzIHdlbGwgYXMgcGlw ZS4KCi0tLQogd2luc3VwL2N5Z3dpbi9maGFuZGxlcl9maWZvLmNjIHwgNDQgKysrKysrKysrKysr KysrKysrKysrKysrKy0tLS0tLS0tLQogd2luc3VwL2N5Z3dpbi9zZWxlY3QuY2MgICAgICAgIHwg MTAgKysrKysrLS0KIDIgZmlsZXMgY2hhbmdlZCwgNDEgaW5zZXJ0aW9ucygrKSwgMTMgZGVsZXRp b25zKC0pCgpkaWZmIC0tZ2l0IGEvd2luc3VwL2N5Z3dpbi9maGFuZGxlcl9maWZvLmNjIGIvd2lu c3VwL2N5Z3dpbi9maGFuZGxlcl9maWZvLmNjCmluZGV4IDY3MDlmYjk3NC4uYWE4OWZhN2FlIDEw MDY0NAotLS0gYS93aW5zdXAvY3lnd2luL2ZoYW5kbGVyX2ZpZm8uY2MKKysrIGIvd2luc3VwL2N5 Z3dpbi9maGFuZGxlcl9maWZvLmNjCkBAIC0xMDQ3LDYgKzEwNDcsMTEgQEAgd3JpdGVyX3NobWVt OgogICBSZXNldEV2ZW50ICh3cml0ZXJfb3BlbmluZyk7CiAgIG53cml0ZXJzX3VubG9jayAoKTsK IHN1Y2Nlc3M6CisgIGlmICghc2VsZWN0X3NlbSkKKyAgICB7CisgICAgICBfX3NtYWxsX3Nwcmlu dGYgKG5wYnVmLCAic2VtYXBob3JlLiUwOHguJTAxNlgiLCBnZXRfZGV2ICgpLCBnZXRfaW5vICgp KTsKKyAgICAgIHNlbGVjdF9zZW0gPSBDcmVhdGVTZW1hcGhvcmUgKHNhX2J1ZiwgMCwgSU5UMzJf TUFYLCBucGJ1Zik7CisgICAgfQogICByZXR1cm4gMTsKIGVycl9jbG9zZV9yZWFkZXI6CiAgIHNh dmVkX2Vycm5vID0gZ2V0X2Vycm5vICgpOwpAQCAtMTIzMyw5ICsxMjM4LDcgQEAgZmhhbmRsZXJf Zmlmbzo6cmF3X3JlYWQgKHZvaWQgKmluX3B0ciwgc2l6ZV90JiBsZW4pCiAJICAgICAgaWYgKGlv LkluZm9ybWF0aW9uID4gMCkKIAkJewogCQkgIGxlbiA9IGlvLkluZm9ybWF0aW9uOwotCQkgIGZp Zm9fY2xpZW50X3VubG9jayAoKTsKLQkJICByZWFkaW5nX3VubG9jayAoKTsKLQkJICByZXR1cm47 CisJCSAgZ290byBvdXQ7CiAJCX0KIAkgICAgICBicmVhazsKIAkgICAgY2FzZSBTVEFUVVNfUElQ RV9FTVBUWToKQEAgLTEyNzEsOSArMTI3NCw3IEBAIGZoYW5kbGVyX2ZpZm86OnJhd19yZWFkICh2 b2lkICppbl9wdHIsIHNpemVfdCYgbGVuKQogCQkgICAgaWYgKGogPCBuaGFuZGxlcnMpCiAJCSAg ICAgIGZjX2hhbmRsZXJbal0ubGFzdF9yZWFkID0gZmFsc2U7CiAJCSAgICBmY19oYW5kbGVyW2ld Lmxhc3RfcmVhZCA9IHRydWU7Ci0JCSAgICBmaWZvX2NsaWVudF91bmxvY2sgKCk7Ci0JCSAgICBy ZWFkaW5nX3VubG9jayAoKTsKLQkJICAgIHJldHVybjsKKwkJICAgIGdvdG8gb3V0OwogCQkgIH0K IAkJYnJlYWs7CiAJICAgICAgY2FzZSBTVEFUVVNfUElQRV9FTVBUWToKQEAgLTEzMTAsOSArMTMx MSw3IEBAIGZoYW5kbGVyX2ZpZm86OnJhd19yZWFkICh2b2lkICppbl9wdHIsIHNpemVfdCYgbGVu KQogCQkgICAgaWYgKGogPCBuaGFuZGxlcnMpCiAJCSAgICAgIGZjX2hhbmRsZXJbal0ubGFzdF9y ZWFkID0gZmFsc2U7CiAJCSAgICBmY19oYW5kbGVyW2ldLmxhc3RfcmVhZCA9IHRydWU7Ci0JCSAg ICBmaWZvX2NsaWVudF91bmxvY2sgKCk7Ci0JCSAgICByZWFkaW5nX3VubG9jayAoKTsKLQkJICAg IHJldHVybjsKKwkJICAgIGdvdG8gb3V0OwogCQkgIH0KIAkJYnJlYWs7CiAJICAgICAgY2FzZSBT VEFUVVNfUElQRV9FTVBUWToKQEAgLTEzNDUsNyArMTM0NCw3IEBAIG1heWJlX3JldHJ5OgogICAg ICAgZWxzZQogCXsKIAkgIC8qIEFsbG93IGludGVycnVwdGlvbiBhbmQgZG9uJ3QgaG9nIHRoZSBD UFUuICovCi0JICBEV09SRCB3YWl0cmV0ID0gY3lnd2FpdCAoTlVMTCwgMSwgY3dfY2FuY2VsIHwg Y3dfc2lnX2VpbnRyKTsKKwkgIERXT1JEIHdhaXRyZXQgPSBjeWd3YWl0IChzZWxlY3Rfc2VtLCAx LCBjd19jYW5jZWwgfCBjd19zaWdfZWludHIpOwogCSAgaWYgKHdhaXRyZXQgPT0gV0FJVF9DQU5D RUxFRCkKIAkgICAgcHRocmVhZDo6c3RhdGljX2NhbmNlbF9zZWxmICgpOwogCSAgZWxzZSBpZiAo d2FpdHJldCA9PSBXQUlUX1NJR05BTEVEKQpAQCAtMTM2OCw2ICsxMzY3LDEyIEBAIG1heWJlX3Jl dHJ5OgogICAgIH0KIGVycm91dDoKICAgbGVuID0gKHNpemVfdCkgLTE7CisgIHJldHVybjsKK291 dDoKKyAgZmlmb19jbGllbnRfdW5sb2NrICgpOworICByZWFkaW5nX3VubG9jayAoKTsKKyAgaWYg KHNlbGVjdF9zZW0pCisgICAgUmVsZWFzZVNlbWFwaG9yZSAoc2VsZWN0X3NlbSwgZ2V0X29ial9o YW5kbGVfY291bnQgKHNlbGVjdF9zZW0pLCBOVUxMKTsKIH0KIAogaW50IF9fcmVnMgpAQCAtMTU2 OSw2ICsxNTc0LDExIEBAIGZoYW5kbGVyX2ZpZm86OmNsb3NlICgpCiAgICAgTnRDbG9zZSAod3Jp dGVfcmVhZHkpOwogICBpZiAod3JpdGVyX29wZW5pbmcpCiAgICAgTnRDbG9zZSAod3JpdGVyX29w ZW5pbmcpOworICBpZiAoc2VsZWN0X3NlbSkKKyAgICB7CisgICAgICBSZWxlYXNlU2VtYXBob3Jl IChzZWxlY3Rfc2VtLCBnZXRfb2JqX2hhbmRsZV9jb3VudCAoc2VsZWN0X3NlbSksIE5VTEwpOwor ICAgICAgTnRDbG9zZSAoc2VsZWN0X3NlbSk7CisgICAgfQogICBpZiAobm9oYW5kbGUgKCkpCiAg ICAgcmV0dXJuIDA7CiAgIGVsc2UKQEAgLTE2MzQsNiArMTY0NCwxNCBAQCBmaGFuZGxlcl9maWZv OjpkdXAgKGZoYW5kbGVyX2Jhc2UgKmNoaWxkLCBpbnQgZmxhZ3MpCiAgICAgfQogICBpZiAoZmhm LT5yZW9wZW5fc2htZW0gKCkgPCAwKQogICAgIGdvdG8gZXJyX2Nsb3NlX3NobWVtX2hhbmRsZTsK KyAgaWYgKHNlbGVjdF9zZW0gJiYKKyAgICAgICFEdXBsaWNhdGVIYW5kbGUgKEdldEN1cnJlbnRQ cm9jZXNzICgpLCBzZWxlY3Rfc2VtLAorCQkJR2V0Q3VycmVudFByb2Nlc3MgKCksICZmaGYtPnNl bGVjdF9zZW0sCisJCQkwLCAhKGZsYWdzICYgT19DTE9FWEVDKSwgRFVQTElDQVRFX1NBTUVfQUND RVNTKSkKKyAgICB7CisgICAgICBfX3NldGVycm5vICgpOworICAgICAgZ290byBlcnJfY2xvc2Vf c2htZW07CisgICAgfQogICBpZiAocmVhZGVyKQogICAgIHsKICAgICAgIC8qIE1ha2Ugc3VyZSB0 aGUgY2hpbGQgc3RhcnRzIHVubG9ja2VkLiAqLwpAQCAtMTY0OCw3ICsxNjY2LDcgQEAgZmhhbmRs ZXJfZmlmbzo6ZHVwIChmaGFuZGxlcl9iYXNlICpjaGlsZCwgaW50IGZsYWdzKQogCQkJICAgIDAs ICEoZmxhZ3MgJiBPX0NMT0VYRUMpLCBEVVBMSUNBVEVfU0FNRV9BQ0NFU1MpKQogCXsKIAkgIF9f c2V0ZXJybm8gKCk7Ci0JICBnb3RvIGVycl9jbG9zZV9zaG1lbTsKKwkgIGdvdG8gZXJyX2Nsb3Nl X3NlbGVjdF9zZW07CiAJfQogICAgICAgaWYgKGZoZi0+cmVvcGVuX3NoYXJlZF9mY19oYW5kbGVy ICgpIDwgMCkKIAlnb3RvIGVycl9jbG9zZV9zaGFyZWRfZmNfaGRsOwpAQCAtMTY5Niw2ICsxNzE0 LDggQEAgZXJyX2Nsb3NlX3NoYXJlZF9mY19oYW5kbGVyOgogICBOdFVubWFwVmlld09mU2VjdGlv biAoR2V0Q3VycmVudFByb2Nlc3MgKCksIGZoZi0+c2hhcmVkX2ZjX2hhbmRsZXIpOwogZXJyX2Ns b3NlX3NoYXJlZF9mY19oZGw6CiAgIE50Q2xvc2UgKGZoZi0+c2hhcmVkX2ZjX2hkbCk7CitlcnJf Y2xvc2Vfc2VsZWN0X3NlbToKKyAgTnRDbG9zZSAoZmhmLT5zZWxlY3Rfc2VtKTsKIGVycl9jbG9z ZV9zaG1lbToKICAgTnRVbm1hcFZpZXdPZlNlY3Rpb24gKEdldEN1cnJlbnRQcm9jZXNzICgpLCBm aGYtPnNobWVtKTsKIGVycl9jbG9zZV9zaG1lbV9oYW5kbGU6CkBAIC0xNzIwLDYgKzE3NDAsOCBA QCBmaGFuZGxlcl9maWZvOjpmaXh1cF9hZnRlcl9mb3JrIChIQU5ETEUgcGFyZW50KQogICBmb3Jr X2ZpeHVwIChwYXJlbnQsIHNobWVtX2hhbmRsZSwgInNobWVtX2hhbmRsZSIpOwogICBpZiAocmVv cGVuX3NobWVtICgpIDwgMCkKICAgICBhcGlfZmF0YWwgKCJDYW4ndCByZW9wZW4gc2hhcmVkIG1l bW9yeSBkdXJpbmcgZm9yaywgJUUiKTsKKyAgaWYgKHNlbGVjdF9zZW0pCisgICAgZm9ya19maXh1 cCAocGFyZW50LCBzZWxlY3Rfc2VtLCAic2VsZWN0X3NlbSIpOwogICBpZiAocmVhZGVyKQogICAg IHsKICAgICAgIC8qIE1ha2Ugc3VyZSB0aGUgY2hpbGQgc3RhcnRzIHVubG9ja2VkLiAqLwpkaWZm IC0tZ2l0IGEvd2luc3VwL2N5Z3dpbi9zZWxlY3QuY2MgYi93aW5zdXAvY3lnd2luL3NlbGVjdC5j YwppbmRleCBlOWU3MWIyNjkuLjVlNTgzNDM0YyAxMDA2NDQKLS0tIGEvd2luc3VwL2N5Z3dpbi9z ZWxlY3QuY2MKKysrIGIvd2luc3VwL2N5Z3dpbi9zZWxlY3QuY2MKQEAgLTk2Myw3ICs5NjMsMTMg QEAgc3RhcnRfdGhyZWFkX2ZpZm8gKHNlbGVjdF9yZWNvcmQgKm1lLCBzZWxlY3Rfc3R1ZmYgKnN0 dWZmKQogICAgIHsKICAgICAgIHBpLT5zdGFydCA9ICZzdHVmZi0+c3RhcnQ7CiAgICAgICBwaS0+ c3RvcF90aHJlYWQgPSBmYWxzZTsKLSAgICAgIHBpLT5ieWUgPSBDcmVhdGVFdmVudCAoJnNlY19u b25lX25paCwgVFJVRSwgRkFMU0UsIE5VTEwpOworICAgICAgcGktPmJ5ZSA9IG1lLT5maC0+Z2V0 X3NlbGVjdF9zZW0gKCk7CisgICAgICBpZiAocGktPmJ5ZSkKKwlEdXBsaWNhdGVIYW5kbGUgKEdl dEN1cnJlbnRQcm9jZXNzICgpLCBwaS0+YnllLAorCQkJIEdldEN1cnJlbnRQcm9jZXNzICgpLCAm cGktPmJ5ZSwKKwkJCSAwLCAwLCBEVVBMSUNBVEVfU0FNRV9BQ0NFU1MpOworICAgICAgZWxzZQor CXBpLT5ieWUgPSBDcmVhdGVTZW1hcGhvcmUgKCZzZWNfbm9uZV9uaWgsIDAsIElOVDMyX01BWCwg TlVMTCk7CiAgICAgICBwaS0+dGhyZWFkID0gbmV3IGN5Z3RocmVhZCAodGhyZWFkX2ZpZm8sIHBp LCAiZmlmb3NlbCIpOwogICAgICAgbWUtPmggPSAqcGktPnRocmVhZDsKICAgICAgIGlmICghbWUt PmgpCkBAIC05ODEsNyArOTg3LDcgQEAgZmlmb19jbGVhbnVwIChzZWxlY3RfcmVjb3JkICosIHNl bGVjdF9zdHVmZiAqc3R1ZmYpCiAgIGlmIChwaS0+dGhyZWFkKQogICAgIHsKICAgICAgIHBpLT5z dG9wX3RocmVhZCA9IHRydWU7Ci0gICAgICBTZXRFdmVudCAocGktPmJ5ZSk7CisgICAgICBSZWxl YXNlU2VtYXBob3JlIChwaS0+YnllLCBnZXRfb2JqX2hhbmRsZV9jb3VudCAocGktPmJ5ZSksIE5V TEwpOwogICAgICAgcGktPnRocmVhZC0+ZGV0YWNoICgpOwogICAgICAgQ2xvc2VIYW5kbGUgKHBp LT5ieWUpOwogICAgIH0KLS0gCjIuMzMuMAoK --Multipart=_Fri__10_Sep_2021_12_41_21_+0900_a3peZdd9k6BPecZA--