From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from conssluserg-05.nifty.com (conssluserg-05.nifty.com [210.131.2.90]) by sourceware.org (Postfix) with ESMTPS id 583C53858402 for ; Tue, 14 Sep 2021 12:05:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 583C53858402 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=nifty.ne.jp Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=nifty.ne.jp Received: from Express5800-S70 (z221123.dynamic.ppp.asahi-net.or.jp [110.4.221.123]) (authenticated) by conssluserg-05.nifty.com with ESMTP id 18EC55iX022896 for ; Tue, 14 Sep 2021 21:05:06 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-05.nifty.com 18EC55iX022896 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.ne.jp; s=dec2015msa; t=1631621106; bh=oCHAcdUFEe8MLXvGQAwB8B2LhqiOo+mqK/Dn+lA2qqs=; h=Date:From:To:Subject:In-Reply-To:References:From; b=Cs0mGMk0jAt3zciM/p3qSFKwWWbWDakSFwhSmMVnke9HAlzgBY7M5t3rOGTt4YRLa lwl2JpSaCmXSiEYOsbjIy1mlt9dCA6yi7dO3nCOJJIC/OaIgn4ZOAO46LPCzqJscSJ Qqwytva4lJzRkYAkuQwC/Wg9sdb60rL0LrnYwv/EMNXEyZDKvlbepF5TnPRkehVNTK g3V/m8+bpNxiPxVbthGXgZI0eNrVJ3ffWrOFv9QW4TK2k/TJG9g3JF/3P27/qF3apO nqUpsHotAhcKNWQAG6dmWlGilTead6dIn3NVDhG8vsKHdoHqqRVT7ymsqJZOLjVXo0 /nn2q83Wev8Mw== X-Nifty-SrcIP: [110.4.221.123] Date: Tue, 14 Sep 2021 21:05:07 +0900 From: Takashi Yano To: cygwin-developers@cygwin.com Subject: Re: cygrunsrv + sshd + rsync = 20 times too slow -- throttled? Message-Id: <20210914210507.be6c950c948033704542bc42@nifty.ne.jp> In-Reply-To: References: <20210911113517.f74fc3ac1971bbf04c7a9bd1@nifty.ne.jp> <695ce1f4-4f7d-f3f3-6dd3-087467d67b28@cornell.edu> <20210912174849.3d38107568065a95aeb19c7c@nifty.ne.jp> <20210912200423.667e40eb1adc52461bbefa20@nifty.ne.jp> <20210914043718.f420491c6723f3dc2e2d9753@nifty.ne.jp> <20210914170838.6393026ac3eaa4cd4e3d9618@nifty.ne.jp> <20210914185623.0488635bf6d1e925baee5fe8@nifty.ne.jp> <20210914191924.5092f63762d62c88431b5313@nifty.ne.jp> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Multipart=_Tue__14_Sep_2021_21_05_07_+0900__sK1538Vj_pTHjv3" X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Sep 2021 12:05:37 -0000 This is a multi-part message in MIME format. --Multipart=_Tue__14_Sep_2021_21_05_07_+0900__sK1538Vj_pTHjv3 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 14 Sep 2021 13:03:55 +0200 Corinna Vinschen wrote: > On Sep 14 19:19, Takashi Yano wrote: > > On Tue, 14 Sep 2021 18:56:23 +0900 > > Takashi Yano wrote: > > > On Tue, 14 Sep 2021 11:03:39 +0200 > > > Corinna Vinschen wrote: > > > > I don't quite follow the argument. Blocking pipes are using > > > > asynchronous IO, so they are in fact not blocking calls on the > > > > OS level. After calling NtWriteFile, the blocking variation > > > > will go into the subsequent > > > > > > > > waitret = cygwait (evt, INFINITE, cw_cancel | cw_sig); > > > > > > > > So, wouldn't you get the same effect by keeping the pipe in > > > > FILE_PIPE_QUEUE_OPERATION mode and just add a timeout to the above > > > > cygwait call and handle select_sem in a not yet existing WAIT_TIMEOUT > > > > conditional? > > > > > > Sounds reasonable. I revised the patches. Do you mean something like > > > patch attached? > > > > Revised a bit. > > Pushed. I added a bit of text to the commit message in terms of > setting pipes to blocking when exec'ing a non-Cygwin tool. Thanks. I found the handling of EPIPE and SIGPIPE in raw_write() was not correct. Patch attached. -- Takashi Yano --Multipart=_Tue__14_Sep_2021_21_05_07_+0900__sK1538Vj_pTHjv3 Content-Type: application/octet-stream; name="0001-Cygwin-pipe-Fix-handling-of-EPIPE-and-SIGPIPE-in-raw.patch" Content-Disposition: attachment; filename="0001-Cygwin-pipe-Fix-handling-of-EPIPE-and-SIGPIPE-in-raw.patch" Content-Transfer-Encoding: base64 RnJvbSBjNzBkN2U5NzEzZGZlNTVmNTQ5YWJiNmMwNzUwODEyNjc2YmE0Njk5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUYWthc2hpIFlhbm8gPHRha2FzaGkueWFub0BuaWZ0eS5uZS5q cD4KRGF0ZTogVHVlLCAxNCBTZXAgMjAyMSAyMDo1OTowOCArMDkwMApTdWJqZWN0OiBbUEFUQ0hd IEN5Z3dpbjogcGlwZTogRml4IGhhbmRsaW5nIG9mIEVQSVBFIGFuZCBTSUdQSVBFIGluCiByYXdf d3JpdGUoKS4KCi0tLQogd2luc3VwL2N5Z3dpbi9maGFuZGxlcl9waXBlLmNjIHwgMTAgKysrKysr KysrLQogMSBmaWxlIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlm ZiAtLWdpdCBhL3dpbnN1cC9jeWd3aW4vZmhhbmRsZXJfcGlwZS5jYyBiL3dpbnN1cC9jeWd3aW4v ZmhhbmRsZXJfcGlwZS5jYwppbmRleCA3ZTVhYjMyOGMuLmMyZjQzNTNmNiAxMDA2NDQKLS0tIGEv d2luc3VwL2N5Z3dpbi9maGFuZGxlcl9waXBlLmNjCisrKyBiL3dpbnN1cC9jeWd3aW4vZmhhbmRs ZXJfcGlwZS5jYwpAQCAtNDA3LDYgKzQwNywxMyBAQCBmaGFuZGxlcl9waXBlX2ZpZm86OnJhd193 cml0ZSAoY29uc3Qgdm9pZCAqcHRyLCBzaXplX3QgbGVuKQogICBpZiAoIWxlbikKICAgICByZXR1 cm4gMDsKIAorICBpZiAocmVhZGVyX2Nsb3NlZCAoKSkKKyAgICB7CisgICAgICBzZXRfZXJybm8g KEVQSVBFKTsKKyAgICAgIHJhaXNlIChTSUdQSVBFKTsKKyAgICAgIHJldHVybiAtMTsKKyAgICB9 CisKICAgaWYgKGxlbiA8PSBwaXBlX2J1Zl9zaXplKQogICAgIGNodW5rID0gbGVuOwogICBlbHNl IGlmIChpc19ub25ibG9ja2luZyAoKSkKQEAgLTQ3NSw3ICs0ODIsNyBAQCBmaGFuZGxlcl9waXBl X2ZpZm86OnJhd193cml0ZSAoY29uc3Qgdm9pZCAqcHRyLCBzaXplX3QgbGVuKQogCQkgIENhbmNl bElvIChnZXRfaGFuZGxlICgpKTsKIAkJICBzZXRfZXJybm8gKEVQSVBFKTsKIAkJICByYWlzZSAo U0lHUElQRSk7Ci0JCSAgYnJlYWs7CisJCSAgZ290byBvdXQ7CiAJCX0KIAkgICAgICBlbHNlCiAJ CWN5Z3dhaXQgKHNlbGVjdF9zZW0sIDEwKTsKQEAgLTUyNyw2ICs1MzQsNyBAQCBmaGFuZGxlcl9w aXBlX2ZpZm86OnJhd193cml0ZSAoY29uc3Qgdm9pZCAqcHRyLCBzaXplX3QgbGVuKQogICAgICAg aWYgKG5ieXRlc19ub3cgPT0gMCkKIAlicmVhazsKICAgICB9CitvdXQ6CiAgIGlmIChldnQpCiAg ICAgQ2xvc2VIYW5kbGUgKGV2dCk7CiAgIGlmIChzdGF0dXMgPT0gU1RBVFVTX1RIUkVBRF9TSUdO QUxFRCAmJiBuYnl0ZXMgPT0gMCkKLS0gCjIuMzMuMAoK --Multipart=_Tue__14_Sep_2021_21_05_07_+0900__sK1538Vj_pTHjv3--