From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from conssluserg-06.nifty.com (conssluserg-06.nifty.com [210.131.2.91]) by sourceware.org (Postfix) with ESMTPS id C02E63858403 for ; Wed, 15 Sep 2021 13:05:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C02E63858403 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=nifty.ne.jp Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=nifty.ne.jp Received: from Express5800-S70 (z221123.dynamic.ppp.asahi-net.or.jp [110.4.221.123]) (authenticated) by conssluserg-06.nifty.com with ESMTP id 18FD4mOd006785 for ; Wed, 15 Sep 2021 22:04:48 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-06.nifty.com 18FD4mOd006785 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.ne.jp; s=dec2015msa; t=1631711089; bh=ps+GwannBffTAh+f6OII1jYnXu8O49s8959E3pMz9+4=; h=Date:From:To:Subject:In-Reply-To:References:From; b=vSqELvXf+NCy4azf+GSz0N+WOZWp8WvZh4DxbwKl1VUiicaunmxzYev784ESdtshc VcNGdZBZg0ZM02gX35Kh25U+W+xXGM8mRG90tiwSsMw3QctprG7zBJ/5WTiCYN/ji4 L3gkClwgVWWngxaPYgMg9Dh+1zQUmAAvgurTZsDyGRPPSENZxinq6nlNfJyqDe29qS cxb/PkgFOi+6dfHBJJgKxR94cv2VYcgfHhsEgwHdRjKzG8K4dr2nNcfKqFxzJ9Xyww qV71YV8N83vQvKrFQNmx7MuTBkH8QEa/x/abQr1ibP1SsE3++9xmh5w+8Y+Y2deAmD 5tk6maPZfbHQQ== X-Nifty-SrcIP: [110.4.221.123] Date: Wed, 15 Sep 2021 22:04:50 +0900 From: Takashi Yano To: cygwin-developers@cygwin.com Subject: Re: cygrunsrv + sshd + rsync = 20 times too slow -- throttled? Message-Id: <20210915220450.a96397d8b8159d9adfbdab07@nifty.ne.jp> In-Reply-To: References: <20210914210507.be6c950c948033704542bc42@nifty.ne.jp> <20210915092100.796985ae33039f3184483450@nifty.ne.jp> <20210915094454.42ef1d085d9bf92a1af8d39a@nifty.ne.jp> <20210915095911.415d174ea38fb2d2ea8e5432@nifty.ne.jp> <20210915194858.845bcd54c0c63246b40703a8@nifty.ne.jp> <20210915205433.014102a9c1204687135e1417@nifty.ne.jp> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Sep 2021 13:05:25 -0000 On Wed, 15 Sep 2021 14:20:48 +0200 Corinna Vinschen wrote: > After Ken's comment, I was going to suggest this one: > > From 34b14470406cb9551f98707bf63175811a506523 Mon Sep 17 00:00:00 2001 > From: Corinna Vinschen > Date: Wed, 15 Sep 2021 14:17:59 +0200 > Subject: [PATCH] Cygwin: pipes: don't call NtQueryInformationFile on read side > of pipes > > NtQueryInformationFile hangs if it's called on the read side handle of > a pipe while another thread or process is performing a blocking read. > > Avoid select potentially hanging by calling NtQueryInformationFile > only on the write side of the pipe and using PeekNamedPipe otherwise. > > --- > winsup/cygwin/select.cc | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/winsup/cygwin/select.cc b/winsup/cygwin/select.cc > index a09d8a34da2e..566cf66d653b 100644 > --- a/winsup/cygwin/select.cc > +++ b/winsup/cygwin/select.cc > @@ -587,6 +587,14 @@ no_verify (select_record *, fd_set *, fd_set *, fd_set *) > static int > pipe_data_available (int fd, fhandler_base *fh, HANDLE h, bool writing) > { > + if (fh->get_device () == FH_PIPER) > + { > + DWORD nbytes_in_pipe; > + if (!writing && PeekNamedPipe (h, NULL, 0, NULL, &nbytes_in_pipe, NULL)) > + return nbytes_in_pipe > 0; > + return -1; > + } > + > IO_STATUS_BLOCK iosb = {{0}, 0}; > FILE_PIPE_LOCAL_INFORMATION fpli = {0}; > NTSTATUS status; > -- > 2.31.1 > LGTM. I also confirmed a several test cases are all passed with this patch. -- Takashi Yano