From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from conssluserg-05.nifty.com (conssluserg-05.nifty.com [210.131.2.90]) by sourceware.org (Postfix) with ESMTPS id 9805E3858D3C for ; Thu, 16 Sep 2021 19:43:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9805E3858D3C Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=nifty.ne.jp Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=nifty.ne.jp Received: from Express5800-S70 (z221123.dynamic.ppp.asahi-net.or.jp [110.4.221.123]) (authenticated) by conssluserg-05.nifty.com with ESMTP id 18GJgqSe005347 for ; Fri, 17 Sep 2021 04:42:52 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-05.nifty.com 18GJgqSe005347 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.ne.jp; s=dec2015msa; t=1631821372; bh=fxd+Ru621vlaHh4bpe+SsSsm0JFp5N3rUCBTmV1oti0=; h=Date:From:To:Subject:In-Reply-To:References:From; b=qpbRmOxEab33nLP7+CitDQNR0E05Rl+co2Y+qab5nPP04sdtQI1EWqXHhxiHC8Lar DEms7tA898UH1phqypryXSaQVbW9lsgk25Ht+rIZXrvApq0CJY+SQ0xVc5Ro66NZbn hvGXCNym7Zxg974BgxiNK3JOMguEdGw7t+AeHw1A2BeR+GDaNq4xJpb7/lQUftWRKQ HGD5Abq7QbO8sQ6CMahV335i3oFC6F7FXk4K6bmJAONKLCVbhMpgLaovbhATMD/FmA j8K95QL+5HqvMLPMQYrBT+vgMEr4g2/six1aaF0YoRMfB0vIQWh4msI/VAoKnLYWAZ ZcSoZQx6h7NGg== X-Nifty-SrcIP: [110.4.221.123] Date: Fri, 17 Sep 2021 04:42:56 +0900 From: Takashi Yano To: cygwin-developers@cygwin.com Subject: Re: cygrunsrv + sshd + rsync = 20 times too slow -- throttled? Message-Id: <20210917044256.c093351b1af6338f6f11ea50@nifty.ne.jp> In-Reply-To: <4d9e4a0d-1fb0-5fe6-5e09-27ffde8f3174@cornell.edu> References: <20210915205433.014102a9c1204687135e1417@nifty.ne.jp> <20210915220450.a96397d8b8159d9adfbdab07@nifty.ne.jp> <3ca95472-9fb2-3e62-3e28-1bd2f85bc018@cornell.edu> <99e3ac84-bee1-4abd-de9a-4ea2e7b62b61@cornell.edu> <20210916180905.5f857dad0568be96ac36cba5@nifty.ne.jp> <20210916220201.63924a67f337ea876954d7c0@nifty.ne.jp> <20210916232756.fe8c744401b6cf703b1fe993@nifty.ne.jp> <4d9e4a0d-1fb0-5fe6-5e09-27ffde8f3174@cornell.edu> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Multipart=_Fri__17_Sep_2021_04_42_56_+0900_e1L_QVOSARbHv8wb" X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Sep 2021 19:43:14 -0000 This is a multi-part message in MIME format. --Multipart=_Fri__17_Sep_2021_04_42_56_+0900_e1L_QVOSARbHv8wb Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On Thu, 16 Sep 2021 12:02:04 -0400 Ken Brown wrote: > On 9/16/2021 11:46 AM, Ken Brown wrote: > > One minor thing I just noticed: If I'm not mistaken, query_hdl, hdl_cnt_mtx, and > > reader_closed() are used only for pipes, but they're defined in > > fhandler_pipe_fifo rather than fhandler_pipe.  Is there a reason for that? > > Never mind. I see the reason: reader_closed() is called by raw_write. You are right. However, I think it is beter that only reader_closed() is declared in fhandler_pipe_fifo as virtual, and query_hdl and hdl_cnt_mtx are declared in fhandler_pipe. Thank you for making me aware. Patch attached. -- Takashi Yano --Multipart=_Fri__17_Sep_2021_04_42_56_+0900_e1L_QVOSARbHv8wb Content-Type: application/octet-stream; name="0001-Cygwin-pipe-fifo-Move-query_hdl-and-hdl_cnt_mtx-to-f.patch" Content-Disposition: attachment; filename="0001-Cygwin-pipe-fifo-Move-query_hdl-and-hdl_cnt_mtx-to-f.patch" Content-Transfer-Encoding: base64 RnJvbSA2NTI1ODc2ZmYwMDE5N2EzZTViYmZhNTk3NzNiMTllNTRjM2I3ZTU3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUYWthc2hpIFlhbm8gPHRha2FzaGkueWFub0BuaWZ0eS5uZS5q cD4KRGF0ZTogRnJpLCAxNyBTZXAgMjAyMSAwNDoyMzoxMiArMDkwMApTdWJqZWN0OiBbUEFUQ0hd IEN5Z3dpbjogcGlwZSwgZmlmbzogTW92ZSBxdWVyeV9oZGwgYW5kIGhkbF9jbnRfbXR4IHRvCiBm aGFuZGxlcl9waXBlLgoKLSBxdWVyeV9oZGwgYW5kIGhkbF9jbnRfbXR4IGFyZSBtb3ZlZCBmcm9t IGZoYW5kbGVyX3BpcGVfZmlmbyB0bwogIGZoYW5kbGVyX3BpcGUuIFRoZW4gcmVhZGVyX2Nsb3Nl ZCgpIGlzIGNoYW5nZWQgdG8gdmlydHVhbCBhbmQKICBvdmVycmlkZGVuIGluIGZoYW5kbGVyX3Bp cGUuCi0tLQogd2luc3VwL2N5Z3dpbi9maGFuZGxlci5oICAgICAgIHwgMjcgKysrKysrKysrKysr Ky0tLS0tLS0tLS0tLS0tCiB3aW5zdXAvY3lnd2luL2ZoYW5kbGVyX3BpcGUuY2MgfCAgMiArLQog MiBmaWxlcyBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCspLCAxNSBkZWxldGlvbnMoLSkKCmRpZmYg LS1naXQgYS93aW5zdXAvY3lnd2luL2ZoYW5kbGVyLmggYi93aW5zdXAvY3lnd2luL2ZoYW5kbGVy LmgKaW5kZXggMzFlZGIxODIyLi42MTExM2U2OTggMTAwNjQ0Ci0tLSBhL3dpbnN1cC9jeWd3aW4v ZmhhbmRsZXIuaAorKysgYi93aW5zdXAvY3lnd2luL2ZoYW5kbGVyLmgKQEAgLTExNzUsMjYgKzEx NzUsMTMgQEAgY2xhc3MgZmhhbmRsZXJfcGlwZV9maWZvOiBwdWJsaWMgZmhhbmRsZXJfYmFzZQog ewogIHByb3RlY3RlZDoKICAgc2l6ZV90IHBpcGVfYnVmX3NpemU7Ci0gIEhBTkRMRSBxdWVyeV9o ZGw7Ci0gIEhBTkRMRSBoZGxfY250X210eDsKICAgdmlydHVhbCB2b2lkIHJlbGVhc2Vfc2VsZWN0 X3NlbSAoY29uc3QgY2hhciAqKSB7fTsKIAogIHB1YmxpYzoKICAgZmhhbmRsZXJfcGlwZV9maWZv ICgpOwogCi0gIEhBTkRMRSBnZXRfcXVlcnlfaGFuZGxlICgpIGNvbnN0IHsgcmV0dXJuIHF1ZXJ5 X2hkbDsgfQotICB2b2lkIGNsb3NlX3F1ZXJ5X2hhbmRsZSAoKQotICB7Ci0gICAgaWYgKHF1ZXJ5 X2hkbCkKLSAgICAgIHsKLQlDbG9zZUhhbmRsZSAocXVlcnlfaGRsKTsKLQlxdWVyeV9oZGwgPSBO VUxMOwotICAgICAgfQotICB9Ci0gIGJvb2wgcmVhZGVyX2Nsb3NlZCAoKTsKLQorICB2aXJ0dWFs IGJvb2wgcmVhZGVyX2Nsb3NlZCAoKSB7IHJldHVybiBmYWxzZTsgfTsKICAgc3NpemVfdCBfX3Jl ZzMgcmF3X3dyaXRlIChjb25zdCB2b2lkICpwdHIsIHNpemVfdCBsZW4pOwotCiB9OwogCiBjbGFz cyBmaGFuZGxlcl9waXBlOiBwdWJsaWMgZmhhbmRsZXJfcGlwZV9maWZvCkBAIC0xMjAyLDYgKzEx ODksOCBAQCBjbGFzcyBmaGFuZGxlcl9waXBlOiBwdWJsaWMgZmhhbmRsZXJfcGlwZV9maWZvCiBw cml2YXRlOgogICBIQU5ETEUgcmVhZF9tdHg7CiAgIHBpZF90IHBvcGVuX3BpZDsKKyAgSEFORExF IHF1ZXJ5X2hkbDsKKyAgSEFORExFIGhkbF9jbnRfbXR4OwogICB2b2lkIHJlbGVhc2Vfc2VsZWN0 X3NlbSAoY29uc3QgY2hhciAqKTsKIHB1YmxpYzoKICAgZmhhbmRsZXJfcGlwZSAoKTsKQEAgLTEy NTAsNiArMTIzOSwxNiBAQCBwdWJsaWM6CiAgICAgcmV0dXJuIGZoOwogICB9CiAgIHZvaWQgc2V0 X3BpcGVfbm9uX2Jsb2NraW5nIChib29sIG5vbmJsb2NraW5nKTsKKyAgSEFORExFIGdldF9xdWVy eV9oYW5kbGUgKCkgY29uc3QgeyByZXR1cm4gcXVlcnlfaGRsOyB9CisgIHZvaWQgY2xvc2VfcXVl cnlfaGFuZGxlICgpCisgIHsKKyAgICBpZiAocXVlcnlfaGRsKQorICAgICAgeworCUNsb3NlSGFu ZGxlIChxdWVyeV9oZGwpOworCXF1ZXJ5X2hkbCA9IE5VTEw7CisgICAgICB9CisgIH0KKyAgYm9v bCByZWFkZXJfY2xvc2VkICgpOwogfTsKIAogI2RlZmluZSBDWUdXSU5fRklGT19QSVBFX05BTUVf TEVOICAgICA0NwpkaWZmIC0tZ2l0IGEvd2luc3VwL2N5Z3dpbi9maGFuZGxlcl9waXBlLmNjIGIv d2luc3VwL2N5Z3dpbi9maGFuZGxlcl9waXBlLmNjCmluZGV4IDIwNjhhOTQzZS4uNzNhY2UzYWM1 IDEwMDY0NAotLS0gYS93aW5zdXAvY3lnd2luL2ZoYW5kbGVyX3BpcGUuY2MKKysrIGIvd2luc3Vw L2N5Z3dpbi9maGFuZGxlcl9waXBlLmNjCkBAIC0zOTMsNyArMzkzLDcgQEAgZmhhbmRsZXJfcGlw ZTo6cmF3X3JlYWQgKHZvaWQgKnB0ciwgc2l6ZV90JiBsZW4pCiB9CiAKIGJvb2wKLWZoYW5kbGVy X3BpcGVfZmlmbzo6cmVhZGVyX2Nsb3NlZCAoKQorZmhhbmRsZXJfcGlwZTo6cmVhZGVyX2Nsb3Nl ZCAoKQogewogICBpZiAoIXF1ZXJ5X2hkbCkKICAgICByZXR1cm4gZmFsc2U7Ci0tIAoyLjMzLjAK Cg== --Multipart=_Fri__17_Sep_2021_04_42_56_+0900_e1L_QVOSARbHv8wb--