From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from conssluserg-05.nifty.com (conssluserg-05.nifty.com [210.131.2.90]) by sourceware.org (Postfix) with ESMTPS id AAA20385841C for ; Sun, 19 Sep 2021 01:31:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AAA20385841C Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=nifty.ne.jp Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=nifty.ne.jp Received: from Express5800-S70 (z221123.dynamic.ppp.asahi-net.or.jp [110.4.221.123]) (authenticated) by conssluserg-05.nifty.com with ESMTP id 18J1V992018949 for ; Sun, 19 Sep 2021 10:31:10 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-05.nifty.com 18J1V992018949 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.ne.jp; s=dec2015msa; t=1632015070; bh=aWb/u2hXcN3PaTK8sWy+oyv75z44P7NwipF2Gbz+gz0=; h=Date:From:To:Subject:In-Reply-To:References:From; b=gQFqCNhawfwcdT8RVeFCNuf2NmZetuIgGmb4YmN1fe0QtfyYHgOF2stadMXqIMxtL cxxTenh2gH4GjpxDmJRI2VB3zFmTcZfJoC6mGa8dPs86AMGcOcvNWivwSfJ6xDdsrM 25osRRwZXKh0CO2iopcT0PmdkwNk40k0wGwARU2MQEl19Oawd7pjd+lB0p3orn6DiX Hf3CcmkWoUbQWi4K3je0oOwtIWRCaE/a2FO4CxGBug2Cg/T033m6UYenVmBWOCm2GY quLCg0P5UQp5+ZjEMnaCGXAish+MgVtqwq3xiWGbNWuKY3qW+A/Ceo9WRZK3LAk8Z+ b3+W1bcPFrBBQ== X-Nifty-SrcIP: [110.4.221.123] Date: Sun, 19 Sep 2021 10:31:18 +0900 From: Takashi Yano To: cygwin-developers@cygwin.com Subject: Re: cygrunsrv + sshd + rsync = 20 times too slow -- throttled? Message-Id: <20210919103118.27a4c1ab259659b9fede664c@nifty.ne.jp> In-Reply-To: <4739986a-9f0e-7cd0-c633-c7136c31ccdd@cornell.edu> References: <20210915205433.014102a9c1204687135e1417@nifty.ne.jp> <20210915220450.a96397d8b8159d9adfbdab07@nifty.ne.jp> <3ca95472-9fb2-3e62-3e28-1bd2f85bc018@cornell.edu> <99e3ac84-bee1-4abd-de9a-4ea2e7b62b61@cornell.edu> <20210916180905.5f857dad0568be96ac36cba5@nifty.ne.jp> <20210916220201.63924a67f337ea876954d7c0@nifty.ne.jp> <20210916232756.fe8c744401b6cf703b1fe993@nifty.ne.jp> <4739986a-9f0e-7cd0-c633-c7136c31ccdd@cornell.edu> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Sep 2021 01:31:40 -0000 On Sat, 18 Sep 2021 09:44:48 -0400 Ken Brown wrote: > On 9/16/2021 11:01 AM, Corinna Vinschen wrote: > > On Sep 16 23:27, Takashi Yano wrote: > >> On Thu, 16 Sep 2021 15:25:46 +0200 > >> Corinna Vinschen wrote: > >>> It would be great if open_setup() would be converted to a method which > >>> is allowed to fail, rather than ignoring errors in sync object creation > >>> and having to test the handle throughout the code. Given there's only a > >>> single caller of that function (dtable::init_std_file_from_handle), that > >>> shouldn't be much work. But it's certainly better than ignoring creation > >>> failures in the long run. > >> > >> I do not have confidence to do this correctly in a short time. > >> Leave it as a homework. Or may I leave it to you? > > > > That's not a short-term problem, but I think it would be good to do this > > with a bit more paranoia at creation time and then rely on the handles > > being available in the subsequent code. Maybe I can get to it later but > > it certainly wouldn't hurt my feelings if one of you guys look into it > > while I'm abroad. :) > > I took a stab at this on the topic/pipe branch. I haven't done any testing, > other than to make sure that the code compiles. Thanks for working on this! I tested the head of topic/pipe branch, and do not find any defect so far. However, I cannot test the case open_setup() failure, so I am not sure this works as expected in error case. -- Takashi Yano