From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from conssluserg-01.nifty.com (conssluserg-01.nifty.com [210.131.2.80]) by sourceware.org (Postfix) with ESMTPS id A64213858C3A for ; Tue, 21 Sep 2021 10:10:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A64213858C3A Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=nifty.ne.jp Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=nifty.ne.jp Received: from Express5800-S70 (z221123.dynamic.ppp.asahi-net.or.jp [110.4.221.123]) (authenticated) by conssluserg-01.nifty.com with ESMTP id 18LAAbVp007998 for ; Tue, 21 Sep 2021 19:10:37 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-01.nifty.com 18LAAbVp007998 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.ne.jp; s=dec2015msa; t=1632219037; bh=0ZPhcv7rghC3J8JMqdL3DdZ86IFdI6ONkeop+axTzyY=; h=Date:From:To:Subject:In-Reply-To:References:From; b=iLSLLLb/3wlh+9Wm4V66n7aZNEyhO3IewXFcpx6XGZeOHMDkSUoyECoX8kckg+n+1 A7gIoZC/a0K6apxU/xrUiK33sqx3uJX5cmG6QgWd263MRITTw7N87rdZrAtgBgAgkG vmFGd2sia0Edt9oDnjZXDT3qHVfOMK+Dijmx4wyIWqdJU7vSe8MTGKg2dS9AhdFbQe PfGAn1JQBFyAaraNC4B/EmKwZsOV0nhd8iOQvQjFybgsN8Qg7qfXuLuDIShyMrVJrS aUFY1Ay1SO+QJ/W9g4Fk0b22OFCwvn6A/mdsyQhEmxuonS6dflQ8kYhfiCWgTEuFHo kZZcnCC4FTchg== X-Nifty-SrcIP: [110.4.221.123] Date: Tue, 21 Sep 2021 19:10:38 +0900 From: Takashi Yano To: cygwin-developers@cygwin.com Subject: Re: cygrunsrv + sshd + rsync = 20 times too slow -- throttled? Message-Id: <20210921191038.ede0cd89201103b6ff7c42c3@nifty.ne.jp> In-Reply-To: <933038b4-7dc9-485f-ac87-598cedb00fc5@maxrnd.com> References: <20210909211940.51ef391e27d43f0421962cb8@nifty.ne.jp> <20210909214246.cd1ff1a3062fea27e51ad4ae@nifty.ne.jp> <33386baf-3b2d-d57f-2ad3-1bd328ed7935@cornell.edu> <933038b4-7dc9-485f-ac87-598cedb00fc5@maxrnd.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Sep 2021 10:10:58 -0000 On Tue, 21 Sep 2021 09:26:09 +0000 (UTC) Mark Geisert wrote: > Sep 21, 2021 1:31:28 AM Takashi Yano : > > On Mon, 20 Sep 2021 17:39:54 -0400 > > Ken Brown wrote: > >> I'll push it tomorrow unless you find something that needs to be changed before > >> then. > > > > * Add name check when cached information is used. > > * Confirm Name.Buffer returned by NtQueryObject() is not NULL. > > * Add error check for HeapAlloc(). > > > Sorry if this is a dumb question, but why HeapAlloc? If the buffer is only needed temporarily wouldn't alloca work? Or malloc? This function (temporary_query_hdl()) is called within a system call, so calling another system call from it is not good idea I think. For example, errno may be changed by malloc(). -- Takashi Yano