From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from conssluserg-04.nifty.com (conssluserg-04.nifty.com [210.131.2.83]) by sourceware.org (Postfix) with ESMTPS id 5E7333858405 for ; Wed, 27 Oct 2021 00:45:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5E7333858405 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=nifty.ne.jp Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=nifty.ne.jp Received: from Express5800-S70 (z221123.dynamic.ppp.asahi-net.or.jp [110.4.221.123]) (authenticated) by conssluserg-04.nifty.com with ESMTP id 19R0ilgv020281 for ; Wed, 27 Oct 2021 09:44:48 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-04.nifty.com 19R0ilgv020281 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.ne.jp; s=dec2015msa; t=1635295488; bh=QuUuJ/D7dR3yHxsGR4DsD7bnY0FovPBzYFC+cxT3adM=; h=Date:From:To:Subject:In-Reply-To:References:From; b=Ar3rcB8DXLy9NeUs9Ym3++RZYbHOb/mt1nRUrAXM37NRfxtI+R+eDfQTz64OBe1IH W/j2I/xZy7sPcr+5UGI4Choni9OADA25GZrPPZG8MGJ7AkFX0k22RURGXhLS9qU1HE JwDdncnNj3Bn9hubAs2bJ3ahsOCwLiGbvhV4ufy5pA0LTX0GyEZzMt85lUuUAkj1KP uJKf431ZlKXiWlDPDiI4U2Mm1JB1xUXoV3MwDC/Km1SnnoKbAI2+ekueLYDGIq0Hjv i0GaSfdyIvXKPlWY/K6lE4hlpLF5uwp2Il05uHC9UMXlAeYgepZYCRqNnU1QZ1GEvG wONleQtfrEx8g== X-Nifty-SrcIP: [110.4.221.123] Date: Wed, 27 Oct 2021 09:44:56 +0900 From: Takashi Yano To: cygwin-developers@cygwin.com Subject: Re: malloc crash Message-Id: <20211027094456.07db314033f2fc513604f458@nifty.ne.jp> In-Reply-To: References: <6a4d6675-7e4d-bcb3-9aff-acc0788d211d@cornell.edu> <97873b16-7ec3-02d7-1861-3ec62a79c37e@cornell.edu> <4b322eb0-4941-6b8f-6f46-aa76caf5a66f@cornell.edu> <66ba46c1-afcd-5f31-58ef-06f96209127e@cornell.edu> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Oct 2021 00:45:08 -0000 On Tue, 26 Oct 2021 18:49:33 +0200 Corinna Vinschen wrote: > On Oct 26 12:36, Ken Brown wrote: > > On 10/26/2021 12:03 PM, Corinna Vinschen wrote: > > > On Oct 26 10:32, Ken Brown wrote: > > > > It might take a while to get this right, and the bug has existed ever since > > > > I overhauled the fifo code. So I don't think you have to hold up releasing > > > > 3.3.0 while I work on this. > > > > > > Try the below patch instead, per Takashi's testing and subsequent discussion. > > > [...] > > I agree with Takashi that this fixes the problem. Thanks to both of you! > > This saved me a lot of testing and the risk of introducing new bugs. > > Below's another incarnation of this patch. I wasn't quite happy with > the first one. Statically initialized SRWLOCKs seem to be the natural > way to solve the problem... > > Ken, Takashi, can you please test it both, just to get as much testing > as possible? The new patch also works fine for me. -- Takashi Yano