From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from conssluserg-01.nifty.com (conssluserg-01.nifty.com [210.131.2.80]) by sourceware.org (Postfix) with ESMTPS id 198C8385841F for ; Mon, 15 Nov 2021 23:35:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 198C8385841F Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=nifty.ne.jp Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=nifty.ne.jp Received: from Express5800-S70 (z221123.dynamic.ppp.asahi-net.or.jp [110.4.221.123]) (authenticated) by conssluserg-01.nifty.com with ESMTP id 1AFNZaJL031399 for ; Tue, 16 Nov 2021 08:35:36 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-01.nifty.com 1AFNZaJL031399 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.ne.jp; s=dec2015msa; t=1637019336; bh=QwacZplqoUNM9FIOGAY1LEv6MvIK50GWJl1D5fguPDY=; h=Date:From:To:Subject:In-Reply-To:References:From; b=oOaojOE88tVEip/2Y2pflI2a/2L8kkvsS0SB6woErpv8wMkGW1k7/RuDUmCLe+O3s TYlNvTLY6B7NePGryn+8E1UfW5EJUaIKSszCgkZjT2BRsUx3zhiyuJCY5k/tPryy+7 5azNLkBcbnOYmcPtac9IHKXYi7KSbmEAdetPy2bu6V8b7iQzZXicpf9hZohcbtH2tU bD3db8P5JJagex05TKDE7SvJ7xQ0BmBy28zu+ee4U1eIXXkAXMygjPIZ22BdDMYu4o e7X8IgaucWz2D9MBnrZVOz4m5+d+xpAI2/CU1P/hwGU+rjpoKYa/5r/h8nns+oZhL2 hw6J8JZrBi/hA== X-Nifty-SrcIP: [110.4.221.123] Date: Tue, 16 Nov 2021 08:35:44 +0900 From: Takashi Yano To: cygwin-developers@cygwin.com Subject: Re: cygwin 3.3.x: another problem that may be related to pipes Message-Id: <20211116083544.88b6674b42deff69ba39db10@nifty.ne.jp> In-Reply-To: <3bf5793a-d9fe-6ca8-9812-d50fff3cffe9@cornell.edu> References: <115203324.649908.1636923059546.ref@mail.yahoo.com> <115203324.649908.1636923059546@mail.yahoo.com> <20211115171811.844dce9cce2b4d13262d64f2@nifty.ne.jp> <20211115235021.0f0f64b1b0e2a7bd6d16be80@nifty.ne.jp> <9a7bdf86-0721-870f-b7ea-00d958967c98@cornell.edu> <20211116015239.57d5f981ffdb3196039258da@nifty.ne.jp> <3bf5793a-d9fe-6ca8-9812-d50fff3cffe9@cornell.edu> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Nov 2021 23:35:56 -0000 On Mon, 15 Nov 2021 13:47:44 -0500 Ken Brown wrote: > On 11/15/2021 11:52 AM, Takashi Yano wrote: > > On Mon, 15 Nov 2021 11:37:30 -0500 > > Ken Brown wrote: > >> On 11/15/2021 11:08 AM, Corinna Vinschen wrote: > >>> The idea was to do change to synchronous pipes only for 3.4. I have a > >>> bit of headaches to change the pipes to synchronous as bug fix on the > >>> 3.3 branch. Your first ideas might be better there... > >> > >> I agree. I'd rather fix the bugs with asynchronous pipes on the 3.3 branch and > >> only switch to synchronous pipes for 3.4. > > > > I also agree with you. > > > > So, currently we have three options. > > > > 1) Call CancelIo() immediately after STATUS_PENDING like my patch. > > 2) Wait for pipe handle after STATUS_PENDING for nonblocking mode > > like Ken's patch. > > 3) Create evt event even for nonblocking mode as Corinna mentioned. > > > > Which is the best solution, do you think? > > I'm completely unbiased, of course, but I like option 2. OK. Shall I make a patch? Or would you like to do that? What should we do for master branch? I think topic/pipe is still under test. So, should we apply the same patch to master as well as cygwin-3_3-branch? -- Takashi Yano