From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from conssluserg-01.nifty.com (conssluserg-01.nifty.com [210.131.2.80]) by sourceware.org (Postfix) with ESMTPS id 103E43858410 for ; Tue, 16 Nov 2021 23:47:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 103E43858410 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=nifty.ne.jp Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=nifty.ne.jp Received: from Express5800-S70 (z221123.dynamic.ppp.asahi-net.or.jp [110.4.221.123]) (authenticated) by conssluserg-01.nifty.com with ESMTP id 1AGNkgvp001336 for ; Wed, 17 Nov 2021 08:46:42 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-01.nifty.com 1AGNkgvp001336 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.ne.jp; s=dec2015msa; t=1637106402; bh=DZ+ncATnjs1aY+Q347YbGl36U+ZwiQR24S+b1uNieuU=; h=Date:From:To:Subject:In-Reply-To:References:From; b=wRG/Fkn/Q/KIMUI4bBa8Ia8BKtAl1x53hj1usMr7TU57BJQFpFnyEDg5N0FeTlV2t u4ED7PmO+z9l9KxHFLbITxP53pRLC6EByInOhNDDd7FRU2kvDIq+OiDHpjx1pNmltb qbO8kH5vmBzgePzNa41i2LMgi53OZXP5fgH6hQsHbq4MEM3AQGeCg02Vt5NAVEnNb3 ChQmRpxlpoZE3YSzHFy1ccXi5v67Z1SayTCb+NisUOGQITU8zSvKrTHHJWiL7gfXQH OyeEnTDrkiajatQijQ+MqGFiPt+94Of/ZLttRADr4XDJizxo1+HM89HoBP1cJEEd19 inmsj2Tbp+mFg== X-Nifty-SrcIP: [110.4.221.123] Date: Wed, 17 Nov 2021 08:46:50 +0900 From: Takashi Yano To: cygwin-developers@cygwin.com Subject: Re: 3.3.0: Possible regression in cygwin DLL (Win10); fixed in snapshot Message-Id: <20211117084650.67be932e7762ecc8b1dbfb5d@nifty.ne.jp> In-Reply-To: References: <20211105170542.96ce6dd4ca32880ddfddd660@nifty.ne.jp> <20211106044116.698b465a5d8ed6ce2cc75c99@nifty.ne.jp> <2cfa5de7-3b95-9062-4572-f36d304bc916@cornell.edu> <20211106151047.4d8f626bd6ebe9e4d8017f3b@nifty.ne.jp> <20211110173003.88359e8482ffa8b8be326903@nifty.ne.jp> <20211110223049.b61c6cb87fb3e540b4214bcf@nifty.ne.jp> <62c481e4-2439-ee1c-8f9a-3e35fe9eb87e@cornell.edu> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Multipart=_Wed__17_Nov_2021_08_46_50_+0900_uGkBVx_X1d1zJVjH" X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Nov 2021 23:47:24 -0000 This is a multi-part message in MIME format. --Multipart=_Wed__17_Nov_2021_08_46_50_+0900_uGkBVx_X1d1zJVjH Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On Thu, 11 Nov 2021 11:11:10 -0500 Ken Brown wrote: > On 11/10/2021 4:32 PM, Ken Brown wrote: > > On 11/10/2021 3:35 PM, Corinna Vinschen wrote: > >> On Nov 10 22:30, Takashi Yano wrote: > >>> Thanks. I have just pushed the experimental patch to topic/pipe. > >>> Please try. If something wrong, please point it out. > >> > >> Great, I'll have a look.  Ken, you're looking as well, right? > > > > Yes.  It looks good on a first read-through.  I want to look again and do some > > testing.  One minor thing I noticed is that fhandler_pipe::raw_read could be > > cleaned up a little more: There are still references to STATUS_THREAD_SIGNALED > > and STATUS_THREAD_CANCELED, which can't occur any more. > > It still looks good after a second read. I'll try using it in my normal Cygwin > install to make sure no problems come up. > > I've pushed a cleanup patch removing STATUS_THREAD_SIGNALED and > STATUS_THREAD_CANCELED, as well as a patch documenting the new behavior of the > pipe_byte option. I have just rebased topic/pipe to current master. I also would like to propose patch attached for topic/pipe. Please have a look. -- Takashi Yano --Multipart=_Wed__17_Nov_2021_08_46_50_+0900_uGkBVx_X1d1zJVjH Content-Type: application/octet-stream; name="0001-Cygwin-pipe-Suppress-unnecessary-set_pipe_non_blocki.patch" Content-Disposition: attachment; filename="0001-Cygwin-pipe-Suppress-unnecessary-set_pipe_non_blocki.patch" Content-Transfer-Encoding: base64 RnJvbSA1NDQyOTJmODFkODkxNGI4NTEwZjM5ZmUwN2QyYjA1Y2Q0ZTk5ODI4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiVS1FWFBSRVNTNTgwMC1TNzBcXHlhbm8iIDx0YWthc2hpLnlh bm9AbmlmdHkubmUuanA+CkRhdGU6IFR1ZSwgMTYgTm92IDIwMjEgMjA6NTk6MDkgKzA5MDAKU3Vi amVjdDogW1BBVENIXSBDeWd3aW46IHBpcGU6IFN1cHByZXNzIHVubmVjZXNzYXJ5IHNldF9waXBl X25vbl9ibG9ja2luZygpCiBjYWxsLgoKLSBDYWxsIHNldF9waXBlX25vbl9ibG9ja2luZyhmYWxz ZSkgb25seSBpZiB0aGUgcGlwZSB3aWxsIGJlIHJlYWxseQogIGluaGVyaXRlZCB0byBub24tY3ln d2luIHByb2Nlc3MuCi0gU2V0IGJsb2NraW5nIG1vZGUgcHJvcGVybHkgd2hlbiBjeWd3aW4gcHJv Y2VzcyBpcyBleGVjdXRlZCBmcm9tIG5vbi0KICBjeWd3aW4gcHJvY2Vzcy4KLS0tCiB3aW5zdXAv Y3lnd2luL2R0YWJsZS5jYyB8IDMgKysrCiB3aW5zdXAvY3lnd2luL3NwYXduLmNjICB8IDkgKysr KysrLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS93aW5zdXAvY3lnd2luL2R0YWJsZS5jYyBiL3dpbnN1cC9jeWd3aW4vZHRh YmxlLmNjCmluZGV4IGQ1N2NiYjM1NS4uZTU0ZGI0NDQ2IDEwMDY0NAotLS0gYS93aW5zdXAvY3ln d2luL2R0YWJsZS5jYworKysgYi93aW5zdXAvY3lnd2luL2R0YWJsZS5jYwpAQCAtNDEwLDYgKzQx MCw5IEBAIGR0YWJsZTo6aW5pdF9zdGRfZmlsZV9mcm9tX2hhbmRsZSAoaW50IGZkLCBIQU5ETEUg aGFuZGxlKQogCXsKIAkgIGZoYW5kbGVyX3BpcGUgKmZocCA9IChmaGFuZGxlcl9waXBlICopIGZo OwogCSAgZmhwLT5zZXRfcGlwZV9idWZfc2l6ZSAoKTsKKwkgIC8qIFNldCByZWFkIHBpcGUgYWx3 YXlzIHRvIG5vbmJsb2NraW5nICovCisJICBmaHAtPnNldF9waXBlX25vbl9ibG9ja2luZyAoZmhw LT5nZXRfZGV2aWNlICgpID09IEZIX1BJUEVSID8KKwkJCQkgICAgICB0cnVlIDogZmhwLT5pc19u b25ibG9ja2luZyAoKSk7CiAJfQogCiAgICAgICBpZiAoIWZoLT5vcGVuX3NldHVwIChvcGVuZmxh Z3MpKQpkaWZmIC0tZ2l0IGEvd2luc3VwL2N5Z3dpbi9zcGF3bi5jYyBiL3dpbnN1cC9jeWd3aW4v c3Bhd24uY2MKaW5kZXggNmIyMDI2Nzc2Li5lMTYwZmEzYmIgMTAwNjQ0Ci0tLSBhL3dpbnN1cC9j eWd3aW4vc3Bhd24uY2MKKysrIGIvd2luc3VwL2N5Z3dpbi9zcGF3bi5jYwpAQCAtNjQ4LDggKzY0 OCw5IEBAIGNoaWxkX2luZm9fc3Bhd246OndvcmtlciAoY29uc3QgY2hhciAqcHJvZ19hcmcsIGNv bnN0IGNoYXIgKmNvbnN0ICphcmd2LAogCiAgICAgICBpZiAoIWlzY3lnd2luICgpKQogCXsKKwkg IGludCBmZDsKIAkgIGNmZC5yZXdpbmQgKCk7Ci0JICB3aGlsZSAoY2ZkLm5leHQgKCkgPj0gMCkK KwkgIHdoaWxlICgoZmQgPSBjZmQubmV4dCAoKSkgPj0gMCkKIAkgICAgaWYgKGNmZC0+Z2V0X21h am9yICgpID09IERFVl9QVFlTX01BSk9SKQogCSAgICAgIHsKIAkJZmhhbmRsZXJfcHR5X3NsYXZl ICpwdHlzID0KQEAgLTY1NywxMyArNjU4LDE1IEBAIGNoaWxkX2luZm9fc3Bhd246OndvcmtlciAo Y29uc3QgY2hhciAqcHJvZ19hcmcsIGNvbnN0IGNoYXIgKmNvbnN0ICphcmd2LAogCQlwdHlzLT5j cmVhdGVfaW52aXNpYmxlX2NvbnNvbGUgKCk7CiAJCXB0eXMtPnNldHVwX2xvY2FsZSAoKTsKIAkg ICAgICB9Ci0JICAgIGVsc2UgaWYgKGNmZC0+Z2V0X2RldiAoKSA9PSBGSF9QSVBFVykKKwkgICAg ZWxzZSBpZiAoY2ZkLT5nZXRfZGV2ICgpID09IEZIX1BJUEVXCisJCSAgICAgJiYgKGZkID09IChp bl9fc3Rkb3V0IDwgMCA/IDEgOiBpbl9fc3Rkb3V0KSB8fCBmZCA9PSAyKSkKIAkgICAgICB7CiAJ CWZoYW5kbGVyX3BpcGUgKnBpcGUgPSAoZmhhbmRsZXJfcGlwZSAqKShmaGFuZGxlcl9iYXNlICop IGNmZDsKIAkJcGlwZS0+Y2xvc2VfcXVlcnlfaGFuZGxlICgpOwogCQlwaXBlLT5zZXRfcGlwZV9u b25fYmxvY2tpbmcgKGZhbHNlKTsKIAkgICAgICB9Ci0JICAgIGVsc2UgaWYgKGNmZC0+Z2V0X2Rl diAoKSA9PSBGSF9QSVBFUikKKwkgICAgZWxzZSBpZiAoY2ZkLT5nZXRfZGV2ICgpID09IEZIX1BJ UEVSCisJCSAgICAgJiYgZmQgPT0gKGluX19zdGRpbiA8IDAgPyAwIDogaW5fX3N0ZGluKSkKIAkg ICAgICB7CiAJCWZoYW5kbGVyX3BpcGUgKnBpcGUgPSAoZmhhbmRsZXJfcGlwZSAqKShmaGFuZGxl cl9iYXNlICopIGNmZDsKIAkJcGlwZS0+c2V0X3BpcGVfbm9uX2Jsb2NraW5nIChmYWxzZSk7Ci0t IAoyLjMzLjAKCg== --Multipart=_Wed__17_Nov_2021_08_46_50_+0900_uGkBVx_X1d1zJVjH--