Re: 3.3.0: Possible regression in cygwin DLL (Win10); fixed in snapshot

[Takashi Yano <takashi.yano@nifty.ne.jp>]

[-- Attachment #1: Type: text/plain, Size: 1557 bytes --]

On Wed, 17 Nov 2021 08:46:50 +0900
Takashi Yano wrote:
> On Thu, 11 Nov 2021 11:11:10 -0500
> Ken Brown wrote:
> > On 11/10/2021 4:32 PM, Ken Brown wrote:
> > > On 11/10/2021 3:35 PM, Corinna Vinschen wrote:
> > >> On Nov 10 22:30, Takashi Yano wrote:
> > >>> Thanks. I have just pushed the experimental patch to topic/pipe.
> > >>> Please try. If something wrong, please point it out.
> > >>
> > >> Great, I'll have a look.  Ken, you're looking as well, right?
> > > 
> > > Yes.  It looks good on a first read-through.  I want to look again and do some 
> > > testing.  One minor thing I noticed is that fhandler_pipe::raw_read could be 
> > > cleaned up a little more: There are still references to STATUS_THREAD_SIGNALED 
> > > and STATUS_THREAD_CANCELED, which can't occur any more.
> > 
> > It still looks good after a second read.  I'll try using it in my normal Cygwin 
> > install to make sure no problems come up.
> > 
> > I've pushed a cleanup patch removing STATUS_THREAD_SIGNALED and 
> > STATUS_THREAD_CANCELED, as well as a patch documenting the new behavior of the 
> > pipe_byte option.
> 
> I have just rebased topic/pipe to current master.
> 
> I also would like to propose patch attached for topic/pipe.
> Please have a look.

Ah, the spawn.cc part of this patch should be applied not
only topic/pipe but also master and cygwin-3_3-branch.
I have resubmitted that to cygwin-patches mailing list.

Only the dtable.cc part of this patch is for topic/pipe.
Please have a look attached patch.

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>

[-- Attachment #2: 0001-Cygwin-pipe-Restore-blocking-mode-for-cygwin-process.patch --]
[-- Type: application/octet-stream, Size: 976 bytes --]

From 142c87193b6074e2cee8bd4b3a78b33ee7d705e8 Mon Sep 17 00:00:00 2001
From: Takashi Yano <takashi.yano@nifty.ne.jp>
Date: Wed, 17 Nov 2021 13:08:05 +0900
Subject: [PATCH] Cygwin: pipe: Restore blocking mode for cygwin process at
 startup.

- Set blocking mode properly at startup of cygwin process. This is
  needed if the cygwin process is executed from non-cygwin process.
---
 winsup/cygwin/dtable.cc | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/winsup/cygwin/dtable.cc b/winsup/cygwin/dtable.cc
index d57cbb355..e54db4446 100644
--- a/winsup/cygwin/dtable.cc
+++ b/winsup/cygwin/dtable.cc
@@ -410,6 +410,9 @@ dtable::init_std_file_from_handle (int fd, HANDLE handle)
 	{
 	  fhandler_pipe *fhp = (fhandler_pipe *) fh;
 	  fhp->set_pipe_buf_size ();
+	  /* Set read pipe always to nonblocking */
+	  fhp->set_pipe_non_blocking (fhp->get_device () == FH_PIPER ?
+				      true : fhp->is_nonblocking ());
 	}
 
       if (!fh->open_setup (openflags))
-- 
2.33.0