From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from conssluserg-05.nifty.com (conssluserg-05.nifty.com [210.131.2.90]) by sourceware.org (Postfix) with ESMTPS id 8E1073858C2F for ; Tue, 22 Nov 2022 22:46:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8E1073858C2F Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=nifty.ne.jp Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=nifty.ne.jp Received: from HP-Z230 (w165151.dynamic.ppp.asahi-net.or.jp [121.1.165.151]) (authenticated) by conssluserg-05.nifty.com with ESMTP id 2AMMkVU2029653 for ; Wed, 23 Nov 2022 07:46:31 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-05.nifty.com 2AMMkVU2029653 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.ne.jp; s=dec2015msa; t=1669157191; bh=pjdKsdOXox1mBKJR11eXMfovw80yIj4+4B2Z5YmjzJM=; h=Date:From:To:Subject:In-Reply-To:References:From; b=FPLrAsVYkD5q9dd6KGtoYeBrQRni0CzBsyAzl9vSwQ8G39UwIrVPdOKTwnE/jMH/M RuA1EEZjdVjKx8FL+BE8DQv4MufkUq54YK7pSqrHHOrqugIzM7hdg8QYJdErinyRrF eyTq/3AKC6dqk24LVTqBdH/1n5d446xRH6974JUORZBREd0rN/6Kzop+2WG4q8cYa6 lTmxcdyQ2ceHw3RWvfNGz8e7yT6OhBsaYZ2E6T6EH9P2PMtcnVaD3CSQse7iId8Vj6 2/uyiO/m8RP29u6IHpHNB+1xksALXfalQVBweopuYaSXiClfw+1HKLpzP3A3YD8DLH /b4OlKd4nWDsQ== X-Nifty-SrcIP: [121.1.165.151] Date: Wed, 23 Nov 2022 07:46:32 +0900 From: Takashi Yano To: cygwin-developers@cygwin.com Subject: Re: tty.cc and fhandler/tty.cc Message-Id: <20221123074632.f1799d6f6039973e9bd000d6@nifty.ne.jp> In-Reply-To: References: <20221122173115.b94b586200e0accf88512309@nifty.ne.jp> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 22 Nov 2022 10:36:28 +0100 Corinna Vinschen wrote: > On Nov 22 17:31, Takashi Yano wrote: > > fhandler/tty.cc is defining fhandler_pty_{common,master,slave} class, > > so, what about renaming fhandler/tty.cc to fhandler/pty.cc? > > Maybe we could split it up. The extern functions could go into > syscalls.cc and the tty classes could go into fhandler/termios.cc, > perhaps. There are already two tty_min methods in that file. > > What do you think? It looks good alternative. On Tue, 22 Nov 2022 10:50:46 +0100 Corinna Vinschen wrote: > If we don't split, maybe something like tty_helper.cc would be more > feasible? tty.cc mainly implements the tty/tty_min classes and at least > the latter is used for consoles, too. Pty.cc might be a bit misleading Well, I meant winsup/cygwin/tty.cc and winsup/cygwin/fhandler/pty.cc . Not winsup/cygwin/pty.cc and winsup/cygwin/fhandler/tty.cc -- Takashi Yano