From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from conssluserg-04.nifty.com (conssluserg-04.nifty.com [210.131.2.83]) by sourceware.org (Postfix) with ESMTPS id C56AE3844002 for ; Thu, 24 Nov 2022 08:24:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C56AE3844002 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=nifty.ne.jp Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=nifty.ne.jp Received: from HP-Z230 (w165151.dynamic.ppp.asahi-net.or.jp [121.1.165.151]) (authenticated) by conssluserg-04.nifty.com with ESMTP id 2AO8O1O2009709 for ; Thu, 24 Nov 2022 17:24:01 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-04.nifty.com 2AO8O1O2009709 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.ne.jp; s=dec2015msa; t=1669278241; bh=6AAJMl6mHZXNbMY8pV0JGvu78/sPuE95E2P4FHhk+ls=; h=Date:From:To:Subject:In-Reply-To:References:From; b=mP+UywtUV5rdNv/J/Zw9hqIbGxmdRUAJ5Xrem7wSQE0xd3tW2j+YSKZstUITqEmo7 E7+3ChgH4jJLrFNNxkO3QpP8ZFviUV+FoEqoFdrgQDPm5sydGb7eowSRFCpEQmS44T Hip6yei6ty8ygpu1wgRVHwBovx+tpe9iBvAc8Wbf2JZH6L7kWeB1Cls1hSt1O4EdQr z+Y7FbGqqOSOQjHBCizwx5YzvDIpYRSDbsKh7KDzeO5tp6pDj6Sf0tfYfD43VZPUlL LbWATOOWo7QH+kB9MubOu+9+3xSsjq63GSx5ujfn5bgiLIgGZRyeFulQ6oRgmJOVUA ks5F3sPhVThuQ== X-Nifty-SrcIP: [121.1.165.151] Date: Thu, 24 Nov 2022 17:24:02 +0900 From: Takashi Yano To: cygwin-developers@cygwin.com Subject: Re: tty.cc and fhandler/tty.cc Message-Id: <20221124172402.214c49a8aa0a65fd411b7497@nifty.ne.jp> In-Reply-To: References: <20221122173115.b94b586200e0accf88512309@nifty.ne.jp> <20221123074632.f1799d6f6039973e9bd000d6@nifty.ne.jp> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 23 Nov 2022 10:08:11 +0100 Corinna Vinschen wrote: > On Nov 23 07:46, Takashi Yano wrote: > > Well, I meant > > winsup/cygwin/tty.cc > > and > > winsup/cygwin/fhandler/pty.cc > > . > > Oh, right! Yeah, that makes perfect sense! Then, which is better solution? On Tue, 22 Nov 2022 10:36:28 +0100 Corinna Vinschen wrote: > Maybe we could split it up. The extern functions could go into > syscalls.cc and the tty classes could go into fhandler/termios.cc, > perhaps. There are already two tty_min methods in that file. or renaming fhandler/tty.cc? What do you think? -- Takashi Yano